Add command logging and test foundation

Author: SaveEditors

.gitignore

@@ -3,6 +3,9 @@
 /obj/
 /src/**/bin/
 /src/**/obj/
+/tests/**/bin/
+/tests/**/obj/
+/tests/**/TestResults/
 /decompiled/bin/
 /decompiled/obj/
 

XeCLI.sln

@@ -1,4 +1,3 @@
-
 Microsoft Visual Studio Solution File, Format Version 12.00
 # Visual Studio Version 17
 VisualStudioVersion = 17.13.35931.197
@@ -9,6 +8,8 @@ Project("{FAE04EC0-301F-11D3-BF4B-00C04F79EFBC}") = "Xbox360.Remote.Cli", "src\\
 EndProject
 Project("{FAE04EC0-301F-11D3-BF4B-00C04F79EFBC}") = "Xbox360.Fatx", "src\\Xbox360.Fatx\\Xbox360.Fatx.csproj", "{A2C2BF7E-BA9E-4FD4-B624-38646E4C8140}"
 EndProject
+Project("{FAE04EC0-301F-11D3-BF4B-00C04F79EFBC}") = "XeCLI.Tests", "tests\\XeCLI.Tests\\XeCLI.Tests.csproj", "{44CA1A12-446A-48AB-B5FF-C801BA7BDFCF}"
+EndProject
 Global
 	GlobalSection(SolutionConfigurationPlatforms) = preSolution
 		Debug|Any CPU = Debug|Any CPU
@@ -27,5 +28,9 @@ Global
 		{A2C2BF7E-BA9E-4FD4-B624-38646E4C8140}.Debug|Any CPU.Build.0 = Debug|Any CPU
 		{A2C2BF7E-BA9E-4FD4-B624-38646E4C8140}.Release|Any CPU.ActiveCfg = Release|Any CPU
 		{A2C2BF7E-BA9E-4FD4-B624-38646E4C8140}.Release|Any CPU.Build.0 = Release|Any CPU
+		{44CA1A12-446A-48AB-B5FF-C801BA7BDFCF}.Debug|Any CPU.ActiveCfg = Debug|Any CPU
+		{44CA1A12-446A-48AB-B5FF-C801BA7BDFCF}.Debug|Any CPU.Build.0 = Debug|Any CPU
+		{44CA1A12-446A-48AB-B5FF-C801BA7BDFCF}.Release|Any CPU.ActiveCfg = Release|Any CPU
+		{44CA1A12-446A-48AB-B5FF-C801BA7BDFCF}.Release|Any CPU.Build.0 = Release|Any CPU
 	EndGlobalSection
 EndGlobal

docs/gui-visual-proof.md

@@ -30,9 +30,15 @@ The proof must confirm that state text matches the live console state.
 
 Check these strings against the actual UI state:
 
-- `Not connected`
-- `Connecting`
-- `Connected`
+- `DISCONNECTED`
+- `CONNECTING`
+- `CONNECTED`
+
+Check link state labels against the actual UI state:
+
+- `LINK OFFLINE`
+- `LINK ACTIVE`
+- `NOT CONNECTED`
 
 Do not accept a screenshot if the text reads as one state while the session is actually another.
 
@@ -42,6 +48,7 @@ Do not accept a screenshot if the text reads as one state while the session is a
 - Keep the window size and scaling stable during the run.
 - Do not crop away the parts that show current state, console target, or connection status.
 - Build contact sheets so reviewers can scan the whole set quickly.
+- Keep raw screenshots local unless the run has been separately redacted for publication.
 
 ## OCR Rules
 
@@ -71,5 +78,10 @@ Before anything leaves the local machine:
 - redact local paths when they reveal private machine layout
 - redact tokens, keys, and live network details
 
-Keep raw screenshots and OCR text local unless the run is being used as private proof for the current task.
+`scripts/run-visual-proof.ps1 -RedactText` writes `*-redacted` wrapper outputs with IPs and local paths masked in text fields, plus redacted copies of the smoke `report.md` and `summary.json` artifacts.
 
+`scripts/run-visual-proof.ps1 -RedactText` writes `*-redacted` wrapper artifacts, and the contact-sheet builder pixel-masks common text zones in thumbnails while still redacting the generated JSON labels.
+
+`scripts/build-contact-sheets.ps1 -RedactText` applies the same pixel masking when the sheet builder is run directly. Without `-RedactText`, the PNG contact sheet remains local-only proof.
+
+Keep raw screenshots and OCR text local unless the run is being used as private proof for the current task.

scripts/build-contact-sheets.ps1

@@ -5,7 +5,8 @@ param(
     [string]$Out,
     [int]$Columns = 2,
     [int]$ThumbWidth = 480,
-    [int]$ThumbHeight = 270
+    [int]$ThumbHeight = 270,
+    [switch]$RedactText
 )
 
 $ErrorActionPreference = "Stop"
@@ -37,6 +38,41 @@ function Get-RelativeDisplayPath {
     return [System.IO.Path]::GetFileName($full)
 }
 
+function Get-DisplayPath {
+    param(
+        [string]$Path
+    )
+
+    if (-not $RedactText) {
+        return $Path
+    }
+
+    return Redact-Text (Get-RelativeDisplayPath -BasePath $repoRoot -Path $Path)
+}
+
+function Redact-Text {
+    param(
+        [string]$Text
+    )
+
+    if ([string]::IsNullOrEmpty($Text)) {
+        return $Text
+    }
+
+    $redacted = [regex]::Replace(
+        $Text,
+        '(?<!\d)(?:25[0-5]|2[0-4]\d|1?\d?\d)(?:\.(?:25[0-5]|2[0-4]\d|1?\d?\d)){3}(?!\d)',
+        '<redacted-ipv4>'
+    )
+    $redacted = [regex]::Replace(
+        $redacted,
+        '(?i)(?:[A-Z]:\\|\\\\)[^\r\n`"]+(?:\\[^\r\n`"]+)*',
+        '[redacted-path]'
+    )
+
+    return $redacted
+}
+
 $repoRoot = (Resolve-Path (Join-Path $PSScriptRoot "..")).Path
 $inputDir = Resolve-RepoPath $InputDir
 $outPath = Resolve-RepoPath $Out
@@ -61,7 +97,7 @@ if (-not $ThumbHeight -or $ThumbHeight -lt 1) {
 Add-Type -AssemblyName System.Drawing
 
 $pngs = Get-ChildItem -Path $inputDir -Recurse -File -Filter "*.png" | Where-Object {
-    $_.FullName -ne $outPath
+    $_.FullName -ne $outPath -and $_.Name -notmatch '^(?i)(?:visual-proof-)?contact-sheet.*\.png$'
 } | Sort-Object FullName
 if ($pngs.Count -eq 0) {
     throw "No PNG images were found under $inputDir"
@@ -80,15 +116,17 @@ $summary = [ordered]@{
     Status = "Running"
     StartedUtc = [DateTimeOffset]::UtcNow.ToString("O")
     FinishedUtc = $null
-    InputDir = $inputDir
-    Output = $outPath
+    InputDir = Get-DisplayPath $inputDir
+    Output = Get-DisplayPath $outPath
     Columns = $Columns
     ThumbWidth = $ThumbWidth
     ThumbHeight = $ThumbHeight
     ImageCount = $pngs.Count
     Rows = $rows
     SheetWidth = $sheetWidth
     SheetHeight = $sheetHeight
+    RedactionMode = if ($RedactText) { "pixel-masked-thumbnails+text" } else { "none" }
+    PublishSafe = [bool]$RedactText
     Images = @()
 }
 
@@ -114,7 +152,31 @@ try {
     $highlightPen = New-Object System.Drawing.Pen([System.Drawing.Color]::FromArgb(179, 179, 179))
     $cardBrush = New-Object System.Drawing.SolidBrush([System.Drawing.Color]::White)
     $labelBgBrush = New-Object System.Drawing.SolidBrush([System.Drawing.Color]::FromArgb(235, 237, 240))
-    $resources += $titleBrush, $labelBrush, $borderPen, $highlightPen, $cardBrush, $labelBgBrush
+    $maskBrush = New-Object System.Drawing.SolidBrush([System.Drawing.Color]::FromArgb(245, 246, 248))
+    $resources += $titleBrush, $labelBrush, $borderPen, $highlightPen, $cardBrush, $labelBgBrush, $maskBrush
+
+    function Mask-ThumbnailTextZones {
+        param(
+            [System.Drawing.Graphics]$Graphics,
+            [int]$X,
+            [int]$Y,
+            [int]$Width,
+            [int]$Height,
+            [System.Drawing.Brush]$Brush
+        )
+
+        if ($Width -le 0 -or $Height -le 0) {
+            return
+        }
+
+        $topMaskHeight = [Math]::Min($Height, [Math]::Max(36, [int][Math]::Round($Height * 0.30)))
+        $bottomMaskHeight = [Math]::Min([Math]::Max(20, [int][Math]::Round($Height * 0.16)), $Height)
+
+        $Graphics.FillRectangle($Brush, $X, $Y, $Width, $topMaskHeight)
+        if ($bottomMaskHeight -lt $Height) {
+            $Graphics.FillRectangle($Brush, $X, $Y + $Height - $bottomMaskHeight, $Width, $bottomMaskHeight)
+        }
+    }
 
     $title = "XeCLI visual proof contact sheet"
     $graphics.DrawString($title, $titleFont, $titleBrush, 16, 10)
@@ -137,9 +199,10 @@ try {
         $graphics.DrawRectangle($highlightPen, $imageAreaX, $labelY, $imageAreaWidth, $labelHeight)
 
         $label = Get-RelativeDisplayPath -BasePath $inputDir -Path $file.FullName
+        $displayLabel = if ($RedactText) { Redact-Text $label } else { $label }
         $summary.Images += [ordered]@{
-            File = $file.FullName
-            Label = $label
+            File = Get-DisplayPath $file.FullName
+            Label = $displayLabel
             Size = $file.Length
             LastWriteTimeUtc = $file.LastWriteTimeUtc.ToString("O")
         }
@@ -154,6 +217,9 @@ try {
 
             $graphics.FillRectangle([System.Drawing.Brushes]::White, $imageAreaX, $imageAreaY, $ThumbWidth, $ThumbHeight)
             $graphics.DrawImage($image, $drawX, $drawY, $drawWidth, $drawHeight)
+            if ($RedactText) {
+                Mask-ThumbnailTextZones -Graphics $graphics -X $imageAreaX -Y $imageAreaY -Width $ThumbWidth -Height $ThumbHeight -Brush $maskBrush
+            }
         }
         finally {
             $image.Dispose()
@@ -163,7 +229,7 @@ try {
         $format = New-Object System.Drawing.StringFormat
         $format.Trimming = [System.Drawing.StringTrimming]::EllipsisCharacter
         $format.FormatFlags = [System.Drawing.StringFormatFlags]::LineLimit
-        $graphics.DrawString($label, $labelFont, $labelBrush, $textRect, $format)
+        $graphics.DrawString($displayLabel, $labelFont, $labelBrush, $textRect, $format)
         $format.Dispose()
     }
 
@@ -177,6 +243,12 @@ catch {
 finally {
     $summary.FinishedUtc = [DateTimeOffset]::UtcNow.ToString("O")
     $summaryPath = [System.IO.Path]::ChangeExtension($outPath, ".json")
+    if ($RedactText) {
+        foreach ($imageSummary in $summary.Images) {
+            $imageSummary.Label = Redact-Text $imageSummary.Label
+            $imageSummary.File = Redact-Text $imageSummary.File
+        }
+    }
     $summary | ConvertTo-Json -Depth 8 | Set-Content -Path $summaryPath -Encoding UTF8
 
     foreach ($font in $fonts) {
@@ -191,9 +263,11 @@ finally {
 
 [pscustomobject]@{
     Status = $summary.Status
-    Output = $outPath
-    Summary = [System.IO.Path]::ChangeExtension($outPath, ".json")
+    Output = Get-DisplayPath $outPath
+    Summary = Get-DisplayPath ([System.IO.Path]::ChangeExtension($outPath, ".json"))
     ImageCount = $summary.ImageCount
     Rows = $summary.Rows
     Columns = $summary.Columns
+    RedactionMode = $summary.RedactionMode
+    PublishSafe = $summary.PublishSafe
 }