Merge pull request #518 from ChrisRackauckas-Claude/fix-ci-isolate-jet-qa

Fix CI: isolate JET/QA tests and fix Runic formatting

Author: ChrisRackauckas

.github/workflows/QA.yml

@@ -0,0 +1,42 @@
+name: "QA"
+
+on:
+  pull_request:
+    branches:
+      - master
+    paths-ignore:
+      - 'docs/**'
+  push:
+    branches:
+      - master
+    paths-ignore:
+      - 'docs/**'
+
+concurrency:
+  group: ${{ github.workflow }}-${{ github.ref }}
+  cancel-in-progress: ${{ github.ref_name != github.event.repository.default_branch || github.ref != 'refs/tags/v*' }}
+
+jobs:
+  qa:
+    name: "QA"
+    runs-on: ubuntu-latest
+    strategy:
+      fail-fast: false
+      matrix:
+        version:
+          - "1"
+          - "lts"
+    steps:
+      - uses: actions/checkout@v6
+      - uses: julia-actions/setup-julia@v2
+        with:
+          version: ${{ matrix.version }}
+      - uses: julia-actions/cache@v2
+      - name: "Instantiate test/jet"
+        run: |
+          julia --project=test/jet -e '
+            using Pkg
+            Pkg.develop(path=".")
+            Pkg.instantiate()'
+      - name: "Run QA tests"
+        run: julia --project=test/jet test/jet/runtests.jl

Project.toml

@@ -25,18 +25,15 @@ SymbolicIndexingInterface = "2efcf032-c050-4f8e-a9bb-153293bab1f5"
 ADTypes = "1"
 Accessors = "0.1.38"
 AlgebraicMultigrid = "1"
-Aqua = "0.8"
 ArrayInterface = "7.17.1"
 CEnum = "0.5"
 DAEProblemLibrary = "0.1"
 DataStructures = "0.18, 0.19"
 DiffEqBase = "6.190.2"
 DiffEqCallbacks = "4"
 DifferentiationInterface = "0.6, 0.7"
-ExplicitImports = "1"
 ForwardDiff = "0.10"
 IncompleteLU = "0.2"
-JET = "0.11.2"
 Libdl = "1"
 LinearAlgebra = "1"
 LinearSolve = "3.40.0"
@@ -58,12 +55,9 @@ julia = "1.10"
 [extras]
 ADTypes = "47edcb42-4c32-4615-8424-f2b9edc5f35b"
 AlgebraicMultigrid = "2169fc97-5a83-5252-b627-83903c6c433c"
-Aqua = "4c88cf16-eb10-579e-8560-4a9242c79595"
-JET = "c3a54625-cd67-489e-a8e7-0a5a0ff4e31b"
 DAEProblemLibrary = "dfb8ca35-80a1-48ba-a605-84916a45b4f8"
 DiffEqCallbacks = "459566f4-90b8-5000-8ac3-15dfb0a30def"
 DifferentiationInterface = "a0c0ee7d-e4b9-4e03-894e-1c5f64a51d63"
-ExplicitImports = "7d51a73a-1435-4ff3-83d9-f097790105c7"
 ForwardDiff = "f6369f11-7733-5829-9624-2563aa707210"
 IncompleteLU = "40713840-3770-5561-ab4c-a76e7d0d7895"
 ModelingToolkit = "961ee093-0014-501f-94e3-6117800e7a78"
@@ -73,4 +67,4 @@ SparseConnectivityTracer = "9f842d2f-2579-4b1d-911e-f412cf18a3f5"
 Test = "8dfed614-e22c-5e08-85e1-65c5234f0b40"
 
 [targets]
-test = ["Test", "ADTypes", "AlgebraicMultigrid", "Aqua", "DiffEqCallbacks", "ExplicitImports", "JET", "ODEProblemLibrary", "DAEProblemLibrary", "ForwardDiff", "DifferentiationInterface", "SparseConnectivityTracer", "IncompleteLU", "ModelingToolkit", "SafeTestsets"]
+test = ["Test", "ADTypes", "AlgebraicMultigrid", "DiffEqCallbacks", "ODEProblemLibrary", "DAEProblemLibrary", "ForwardDiff", "DifferentiationInterface", "SparseConnectivityTracer", "IncompleteLU", "ModelingToolkit", "SafeTestsets"]

src/common_interface/integrator_types.jl

@@ -149,6 +149,8 @@ mutable struct ARKODEIntegrator{
     ctx_handle::ContextHandle
 end
 
+# runic: off
+# Runic reformats callable struct syntax in a way that is incompatible with Julia < 1.13
 function (integrator::ARKODEIntegrator{
         N, pType, solType, algType, fType, UFType, JType, oType,
         LStype, Atype, MLStype, Mtype, CallbackCacheType, ARKStepMem, IA,
@@ -220,6 +222,7 @@ function (integrator::ARKODEIntegrator{
     copyto!(out, out_nvec.v)
     return idxs === nothing ? out : @view out[idxs]
 end
+# runic: on
 
 mutable struct IDAIntegrator{
         N,

test/jet/Project.toml

@@ -0,0 +1,12 @@
+[deps]
+Aqua = "4c88cf16-eb10-579e-8560-4a9242c79595"
+ExplicitImports = "7d51a73a-1435-4ff3-83d9-f097790105c7"
+JET = "c3a54625-cd67-489e-a8e7-0a5a0ff4e31b"
+Sundials = "c3572dad-4567-51f8-b174-8c6c989267f4"
+Test = "8dfed614-e22c-5e08-85e1-65c5234f0b40"
+
+[compat]
+Aqua = "0.8"
+ExplicitImports = "1"
+JET = "0.9, 0.10, 0.11"
+Sundials = "5"

test/jet/runtests.jl

@@ -0,0 +1,50 @@
+using Sundials
+using Test
+
+@testset "Quality Assurance" begin
+    using Aqua
+    @testset "Aqua tests" begin
+        Aqua.test_ambiguities(Sundials; recursive = false)
+        Aqua.test_deps_compat(Sundials)
+        Aqua.test_piracies(
+            Sundials;
+            treat_as_own = [Sundials.NVector],
+        )
+        Aqua.test_project_extras(Sundials)
+        Aqua.test_stale_deps(Sundials)
+        Aqua.test_unbound_args(Sundials)
+        Aqua.test_undefined_exports(Sundials)
+    end
+
+    using ExplicitImports
+    @testset "ExplicitImports tests" begin
+        @test check_no_implicit_imports(Sundials) === nothing
+        @test check_no_stale_explicit_imports(Sundials) === nothing
+        # AbstractSciMLOperator is re-exported from SciMLBase, so allow it
+        @test check_all_explicit_imports_via_owners(
+            Sundials;
+            ignore = (:AbstractSciMLOperator,),
+        ) === nothing
+    end
+end
+
+@testset "JET Static Analysis" begin
+    using JET
+    # Test algorithm constructors for type stability
+    @testset "Algorithm constructors" begin
+        rep = JET.report_call(Sundials.CVODE_BDF, ())
+        @test length(JET.get_reports(rep)) == 0
+
+        rep = JET.report_call(Sundials.CVODE_Adams, ())
+        @test length(JET.get_reports(rep)) == 0
+
+        rep = JET.report_call(Sundials.IDA, ())
+        @test length(JET.get_reports(rep)) == 0
+
+        rep = JET.report_call(Sundials.ARKODE, ())
+        @test length(JET.get_reports(rep)) == 0
+
+        rep = JET.report_call(Sundials.KINSOL, ())
+        @test length(JET.get_reports(rep)) == 0
+    end
+end

test/runtests.jl

@@ -2,14 +2,6 @@ using Sundials
 using SafeTestsets
 using Test
 
-@testset "Quality Assurance" begin
-    include("qa_test.jl")
-end
-
-@testset "JET Static Analysis" begin
-    include("jet_test.jl")
-end
-
 @testset "Generator" begin
     include("generator.jl")
 end