Add JET.jl static analysis tests and fix Kriging type stability#529
Merged
ChrisRackauckas merged 1 commit intoSciML:masterfrom Dec 29, 2025
Conversation
- Fix Kriging eigenvalue computation to use Symmetric wrapper
- `eigen(R).values` replaced with `eigvals(Symmetric(R))` to guarantee
real eigenvalues for symmetric correlation matrices
- JET previously reported potential `isless(::Int, ::ComplexF64)` errors
- Also use `zero(λdiff)` instead of hardcoded `0.0` for better type stability
- Add JET.jl test suite (test/jet.jl)
- Tests core surrogate constructors for static analysis issues
- Added JET to test dependencies in Project.toml
🤖 Generated with [Claude Code](https://claude.com/claude-code)
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Member
|
JET tests should be in a nopre group! |
This was referenced Dec 30, 2025
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix Kriging eigenvalue computation for type stability: The
eigen(R).valuescall could theoretically return complex eigenvalues due to floating point errors, even though R is a symmetric correlation matrix. JET.jl detected this could lead toisless(::Int, ::ComplexF64)errors when comparing eigenvalue differences. Fixed by usingeigvals(Symmetric(R))which guarantees real eigenvalues.Add JET.jl test suite: Added
test/jet.jlto test core surrogate constructors for static analysis issues. This catches type instabilities and potential runtime errors at test time.Changes
src/Kriging.jl:
eigvals(Symmetric(R))instead ofeigen(R).valuesto ensure real eigenvalueszero(λdiff)instead of hardcoded0.0for better type stability/generic precision supporttest/jet.jl: New test file with JET analysis for:
Project.toml: Added JET as a test dependency
Test plan
Pkg.test()completed successfully - 317 tests)cc @ChrisRackauckas
🤖 Generated with Claude Code