feat: add remove_plottable() API - #40
Merged
Merged
Conversation
Graphs could be added to plots from Python but never removed. Add three overloads: by reference, by index, and by object name. Also fix m_color_map not being nulled on colormap removal, which blocked adding a replacement. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
remove_plottable()toSciQLopPlotInterfacewith three overloads: by reference, by index, and by object namem_color_mapnot being nulled when a colormap is destroyed, which blocked adding a replacement after removalTest plan
test_remove_plottable.pypassplot.remove_plottable(graph)removes the graph andgraph_list_changedfires🤖 Generated with Claude Code