Skip to content

Commit 95a2072

Browse files
authored
Remove Expr::new (#917)
#897 (comment) > I'm considering removing Expr::new, since we already have Expr::from. > As @Expurple mentioned here, I checked my codebase and found that using Expr::from makes the intent clearer. Moreover, accepting Into<Self> in the new method is not idiomatic in Rust.
1 parent 8346526 commit 95a2072

File tree

1 file changed

+0
-4
lines changed

1 file changed

+0
-4
lines changed

src/expr.rs

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1543,10 +1543,6 @@ where
15431543
}
15441544

15451545
impl Expr {
1546-
pub fn new(expr: impl Into<Self>) -> Self {
1547-
expr.into()
1548-
}
1549-
15501546
#[deprecated(since = "0.29.0", note = "Please use the [`Asterisk`]")]
15511547
pub fn asterisk() -> Self {
15521548
Self::col(Asterisk)

0 commit comments

Comments
 (0)