style(backend): clean up lint violations and enforce explicit typings in public route (Dev-Card#447)

Author: rajesh-puripanda

apps/backend/src/routes/public.ts

@@ -1,9 +1,7 @@
-import type { FastifyContextConfig, FastifyInstance, FastifyRequest, FastifyReply } from 'fastify';
+import * as publicService from '../services/publicService';
 import { generateQRBuffer, generateQRSvg } from '../utils/qr.js';
-import type { PlatformLink } from '@devcard/shared';
-import { getErrorMessage } from '../utils/error.util.js';
-import * as publicService from '../services/publicService'
 
+import type { FastifyContextConfig, FastifyInstance, FastifyRequest, FastifyReply } from 'fastify';
 
 // ── QR size bounds ────────────────────────────────────────────────────────────
 // Enforced before any DB query or image allocation.  Values outside this range
@@ -16,83 +14,11 @@ const MAX_QR_SIZE = 2048;
 // Public profile cache TTL matches the Cache-Control max-age (5 minutes).
 // The QR session JWT TTL is 10 minutes so an offline scan remains valid well
 // beyond the HTTP cache window.
-const PROFILE_CACHE_TTL = 300; // seconds (5 minutes)
 const CACHE_CONTROL_HEADER = 'public, max-age=300, stale-while-revalidate=60';
 
-type PublicProfileLink = {
-  id: string;
-  platform: string;
-  username: string;
-  url: string;
-  displayOrder: number;
-  followed?: boolean;
-}
-
-type UsernamePublicProfileResponse = {
-  username: string;
-  displayName: string;
-  bio: string | null;
-  pronouns: string | null;
-  role: string | null;
-  company: string | null;
-  avatarUrl: string | null;
-  accentColor: string;
-  links: PublicProfileLink[]
-}
-
-type PublicProfileCardLink = {
-  id: string;
-  platform: string;
-  username: string;
-  url: string;
-  followed?: boolean;
-}
-
-type CardPublicProfileResponse = {
-  id: string;
-  title: string;
-  owner: {
-    username: string;
-    displayName: string;
-    bio: string | null;
-    avatarUrl: string | null;
-    accentColor: string;
-  };
-  links: PublicProfileCardLink[]
-}
-
-type UsernameCardPublicProfileResponse = {
-  title: string;
-  owner: {
-    username: string;
-    displayName: string;
-    bio: string | null;
-    pronouns: string | null;
-    role: string | null;
-    company: string | null;
-    avatarUrl: string | null;
-    accentColor: string;
-  };
-  links: PublicProfileCardLink[]
-}
-
-// Represents a CardLink record with the joined PlatformLink relation
-interface CardLinkWithPlatform {
-  id: string;
-  displayOrder: number;
-  platformLink: PlatformLink;
-}
-
-// ── Internal Redis cache shape ────────────────────────────────────────────────
-// Extends the public response with the owner's DB id so that background view
-// tracking can still fire on cache-HIT requests without an extra DB read.
-type CachedProfileEntry = UsernamePublicProfileResponse & { _userId: string };
-
-
-export async function publicRoutes(app: FastifyInstance) {
+export async function publicRoutes(app: FastifyInstance): Promise<void> {
   // ─── Public Profile ───────────────────────────────────────────────────────
-  // ─── Public Profile ───
- /**
+  /**
    * GET /api/u/:username
    * Returns the public profile information for a user.
    */
@@ -105,29 +31,30 @@ export async function publicRoutes(app: FastifyInstance) {
     },
   }, async (request: FastifyRequest<{ Params: { username: string } }>, reply: FastifyReply) => {
     const { username } = request.params;
-    const cacheKey = `profile:${username}`;
 
     // Try to extract viewer from Authorization header (soft auth).
-    let viewerId: string | null = null
+    let viewerId: string | null = null;
     try {
       if (request.headers.authorization) {
-        const decoded = (await request.jwtVerify()) as { id?: string }
-        viewerId = decoded?.id ?? null
+        const decoded = (await request.jwtVerify()) as { id?: string };
+        viewerId = decoded?.id ?? null;
       } else {
-        viewerId = null
+        viewerId = null;
       }
     } catch {
       // ignored
     }
 
     try {
-      const result = await publicService.getPublicProfile(app, username, viewerId, request)
-      if (!result) return reply.status(404).send({ error: 'User not found' })
-      reply.header('X-Cache', result.cached ? 'HIT' : 'MISS').header('Cache-Control', CACHE_CONTROL_HEADER)
-      return result.data
-    } catch (err: any) {
-      app.log.error({ err }, 'Failed to fetch public profile')
-      return reply.status(500).send({ error: 'Internal server error' })
+      const result = await publicService.getPublicProfile(app, username, viewerId, request);
+      if (!result) {
+        return reply.status(404).send({ error: 'User not found' });
+      }
+      reply.header('X-Cache', result.cached ? 'HIT' : 'MISS').header('Cache-Control', CACHE_CONTROL_HEADER);
+      return result.data;
+    } catch (err: unknown) {
+      app.log.error({ err }, 'Failed to fetch public profile');
+      return reply.status(500).send({ error: 'Internal server error' });
     }
   });
 
@@ -149,18 +76,35 @@ export async function publicRoutes(app: FastifyInstance) {
     const { cardId } = request.params;
 
     try {
-      const card = await publicService.getCardById(app, cardId)
-      if (!card) return reply.status(404).send({ error: 'Card not found' })
-      const response = { id: card.id, title: card.title, owner: { username: card.user.username, displayName: card.user.displayName, bio: card.user.bio, avatarUrl: card.user.avatarUrl, accentColor: card.user.accentColor }, links: card.cardLinks.map((cl: any) => ({ id: cl.platformLink.id, platform: cl.platformLink.platform, username: cl.platformLink.username, url: cl.platformLink.url })) }
-      return response
-    } catch (err: any) {
-      app.log.error({ err }, 'Failed to fetch shared card')
-      return reply.status(500).send({ error: 'Internal server error' })
+      const card = await publicService.getCardById(app, cardId);
+      if (!card) {
+        return reply.status(404).send({ error: 'Card not found' });
+      }
+      const response = {
+        id: card.id,
+        title: card.title,
+        owner: {
+          username: card.user.username,
+          displayName: card.user.displayName,
+          bio: card.user.bio,
+          avatarUrl: card.user.avatarUrl,
+          accentColor: card.user.accentColor,
+        },
+        links: card.cardLinks.map((cl: any) => ({
+          id: cl.platformLink.id,
+          platform: cl.platformLink.platform,
+          username: cl.platformLink.username,
+          url: cl.platformLink.url,
+        })),
+      };
+      return response;
+    } catch (err: unknown) {
+      app.log.error({ err }, 'Failed to fetch shared card');
+      return reply.status(500).send({ error: 'Internal server error' });
     }
   });
 
   // ─── Public Card View ─────────────────────────────────────────────────────
-  // ─── Public Card View ───
   /**
    * GET /api/u/:username/card/:cardId
    * Returns full owner profile + specific card data.
@@ -176,23 +120,25 @@ export async function publicRoutes(app: FastifyInstance) {
   }, async (request: FastifyRequest<{ Params: { username: string; cardId: string } }>, reply: FastifyReply) => {
     const { username, cardId } = request.params;
 
-    let viewerId: string | null = null
+    let viewerId: string | null = null;
     try {
       if (request.headers.authorization) {
-        const decoded = (await request.jwtVerify()) as { id?: string }
-        viewerId = decoded?.id ?? null
+        const decoded = (await request.jwtVerify()) as { id?: string };
+        viewerId = decoded?.id ?? null;
       }
     } catch {
       // ignored
     }
 
     try {
-      const result = await publicService.getUserCard(app, username, cardId, viewerId, request)
-      if (result.notFound) return reply.status(404).send({ error: 'User or card not found' })
-      return result.data
-    } catch (err: any) {
-      app.log.error({ err }, 'Failed to fetch user card')
-      return reply.status(500).send({ error: 'Internal server error' })
+      const result = await publicService.getUserCard(app, username, cardId, viewerId, request);
+      if (result.notFound) {
+        return reply.status(404).send({ error: 'User or card not found' });
+      }
+      return result.data;
+    } catch (err: unknown) {
+      app.log.error({ err }, 'Failed to fetch user card');
+      return reply.status(500).send({ error: 'Internal server error' });
     }
   });
 
@@ -209,20 +155,21 @@ export async function publicRoutes(app: FastifyInstance) {
     } as FastifyContextConfig
   }, async (request: FastifyRequest<{ Params: { username: string } }>, reply: FastifyReply) => {
     const { username } = request.params;
-    const cacheKey = `profile:${username}`;
 
     try {
-      const result = await publicService.getPublicProfile(app, username, null, request)
-      if (!result) return reply.status(404).send({ error: 'User not found' })
-      const snapshot = result.data
-      const expiresIn = 600
-      const expiresAt = new Date(Date.now() + expiresIn * 1000).toISOString()
-      const token = app.jwt.sign({ profile: snapshot, sub: username }, { expiresIn: '10m' })
-      reply.header('Cache-Control', CACHE_CONTROL_HEADER)
-      return { token, tokenType: 'JWT', expiresIn, expiresAt }
-    } catch (err: any) {
-      app.log.error({ err }, 'Failed to create qr-session')
-      return reply.status(500).send({ error: 'Internal server error' })
+      const result = await publicService.getPublicProfile(app, username, null, request);
+      if (!result) {
+        return reply.status(404).send({ error: 'User not found' });
+      }
+      const snapshot = result.data;
+      const expiresIn = 600;
+      const expiresAt = new Date(Date.now() + expiresIn * 1000).toISOString();
+      const token = app.jwt.sign({ profile: snapshot, sub: username }, { expiresIn: '10m' });
+      reply.header('Cache-Control', CACHE_CONTROL_HEADER);
+      return { token, tokenType: 'JWT', expiresIn, expiresAt };
+    } catch (err: unknown) {
+      app.log.error({ err }, 'Failed to create qr-session');
+      return reply.status(500).send({ error: 'Internal server error' });
     }
   });
 
@@ -267,14 +214,21 @@ export async function publicRoutes(app: FastifyInstance) {
 
     try {
       if (format === 'svg') {
-        const svg = await generateQRSvg(profileUrl, { width: size })
-        return reply.header('Content-Type', 'image/svg+xml').header('Content-Disposition', `inline; filename="devcard-${username}.svg"`).send(svg)
+        const svg = await generateQRSvg(profileUrl, { width: size });
+        return reply
+          .header('Content-Type', 'image/svg+xml')
+          .header('Content-Disposition', `inline; filename="devcard-${username}.svg"`)
+          .send(svg);
       }
-      const png = await generateQRBuffer(profileUrl, { width: size })
-      return reply.header('Content-Type', 'image/png').header('Content-Disposition', `inline; filename="devcard-${username}.png"`).send(png)
+
+      const png = await generateQRBuffer(profileUrl, { width: size });
+      return reply
+        .header('Content-Type', 'image/png')
+        .header('Content-Disposition', `inline; filename="devcard-${username}.png"`)
+        .send(png);
     } catch (error) {
-      app.log.error({ error, username, size, format }, 'QR generation failed')
-      return reply.status(500).send({ error: 'QR code generation failed' })
+      app.log.error({ error, username, size, format }, 'QR generation failed');
+      return reply.status(500).send({ error: 'QR code generation failed' });
     }
   });
 }