Made all constant literal non-empty, non-numeric string equality checks use strict equality.

Implemented by search & replace.

All other equality checks are left untouched, as changing them may result in different behavior, whereas these ones should behave the same, while reducing the surface area for type related bugs.

Author: boenrobot

library/Zend/Amf/Adobe/Introspector.php

@@ -171,7 +171,7 @@ protected function _addService(Zend_Server_Reflection_Class $refclass, DOMElemen
         foreach ($refclass->getMethods() as $method) {
             if (!$method->isPublic()
                 || $method->isConstructor()
-                || ('__' == substr((string) $method->name, 0, 2))
+                || ('__' === substr((string) $method->name, 0, 2))
             ) {
                 continue;
             }
@@ -189,7 +189,7 @@ protected function _addService(Zend_Server_Reflection_Class $refclass, DOMElemen
 
                     $type = $param->getType();
                     if (PHP_VERSION_ID < 80000) {
-                        if ($type == 'mixed' && ($pclass = $param->getClass())) {
+                        if ($type === 'mixed' && ($pclass = $param->getClass())) {
                             $type = $pclass->getName();
                         }
                     }
@@ -291,7 +291,7 @@ protected function _registerType($typename)
         }
 
         // Arrays
-        if ('array' == $typename) {
+        if ('array' === $typename) {
             return 'Unknown[]';
         }
 

library/Zend/Amf/Parse/Amf0/Serializer.php

@@ -229,7 +229,7 @@ public function writeObject($object)
         // Loop each element and write the name of the property.
         foreach ($object as $key => &$value) {
             // skip variables starting with an _ private transient
-            if( $key[0] == "_") continue;
+            if( $key[0] === "_") continue;
             $this->_stream->writeUtf($key);
             $this->writeTypeMarker($value);
         }

library/Zend/Amf/Response/Http.php

@@ -57,7 +57,7 @@ public function getResponse()
     protected function isIeOverSsl()
     {
         $ssl = isset($_SERVER['HTTPS']) ? $_SERVER['HTTPS'] : false;
-        if (!$ssl || ($ssl == 'off')) {
+        if (!$ssl || ($ssl === 'off')) {
             // IIS reports "off", whereas other browsers simply don't populate
             return false;
         }

library/Zend/Amf/Server.php

@@ -356,7 +356,7 @@ protected function _dispatch($method, $params = null, $source = null)
         } elseif ($info instanceof Zend_Server_Reflection_Method) {
             // Get class
             $class = $info->getDeclaringClass()->getName();
-            if ('static' == $info->isStatic()) {
+            if ('static' === $info->isStatic()) {
                 // for some reason, invokeArgs() does not work the same as
                 // invoke(), and expects the first argument to be an object.
                 // So, using a callback if the method is static.

library/Zend/Application/Bootstrap/BootstrapAbstract.php

@@ -150,7 +150,7 @@ public function setOptions(array $options)
 
             if (in_array($method, $methods)) {
                 $this->$method($value);
-            } elseif ('resources' == $key) {
+            } elseif ('resources' === $key) {
                 foreach ($value as $resource => $resourceOptions) {
                     $this->registerPluginResource($resource, $resourceOptions);
                 }

library/Zend/Auth/Adapter/Http.php

@@ -580,7 +580,7 @@ protected function _digestAuth($header)
 
         // See ZF-1052. This code was a bit too unforgiving of invalid
         // usernames. Now, if the username is bad, we re-challenge the client.
-        if ('::invalid::' == $data['username']) {
+        if ('::invalid::' === $data['username']) {
             return $this->_challengeClient();
         }
 
@@ -606,7 +606,7 @@ protected function _digestAuth($header)
         // If MD5-sess is used, a1 value is made of the user's password
         // hash with the server and client nonce appended, separated by
         // colons.
-        if ($this->_algo == 'MD5-sess') {
+        if ($this->_algo === 'MD5-sess') {
             $ha1 = hash('md5', $ha1 . ':' . $data['nonce'] . ':' . $data['cnonce']);
         }
 

library/Zend/Barcode/Object/Code128.php

@@ -284,7 +284,7 @@ protected function _convertToBarcodeChars($string)
             $code = null;
 
             if (self::_isDigit($string, $pos, 4) && $currentCharset != 'C'
-             || self::_isDigit($string, $pos, 2) && $currentCharset == 'C') {
+             || self::_isDigit($string, $pos, 2) && $currentCharset === 'C') {
                 /**
                  * Switch to C if the next 4 chars are numeric or stay C if the next 2
                  * chars are numeric
@@ -324,7 +324,7 @@ protected function _convertToBarcodeChars($string)
                 $currentCharset = 'A';
             }
 
-            if ($currentCharset == 'C') {
+            if ($currentCharset === 'C') {
                 $code = array_search(substr($string, $pos, 2), $this->_charSets['C']);
                 $pos++; //Two chars from input
             } else {

library/Zend/Barcode/Object/Ean13.php

@@ -181,7 +181,7 @@ public function getChecksum($text)
      */
     protected function _drawText()
     {
-        if (get_class($this) == 'Zend_Barcode_Object_Ean13') {
+        if (get_class($this) === 'Zend_Barcode_Object_Ean13') {
             $this->_drawEan13Text();
         } else {
             parent::_drawText();

library/Zend/Barcode/Object/ObjectAbstract.php

@@ -643,7 +643,7 @@ protected function _addLeadingZeros($text, $withoutChecksum = false)
                     $text = str_repeat('0', $length - strlen($text)) . $text;
                 }
             } else {
-                if ($this->_barcodeLength == 'even') {
+                if ($this->_barcodeLength === 'even') {
                     $text = ((strlen((string) $text) - $omitChecksum) % 2 ? '0' . $text : $text);
                 }
             }

library/Zend/Barcode/Renderer/Image.php

@@ -176,7 +176,7 @@ public function setResource($image)
      */
     public function setImageType($value)
     {
-        if ($value == 'jpg') {
+        if ($value === 'jpg') {
             $value = 'jpeg';
         }