Amendment to coding style

[norv]

https://github.com/SimpleMachines/smCore/wiki/Coding-Standards

Proposed amendment: opening bracket on the same line for conditional blocks. i.e.
if ($condition) {
// do stuff
}
respectively,
while (true) {
// do even more interesting stuff
}

Obviously, it saves space, and it is still very readable. It is a style used for a long time by many projects, and allows one to see more on a page, while still catching it at a glance.
Not strictly related, it may even allow us to have brackets for one-line statements, while not agglomerating the view anymore (by much).

[mikemill]

Allman is vastly superior. Seriously, having the brackets line up is of help. Unless you are in a 25x80 terminal that extra line is worthless.

[norv]

LOL. I have just argued somewhere on the interwebz, that to dare touching HolyCodingStyle(tm) is a crime... no matter how small or innocent or useful the change is...

On the matter at hand: It is Allman, it is only for conditionals. :)
It's very very easy to distinguish, and many editors/IDEs and projects do it.

Open to discussion, of course if you folks are uncomfortable with it, it ain't happening. I am fine with both, really, just think we might consider to align to a common less-wasting-space style.

[joshuaadickerson]

I agree with Mike.

[Fustrate]

I concur with Mike and Joshua.

[emanuele45]

/me dislikes wastes :P

The one proposed by Norv is the style I used when I started coding in php, then when I started coding for SMF I had to adapt to the Allman style (Spuds's fault BTW :P) and my comment was:

NOOO!!!!
Please not this one... :'(
It's such a waste of space when functions or blocks are collapsed... :'(

Now I don't really care one or another.

[IchBin]

I'd be fine with the swtich, but I can code in either one it doesn't bother me like some of you pre-madona's! ;)

[mikemill]

*prima donna

[norv]

Just a quick one more. I'll use still this issue, for simplicity (or laziness). How about exceptions? There isn't really an (established) style yet since we have just started to use them. According to the same all-newlines habits, it would be:

Version 1.

try
{
   $connection->query("stuff");
}
catch (Exception $e)
{
   Debug::log ($e->getMessage());
}

vs. version 2.

try {
    $connection->query("stuff");
}
catch (Exception $e) {
   Debug::log ($e->getMessage());
}

I'm open to any option, including all-newlines for conditionals too, but exceptions ... excepted. :D. Because for them there's no choice on the {}.

[IchBin]

You totally missed the joke Mike. I was actually calling you madona's (in reference to you guys acting like girls instead).

[mikemill]

Why is there no choice for exceptions Norv? Figure that the try block could be the entire function/method's body you'd still want to line them up. Catches are generally shorter but no reason why they can't be long either.

[norv]

There's no choice on the blocks - they're blocks surrounded by {}. The coding style we have considers that one-line statements are too much for surrounding them in {}, and exceptions are somewhere in between because of that, for short ones, of course. For longer ones, you get into a similar situation as above. Slightly more obvious than similar: try blocks are immediately recognizable because they end with catch, too, not only ending }.

[norv]

And, oh well. As I said, them HolyCodingStyle wars have many of them victims out there. Figured we might make an exception amongst them victims. :)

It's fine either way with me. (on these)
In any case, I'm interested to make sure I know very well your positions on readability, common styles, and flexibility thereof.

For your information (without any implication), in case it picks your curiosity, this is a list of how they're done out there:
22 projects coding style notes

[holy war mode] Although, many are space lovers :P [/holy war mode] ;)

[Fustrate]

Just as a note, PSR-2 is a fucking joke.

[mikemill]

I think you mean PSR is a joke.

[Fustrate]

The FIG idea is good, the execution is bad, PSR-0 was good, PSR-1 is alright, PSR-2 sucks donkey balls.