Skip to content

Commit aaa1966

Browse files
ids1024Drakulix
authored andcommitted
render/multigpu: Don't use implicit modifier in dma_shadow_copy
I've been seeing `eglCreateImageKHR` errors here copying Nvidia buffers to AMD. And worse, this somehow lead to a crash in the Nvidia driver. It seems this was trying to use an implicit modifier, resulting in something that won't import on the other GPU. Presumably we should just filter out `Modifier::Invalid` here.
1 parent 2e44a12 commit aaa1966

File tree

1 file changed

+1
-0
lines changed
  • src/backend/renderer/multigpu

1 file changed

+1
-0
lines changed

src/backend/renderer/multigpu/mod.rs

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2190,6 +2190,7 @@ where
21902190
let modifiers = read_formats
21912191
.intersection(&write_formats)
21922192
.map(|f| f.modifier)
2193+
.filter(|m| *m != Modifier::Invalid)
21932194
.collect::<Vec<_>>();
21942195

21952196
if modifiers.is_empty() {

0 commit comments

Comments
 (0)