Skip to content

validate-epistemic-edge-records fails on main (fixture treated as expected-pass) #17

Description

@mdheller

Pre-existing, unrelated to the NER PR (#16): make validate fails on validate-epistemic-edge-records. The fixture examples/epistemic-edges/inferred-edge.rejected-confirmed.example.json is (correctly) rejected by the validator's teeth — but the validator's expectation mapping treats it as expected: pass, so a correct rejection is scored as a failure.

AssertionError: {
  "example": "inferred-edge.rejected-confirmed.example.json",
  "expected": "pass", "actual": "fail",
  "diagnostics": ["inferred_relation must not use confirmed promotionState", ...] }

Acceptance criteria

  • The validator classifies fixtures whose name signals rejection (e.g. *.rejected*) as expected-fail, OR the fixture is renamed to the validator's rejection convention.
  • make validate is green on main (all lanes, including the new validate-ner-contracts from Add NER mention/span contract (ER/NER integration plan) #16).

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions