Some nullsafe fixes

Author: robrbecker

example/index.dart

@@ -4,8 +4,8 @@ import 'common.dart';
 void main() {
   final tokenInput = querySelector('#token') as InputElement;
   tokenInput.value = github.auth!.token ?? '';
-  window.sessionStorage['GITHUB_TOKEN'] = tokenInput.value!;
+  window.localStorage['GITHUB_TOKEN'] = tokenInput.value!;
   tokenInput.onKeyUp.listen((_) {
-    window.sessionStorage['GITHUB_TOKEN'] = tokenInput.value!;
+    window.localStorage['GITHUB_TOKEN'] = tokenInput.value!;
   });
 }

example/languages.dart

@@ -14,18 +14,9 @@ Future<void> main() async {
 }
 
 Future<void> loadRepository() async {
-  String? user = 'dart-lang';
-  String? reponame = 'sdk';
-
   final params = queryString;
-
-  if (params.containsKey('user')) {
-    user = params['user'];
-  }
-
-  if (params.containsKey('repo')) {
-    reponame = params['repo'];
-  }
+  var user = params['user'] ?? 'dart-lang';
+  var reponame = params['repo'] ?? 'sdk';
 
   document.getElementById('name')!.setInnerHtml('$user/$reponame');
 

example/repos.dart

@@ -10,13 +10,13 @@ List<Repository>? repos;
 
 Map<String, Comparator<Repository>> sorts = {
   'stars': (Repository a, Repository b) =>
-      b.stargazersCount!.compareTo(a.stargazersCount!),
+      b.stargazersCount.compareTo(a.stargazersCount),
   'forks': (Repository a, Repository b) =>
-      b.forksCount!.compareTo(a.forksCount!),
+      b.forksCount.compareTo(a.forksCount),
   'created': (Repository a, Repository b) =>
       b.createdAt!.compareTo(a.createdAt!),
   'pushed': (Repository a, Repository b) => b.pushedAt!.compareTo(a.pushedAt!),
-  'size': (Repository a, Repository b) => b.size!.compareTo(a.size!)
+  'size': (Repository a, Repository b) => b.size.compareTo(a.size)
 };
 
 Future<void> main() async {
@@ -53,8 +53,8 @@ void updateRepos(
         <div class="repo" id="repo_${repo.name}">
           <div class="line"></div>
           <h2><a href="${repo.htmlUrl}">${repo.name}</a></h2>
-          ${repo.description != "" && repo.description != null ? "<b>Description</b>: ${repo.description}<br/>" : ""}
-          <b>Language</b>: ${repo.language ?? "Unknown"}
+          ${repo.description != "" ? "<b>Description</b>: ${repo.description}<br/>" : ""}
+          <b>Language</b>: ${repo.language}
           <br/>
           <b>Default Branch</b>: ${repo.defaultBranch}
           <br/>
@@ -79,7 +79,7 @@ void loadRepos([int Function(Repository a, Repository b)? compare]) {
       ..id = 'title');
   }
 
-  String? user = 'SpinlockLabs';
+  String? user = 'Workiva';
 
   if (queryString.containsKey('user')) {
     user = queryString['user'];
@@ -92,10 +92,13 @@ void loadRepos([int Function(Repository a, Repository b)? compare]) {
     }
   }
 
-  compare ??= (a, b) => a.name!.compareTo(b.name!);
+  compare ??= (a, b) => a.name.compareTo(b.name);
 
   github.repositories.listUserRepositories(user!).toList().then((repos) {
     _reposCache = repos;
     updateRepos(repos, compare);
   });
+
+  github.repositories.listTags(RepositorySlug('Workiva','font_face_observer')).toList();
+  github.issues.listByRepo(RepositorySlug('Workiva','over_react')).toList().then((value) => print);
 }

example/stars.dart

@@ -12,16 +12,8 @@ Future<void> main() async {
 }
 
 void loadStars() {
-  String? user = 'SpinlockLabs';
-  String? repo = 'github.dart';
-
-  if (queryString.containsKey('user')) {
-    user = queryString['user'];
-  }
-
-  if (queryString.containsKey('repo')) {
-    repo = queryString['repo'];
-  }
+  var user = queryString['user'] ?? 'SpinlockLabs';
+  var repo = queryString['repo'] ?? 'github.dart';
 
   querySelector('#title')!.appendText(' for $user/$repo');
 

example/status.dart

@@ -10,7 +10,7 @@ import 'package:github/src/common/xplat_common.dart'
 Authentication findAuthenticationFromEnvironment() {
   // search the query string parameters first
   var auth = findAuthenticationInMap(_parseQuery(window.location.href));
-  auth ??= findAuthenticationInMap(window.sessionStorage);
+  auth ??= findAuthenticationInMap(window.localStorage);
   return auth ?? Authentication.anonymous();
 }
 

example/status.html

@@ -5,7 +5,7 @@ import 'package:json_annotation/json_annotation.dart';
 part 'authorizations.g.dart';
 
 /// Model class for an authorization.
-@JsonSerializable(fieldRename: FieldRename.snake)
+@JsonSerializable()
 class Authorization {
   Authorization(
       {this.id,
@@ -34,7 +34,7 @@ class Authorization {
 }
 
 /// Model class for an application of an [Authorization].
-@JsonSerializable(fieldRename: FieldRename.snake)
+@JsonSerializable()
 class AuthorizationApplication {
   AuthorizationApplication({this.url, this.name, this.clientId});
 
@@ -47,7 +47,7 @@ class AuthorizationApplication {
   Map<String, dynamic> toJson() => _$AuthorizationApplicationToJson(this);
 }
 
-@JsonSerializable(fieldRename: FieldRename.snake)
+@JsonSerializable()
 class CreateAuthorization {
   CreateAuthorization(this.note,
       {this.scopes, this.noteUrl, this.clientId, this.clientSecret});

lib/src/browser/xplat_browser.dart

@@ -124,7 +124,7 @@ class GistHistoryEntry {
 }
 
 /// Model class for gist comments.
-@JsonSerializable(fieldRename: FieldRename.snake)
+@JsonSerializable()
 class GistComment {
   GistComment({
     this.id,
@@ -146,7 +146,7 @@ class GistComment {
 }
 
 /// Model class for a new gist comment to be created.
-@JsonSerializable(fieldRename: FieldRename.snake)
+@JsonSerializable()
 class CreateGistComment {
   CreateGistComment(this.body);
   String? body;