large refactor

- all static methods are now factory constructors
- fromJSON is now fromJson everywhere
- toJSON is now toJson everywhere
- Use JsonSerializable everywhere
- removed deprecated items
- renamed some fields with ID at the end to be Id

Author: robbecker-wf

analysis_options.yaml

@@ -582,7 +582,7 @@ linter:
     # http://dart-lang.github.io/linter/lints/prefer_final_fields.html
     # recommendation: optional
     # 0 issues
-    - prefer_final_fields
+    # - prefer_final_fields
 
     # Prefer final in for-each loop variable if reference is not reassigned.
     # http://dart-lang.github.io/linter/lints/prefer_final_in_for_each.html
@@ -595,7 +595,7 @@ linter:
     # recommendation: optional
     # reason: Generates a lot of lint since people use var a lot for local variables.
     # 0 issues
-    - prefer_final_locals
+    # - prefer_final_locals
 
     # Prefer for elements when building maps from iterables.
     # http://dart-lang.github.io/linter/lints/prefer_for_elements_to_map_fromIterable.html

example/readme.dart

@@ -10,7 +10,7 @@ DivElement readmeDiv;
 Future<void> main() async {
   await initViewSourceButton('readme.dart');
   readmeDiv = querySelector('#readme');
-  const repo = RepositorySlug('SpinlockLabs', 'github.dart');
+  var repo = RepositorySlug('SpinlockLabs', 'github.dart');
   final readme = await github.repositories.getReadme(repo);
   String markdown = readme.content;
   if (readme.encoding == 'base64') {

example/releases.dart

@@ -14,7 +14,7 @@ Future<void> main() async {
 
 void loadReleases() {
   github.repositories
-      .listReleases(const RepositorySlug('twbs', 'bootstrap'))
+      .listReleases(RepositorySlug('twbs', 'bootstrap'))
       .toList()
       .then((releases) {
     for (final release in releases) {

lib/src/common/activity_service.dart

@@ -131,7 +131,7 @@ class ActivityService extends Service {
   Stream<Notification> listNotifications(
       {bool all = false, bool participating = false}) {
     return PaginationHelper(github).objects(
-        'GET', '/notifications', Notification.fromJSON,
+        'GET', '/notifications', (i) => Notification.fromJson(i),
         params: {'all': all, 'participating': participating});
   }
 
@@ -140,8 +140,10 @@ class ActivityService extends Service {
   /// API docs: https://developer.github.com/v3/activity/notifications/#list-your-notifications-in-a-repository
   Stream<Notification> listRepositoryNotifications(RepositorySlug repository,
       {bool all = false, bool participating = false}) {
-    return PaginationHelper(github).objects('GET',
-        '/repos/${repository.fullName}/notifications', Notification.fromJSON,
+    return PaginationHelper(github).objects(
+        'GET',
+        '/repos/${repository.fullName}/notifications',
+        (i) => Notification.fromJson(i),
         params: {'all': all, 'participating': participating});
   }
 
@@ -185,7 +187,7 @@ class ActivityService extends Service {
   /// API docs: https://developer.github.com/v3/activity/notifications/#view-a-single-thread
   Future<Notification> getThread(String threadId) =>
       github.getJSON('/notification/threads/$threadId',
-          statusCode: StatusCodes.OK, convert: Notification.fromJSON);
+          statusCode: StatusCodes.OK, convert: (i) => Notification.fromJson(i));
 
   /// Mark the specified notification thread as read.
   ///
@@ -206,8 +208,8 @@ class ActivityService extends Service {
   ///
   /// API docs: https://developer.github.com/v3/activity/starring/#list-stargazers
   Stream<User> listStargazers(RepositorySlug slug) {
-    return PaginationHelper(github)
-        .objects('GET', '/repos/${slug.fullName}/stargazers', User.fromJson);
+    return PaginationHelper(github).objects(
+        'GET', '/repos/${slug.fullName}/stargazers', (i) => User.fromJson(i));
   }
 
   /// Lists all the repos starred by a user.
@@ -261,8 +263,8 @@ class ActivityService extends Service {
   ///
   /// API docs: https://developer.github.com/v3/activity/watching/#list-watchers
   Stream<User> listWatchers(RepositorySlug slug) {
-    return PaginationHelper(github)
-        .objects('GET', '/repos/${slug.fullName}/subscribers', User.fromJson);
+    return PaginationHelper(github).objects(
+        'GET', '/repos/${slug.fullName}/subscribers', (i) => User.fromJson(i));
   }
 
   /// Lists the repositories the specified user is watching.

lib/src/common/gists_service.dart

@@ -166,8 +166,8 @@ class GistsService extends Service {
   ///
   /// API docs: https://developer.github.com/v3/gists/comments/#list-comments-on-a-gist
   Stream<GistComment> listComments(String gistId) {
-    return PaginationHelper(github)
-        .objects('GET', '/gists/$gistId/comments', GistComment.fromJSON);
+    return PaginationHelper(github).objects(
+        'GET', '/gists/$gistId/comments', (i) => GistComment.fromJson(i));
   }
 
   // TODO: Implement getComment: https://developer.github.com/v3/gists/comments/#get-a-single-comment
@@ -177,7 +177,7 @@ class GistsService extends Service {
   /// API docs: https://developer.github.com/v3/gists/comments/#create-a-comment
   Future<GistComment> createComment(String gistId, CreateGistComment request) {
     return github.postJSON('/gists/$gistId/comments',
-        body: request.toJSON(), convert: GistComment.fromJSON);
+        body: jsonEncode(request), convert: (i) => GistComment.fromJson(i));
   }
 
   // TODO: Implement editComment: https://developer.github.com/v3/gists/comments/#edit-a-comment

lib/src/common/git_service.dart

@@ -15,14 +15,14 @@ class GitService extends Service {
   /// API docs: https://developer.github.com/v3/git/blobs/#get-a-blob
   Future<GitBlob> getBlob(RepositorySlug slug, String sha) =>
       github.getJSON('/repos/${slug.fullName}/git/blobs/$sha',
-          convert: GitBlob.fromJSON, statusCode: StatusCodes.OK);
+          convert: (i) => GitBlob.fromJson(i), statusCode: StatusCodes.OK);
 
   /// Creates a blob with specified [blob] content.
   ///
   /// API docs: https://developer.github.com/v3/git/blobs/#create-a-blob
   Future<GitBlob> createBlob(RepositorySlug slug, CreateGitBlob blob) {
     return github.postJSON('/repos/${slug.fullName}/git/blobs',
-        convert: GitBlob.fromJSON,
+        convert: (i) => GitBlob.fromJson(i),
         statusCode: StatusCodes.CREATED,
         body: jsonEncode(blob));
   }
@@ -32,14 +32,14 @@ class GitService extends Service {
   /// API docs: https://developer.github.com/v3/git/commits/#get-a-commit
   Future<GitCommit> getCommit(RepositorySlug slug, String sha) =>
       github.getJSON('/repos/${slug.fullName}/git/commits/$sha',
-          convert: GitCommit.fromJSON, statusCode: StatusCodes.OK);
+          convert: (i) => GitCommit.fromJson(i), statusCode: StatusCodes.OK);
 
   /// Creates a new commit in a repository.
   ///
   /// API docs: https://developer.github.com/v3/git/commits/#create-a-commit
   Future<GitCommit> createCommit(RepositorySlug slug, CreateGitCommit commit) {
     return github.postJSON('/repos/${slug.fullName}/git/commits',
-        convert: GitCommit.fromJSON,
+        convert: (i) => GitCommit.fromJson(i),
         statusCode: StatusCodes.CREATED,
         body: jsonEncode(commit));
   }
@@ -51,7 +51,7 @@ class GitService extends Service {
   /// API docs: https://developer.github.com/v3/git/refs/#get-a-reference
   Future<GitReference> getReference(RepositorySlug slug, String ref) =>
       github.getJSON('/repos/${slug.fullName}/git/refs/$ref',
-          convert: GitReference.fromJSON, statusCode: StatusCodes.OK);
+          convert: (i) => GitReference.fromJson(i), statusCode: StatusCodes.OK);
 
   /// Lists the references in a repository.
   ///
@@ -66,7 +66,8 @@ class GitService extends Service {
       path += '/$type';
     }
 
-    return PaginationHelper(github).objects('GET', path, GitReference.fromJSON);
+    return PaginationHelper(github)
+        .objects('GET', path, (i) => GitReference.fromJson(i));
   }
 
   /// Creates a new reference in a repository.
@@ -78,7 +79,7 @@ class GitService extends Service {
   Future<GitReference> createReference(
       RepositorySlug slug, String ref, String sha) {
     return github.postJSON('/repos/${slug.fullName}/git/refs',
-        convert: GitReference.fromJSON,
+        convert: (i) => GitReference.fromJson(i),
         statusCode: StatusCodes.CREATED,
         body: jsonEncode({'ref': ref, 'sha': sha}));
   }
@@ -100,7 +101,7 @@ class GitService extends Service {
         .request('PATCH', '/repos/${slug.fullName}/git/refs/$ref',
             body: body, headers: headers)
         .then((response) {
-      return GitReference.fromJSON(
+      return GitReference.fromJson(
           jsonDecode(response.body) as Map<String, dynamic>);
     });
   }
@@ -119,16 +120,16 @@ class GitService extends Service {
   /// API docs: https://developer.github.com/v3/git/tags/#get-a-tag
   Future<GitTag> getTag(RepositorySlug slug, String sha) =>
       github.getJSON('/repos/${slug.fullName}/git/tags/$sha',
-          convert: GitTag.fromJSON, statusCode: StatusCodes.OK);
+          convert: (i) => GitTag.fromJson(i), statusCode: StatusCodes.OK);
 
   /// Creates a new tag in a repository.
   ///
   /// API docs: https://developer.github.com/v3/git/tags/#create-a-tag-object
   Future<GitTag> createTag(RepositorySlug slug, CreateGitTag tag) =>
       github.postJSON('/repos/${slug.fullName}/git/tags',
-          convert: GitTag.fromJSON,
+          convert: (i) => GitTag.fromJson(i),
           statusCode: StatusCodes.CREATED,
-          body: tag.toJSON());
+          body: jsonEncode(tag));
 
   /// Fetches a tree from a repository for the given ref [sha].
   ///
@@ -154,6 +155,6 @@ class GitService extends Service {
     return github.postJSON('/repos/${slug.fullName}/git/trees',
         convert: (j) => GitTree.fromJson(j),
         statusCode: StatusCodes.CREATED,
-        body: tree.toJSON());
+        body: jsonEncode(tree));
   }
 }

lib/src/common/issues_service.dart

@@ -124,7 +124,7 @@ class IssuesService extends Service {
     return PaginationHelper(github).objects(
       'GET',
       pathSegment,
-      Issue.fromJSON,
+      (i) => Issue.fromJson(i),
       params: params,
     );
   }
@@ -136,9 +136,9 @@ class IssuesService extends Service {
       RepositorySlug slug, int issueNumber, IssueRequest issue) async {
     return github
         .request('PATCH', '/repos/${slug.fullName}/issues/$issueNumber',
-            body: issue.toJSON())
+            body: jsonEncode(issue))
         .then<Issue>((response) {
-      return Issue.fromJSON(jsonDecode(response.body) as Map<String, dynamic>);
+      return Issue.fromJson(jsonDecode(response.body) as Map<String, dynamic>);
     });
   }
 
@@ -147,7 +147,7 @@ class IssuesService extends Service {
   /// API docs: https://developer.github.com/v3/issues/#get-a-single-issue
   Future<Issue> get(RepositorySlug slug, int issueNumber) =>
       github.getJSON('/repos/${slug.fullName}/issues/$issueNumber',
-          convert: Issue.fromJSON);
+          convert: (i) => Issue.fromJson(i));
 
   /// Create an issue.
   ///
@@ -156,24 +156,24 @@ class IssuesService extends Service {
     final response = await github.request(
       'POST',
       '/repos/${slug.fullName}/issues',
-      body: issue.toJSON(),
+      body: jsonEncode(issue),
     );
 
     if (StatusCodes.isClientError(response.statusCode)) {
       //TODO: throw a more friendly error – better this than silent failure
       throw GitHubError(github, response.body);
     }
 
-    return Issue.fromJSON(jsonDecode(response.body) as Map<String, dynamic>);
+    return Issue.fromJson(jsonDecode(response.body) as Map<String, dynamic>);
   }
 
   /// Lists all available assignees (owners and collaborators) to which issues
   /// may be assigned.
   ///
   /// API docs: https://developer.github.com/v3/issues/assignees/#list-assignees
   Stream<User> listAssignees(RepositorySlug slug) {
-    return PaginationHelper(github)
-        .objects('GET', '/repos/${slug.fullName}/assignees', User.fromJson);
+    return PaginationHelper(github).objects(
+        'GET', '/repos/${slug.fullName}/assignees', (i) => User.fromJson(i));
   }
 
   /// Checks if a user is an assignee for the specified repository.
@@ -193,23 +193,25 @@ class IssuesService extends Service {
     return PaginationHelper(github).objects(
         'GET',
         '/repos/${slug.fullName}/issues/$issueNumber/comments',
-        IssueComment.fromJSON);
+        (i) => IssueComment.fromJson(i));
   }
 
   /// Lists all comments in a repository.
   ///
   /// API docs: https://developer.github.com/v3/issues/comments/#list-comments-on-an-issue
   Stream<IssueComment> listCommentsByRepo(RepositorySlug slug) {
-    return PaginationHelper(github).objects('GET',
-        '/repos/${slug.fullName}/issues/comments', IssueComment.fromJSON);
+    return PaginationHelper(github).objects(
+        'GET',
+        '/repos/${slug.fullName}/issues/comments',
+        (i) => IssueComment.fromJson(i));
   }
 
   /// Fetches the specified issue comment.
   ///
   /// API docs: https://developer.github.com/v3/issues/comments/#get-a-single-comment
   Future<IssueComment> getComment(RepositorySlug slug, int id) =>
       github.getJSON('/repos/${slug.fullName}/issues/comments/$id',
-          convert: IssueComment.fromJSON);
+          convert: (i) => IssueComment.fromJson(i));
 
   /// Creates a new comment on the specified issue
   ///
@@ -220,7 +222,7 @@ class IssuesService extends Service {
     return github.postJSON(
       '/repos/${slug.fullName}/issues/$issueNumber/comments',
       body: it,
-      convert: IssueComment.fromJSON,
+      convert: (i) => IssueComment.fromJson(i),
       statusCode: StatusCodes.CREATED,
     );
   }
@@ -242,16 +244,16 @@ class IssuesService extends Service {
   ///
   /// API docs: https://developer.github.com/v3/issues/labels/#list-all-labels-for-this-repository
   Stream<IssueLabel> listLabels(RepositorySlug slug) {
-    return PaginationHelper(github)
-        .objects('GET', '/repos/${slug.fullName}/labels', IssueLabel.fromJSON);
+    return PaginationHelper(github).objects(
+        'GET', '/repos/${slug.fullName}/labels', (i) => IssueLabel.fromJson(i));
   }
 
   /// Fetches a single label.
   ///
   /// API docs: https://developer.github.com/v3/issues/labels/#get-a-single-label
   Future<IssueLabel> getLabel(RepositorySlug slug, String name) =>
       github.getJSON('/repos/${slug.fullName}/labels/$name',
-          convert: IssueLabel.fromJSON, statusCode: StatusCodes.OK);
+          convert: (i) => IssueLabel.fromJson(i), statusCode: StatusCodes.OK);
 
   /// Creates a new label on the specified repository.
   ///
@@ -260,7 +262,7 @@ class IssuesService extends Service {
       RepositorySlug slug, String name, String color) {
     return github.postJSON('/repos/${slug.fullName}/labels',
         body: jsonEncode({'name': name, 'color': color}),
-        convert: IssueLabel.fromJSON);
+        convert: (i) => IssueLabel.fromJson(i));
   }
 
   /// Edits a label.
@@ -269,7 +271,7 @@ class IssuesService extends Service {
   Future<IssueLabel> editLabel(RepositorySlug slug, String name, String color) {
     return github.postJSON('/repos/${slug.fullName}/labels/$name',
         body: jsonEncode({'name': name, 'color': color}),
-        convert: IssueLabel.fromJSON);
+        convert: (i) => IssueLabel.fromJson(i));
   }
 
   /// Deletes a label.
@@ -289,7 +291,7 @@ class IssuesService extends Service {
     return PaginationHelper(github).objects(
         'GET',
         '/repos/${slug.fullName}/issues/$issueNumber/labels',
-        IssueLabel.fromJSON);
+        (i) => IssueLabel.fromJson(i));
   }
 
   /// Adds labels to an issue.
@@ -300,8 +302,10 @@ class IssuesService extends Service {
     return github.postJSON<List<dynamic>, List<IssueLabel>>(
       '/repos/${slug.fullName}/issues/$issueNumber/labels',
       body: jsonEncode(labels),
-      convert: (input) =>
-          input.cast<Map<String, dynamic>>().map(IssueLabel.fromJSON).toList(),
+      convert: (input) => input
+          .cast<Map<String, dynamic>>()
+          .map((i) => IssueLabel.fromJson(i))
+          .toList(),
     );
   }
 
@@ -315,7 +319,7 @@ class IssuesService extends Service {
             body: jsonEncode(labels))
         .then((response) {
       return jsonDecode(response.body)
-          .map((Map<String, dynamic> it) => IssueLabel.fromJSON(it));
+          .map((Map<String, dynamic> it) => IssueLabel.fromJson(it));
     });
   }
 
@@ -345,8 +349,8 @@ class IssuesService extends Service {
   ///
   /// API docs: https://developer.github.com/v3/issues/milestones/#list-milestones-for-a-repository
   Stream<Milestone> listMilestones(RepositorySlug slug) {
-    return PaginationHelper(github).objects(
-        'GET', '/repos/${slug.fullName}/milestones', Milestone.fromJSON);
+    return PaginationHelper(github).objects('GET',
+        '/repos/${slug.fullName}/milestones', (i) => Milestone.fromJson(i));
   }
 
   // TODO: Implement getMilestone: https://developer.github.com/v3/issues/milestones/#get-a-single-milestone
@@ -357,7 +361,7 @@ class IssuesService extends Service {
   Future<Milestone> createMilestone(
       RepositorySlug slug, CreateMilestone request) {
     return github.postJSON('/repos/${slug.fullName}/milestones',
-        body: jsonEncode(request.toJSON()), convert: Milestone.fromJSON);
+        body: jsonEncode(request), convert: (i) => Milestone.fromJson(i));
   }
 
   // TODO: Implement editMilestone: https://developer.github.com/v3/issues/milestones/#update-a-milestone