Merge pull request #231 from bsutton/master

Added the required status code StatusCodes.CREATED for the createRele…

Author: robrbecker

lib/src/common/model/repos.dart

@@ -274,7 +274,10 @@ class RepositorySlug {
   /// Repository Name
   String name;
 
-  RepositorySlug(this.owner, this.name);
+  RepositorySlug(this.owner, this.name) {
+    ArgumentError.checkNotNull(owner, 'owner');
+    ArgumentError.checkNotNull(name, 'name');
+  }
 
   /// Creates a Repository Slug from a full name.
   factory RepositorySlug.full(String f) {

lib/src/common/model/repos_releases.dart

@@ -96,7 +96,7 @@ class Release {
   String getUploadUrlFor(String name, [String label]) =>
       "${uploadUrl.substring(0, uploadUrl.indexOf('{'))}?name=$name${label != null ? ",$label" : ""}";
 
-  bool get hasErrors => errors?.isNotEmpty;
+  bool get hasErrors => errors == null ? false : errors.isNotEmpty;
 }
 
 /// Model class for a release asset.

lib/src/common/repos_service.dart

@@ -968,10 +968,23 @@ class RepositoriesService extends Service {
 
   /// Fetches a single release by the release tag name.
   ///
+  /// Throws a [ReleaseNotFound] exception if the release
+  /// doesn't exist.
+  ///
   /// API docs: https://developer.github.com/v3/repos/releases/#get-a-release-by-tag-name
-  Future<Release> getReleaseByTagName(RepositorySlug slug, String tagName) =>
-      github.getJSON('/repos/${slug.fullName}/releases/tags/$tagName',
-          convert: (i) => Release.fromJson(i));
+  Future<Release> getReleaseByTagName(
+      RepositorySlug slug, String tagName) async {
+    return github.getJSON(
+      '/repos/${slug.fullName}/releases/tags/$tagName',
+      convert: (i) => Release.fromJson(i),
+      statusCode: StatusCodes.OK,
+      fail: (http.Response response) {
+        if (response.statusCode == 404) {
+          throw ReleaseNotFound.fromTagName(github, tagName);
+        }
+      },
+    );
+  }
 
   /// Creates a Release based on the specified [createRelease].
   ///
@@ -986,10 +999,10 @@ class RepositoriesService extends Service {
     ArgumentError.checkNotNull(slug);
     ArgumentError.checkNotNull(createRelease);
     final release = await github.postJSON<Map<String, dynamic>, Release>(
-      '/repos/${slug.fullName}/releases',
-      convert: (i) => Release.fromJson(i),
-      body: GitHubJson.encode(createRelease.toJson()),
-    );
+        '/repos/${slug.fullName}/releases',
+        convert: (i) => Release.fromJson(i),
+        body: GitHubJson.encode(createRelease.toJson()),
+        statusCode: StatusCodes.CREATED);
     if (release.hasErrors) {
       final alreadyExistsErrorCode = release.errors.firstWhere(
         (error) => error['code'] == 'already_exists',

lib/src/common/util/errors.dart

@@ -41,6 +41,12 @@ class RepositoryNotFound extends NotFound {
       : super(github, 'Repository Not Found: $repo');
 }
 
+/// Release not found
+class ReleaseNotFound extends NotFound {
+  const ReleaseNotFound.fromTagName(GitHub github, String tagName)
+      : super(github, 'Release for tagName $tagName Not Found.');
+}
+
 /// GitHub User was not found
 class UserNotFound extends NotFound {
   const UserNotFound(GitHub github, String user)