strict types update

Vitexus · Vitexus · commit f35cb8522a49 · 2025-01-07T01:44:16.000+01:00
diff --git a/debian/changelog b/debian/changelog
@@ -1,11 +1,11 @@
-php-spojenet-abraflexi (3.3.1.245~noble.247~bullseye.249~bullseye) UNRELEASED; urgency=medium
+php-spojenet-abraflexi (3.3.1) experimental; urgency=medium
 
   * build fix
   * jenkins-Spoje.Net-php-spojenet-abraflexi-245
   * jenkins-Spoje.Net-php-spojenet-abraflexi-247
   * jenkins-Spoje.Net-php-spojenet-abraflexi-249
 
- -- vitex <jenkins@vyvojar.spoje.net>  Tue, 31 Dec 2024 12:43:45 +0000
+ -- vitex <info@vitexsoftware.cz>  Tue, 07 Jan 2025 01:19:35 +0100
 
 php-spojenet-abraflexi (3.3.0.235~noble.236~noble.237~jammy.239~noble.240~noble.241~noble) experimental; urgency=medium
 
diff --git a/src/AbraFlexi/Banka.php b/src/AbraFlexi/Banka.php
@@ -64,7 +64,7 @@ public function stahnoutVypisyOnline()
      *
      * @return bool
      */
-    public function automatickeParovani($advanced = false, $filter = null)
+    public function automatickeParovani($advanced = false, $filter = null): bool
     {
         $filterUrl = $filter === null ? '' : rtrim($filter, '/').'/';
         $this->performRequest($filterUrl.'automaticke-parovani'.($advanced ? '-pokrocile' : ''), 'PUT');
diff --git a/src/AbraFlexi/Changes.php b/src/AbraFlexi/Changes.php
@@ -31,7 +31,7 @@ class Changes extends RO
      *
      * @return bool
      */
-    public function enable()
+    public function enable(): true
     {
         $this->performRequest('enable.xml', 'POST', 'xml');
 
diff --git a/src/AbraFlexi/Company.php b/src/AbraFlexi/Company.php
@@ -79,7 +79,7 @@ public function processInit($init): void
      *
      * @param string $urlSuffix
      */
-    public function getEvidenceURL($urlSuffix = null)
+    public function getEvidenceURL($urlSuffix = null): string
     {
         if (null === $urlSuffix) {
             $urlSuffix = $this->evidence;
@@ -101,7 +101,7 @@ public function getEvidenceURL($urlSuffix = null)
      *
      * @return string API URL for current record or object/evidence
      */
-    public function getApiURL($format = null)
+    public function getApiURL($format = null): string
     {
         return \dirname(parent::getApiURL($format));
     }
@@ -111,7 +111,7 @@ public function getApiURL($format = null)
      *
      * @return string
      */
-    public function getResponseEvidence()
+    public function getResponseEvidence(): string
     {
         return 'company';
     }
@@ -147,7 +147,7 @@ public function rawResponseToArray(string $responseRaw, string $format)
      *
      * @return bool was backup saved to file ?
      */
-    public function saveBackupTo($filename)
+    public function saveBackupTo($filename): bool
     {
         $backupFile = fopen($filename, 'w+b');
         $headersBackup = $this->defaultHttpHeaders;
@@ -223,7 +223,7 @@ public function restoreBackupFrom(
      *
      * @return bool
      */
-    public function createNew($name)
+    public function createNew($name): bool
     {
         $this->performRequest('/admin/zalozeni-firmy?name='.urlencode($name), 'PUT');
 
diff --git a/src/AbraFlexi/Date.php b/src/AbraFlexi/Date.php
@@ -62,7 +62,7 @@ public function __construct(string $flexidate = 'NOW')
      *
      * @return string
      */
-    public function __toString()
+    public function __toString(): string
     {
         return $this->isNull ? '' : $this->format(Functions::$DateFormat);
     }
@@ -74,7 +74,7 @@ public function __toString()
      *
      * @return \AbraFlexi\Date or NULL
      */
-    public static function timestampToFlexiDate($timpestamp = null)
+    public static function timestampToFlexiDate($timpestamp = null): Date
     {
         $flexiDate = new self();
 
diff --git a/src/AbraFlexi/DateTime.php b/src/AbraFlexi/DateTime.php
@@ -61,7 +61,7 @@ public function __construct(string $flexidatetime = 'NOW')
      *
      * @return string
      */
-    public function __toString()
+    public function __toString(): string
     {
         return $this->isNull ? '' : $this->format(self::$format);
     }
diff --git a/src/AbraFlexi/Document.php b/src/AbraFlexi/Document.php
@@ -26,7 +26,7 @@ interface Document
     public function getLabels();
 
     /**
-     * Set one of availble Labels for current record.
+     * Set one of available Labels for current record.
      *
      * @param string $label
      *
diff --git a/src/AbraFlexi/Evidence.php b/src/AbraFlexi/Evidence.php
@@ -43,7 +43,7 @@ public function __construct(RO $engine, array $conditions = [])
     }
 
     /**
-     * Array of objects in eveidence.
+     * Array of objects in evidence.
      *
      * @return array<string, string>
      */
diff --git a/src/AbraFlexi/Formats.php b/src/AbraFlexi/Formats.php
@@ -26,7 +26,7 @@ class Formats
     public static string $version = '2025.1.1';
 
     /**
-     * Availble Formats.
+     * Available Formats.
      *
      * @see https://www.flexibee.eu/api/dokumentace/ref/format-types/
      *
diff --git a/src/AbraFlexi/Functions.php b/src/AbraFlexi/Functions.php
@@ -58,7 +58,7 @@ public static function urlEncode(string $urlRaw)
      *
      * @return string Class name
      */
-    public static function evidenceToClassName($evidence)
+    public static function evidenceToClassName($evidence): string
     {
         return str_replace(' ', '', ucwords(str_replace('-', ' ', $evidence)));
     }
@@ -68,7 +68,7 @@ public static function evidenceToClassName($evidence)
      *
      * @return string
      */
-    public static function code(string $code)
+    public static function code(string $code): string
     {
         return (substr($code, 0, 4) === 'ext:') ? $code : 'code:'.strtoupper(self::uncode($code));
     }
@@ -78,7 +78,7 @@ public static function code(string $code)
      *
      * @return array Options
      */
-    public static function companyUrlToOptions(string $companyUrl)
+    public static function companyUrlToOptions(string $companyUrl): array
     {
         $urlParts = parse_url($companyUrl);
         $scheme = isset($urlParts['scheme']) ? $urlParts['scheme'].'://' : '';
@@ -105,7 +105,7 @@ public static function companyUrlToOptions(string $companyUrl)
      *
      * @return string
      */
-    public static function uncode(string $code)
+    public static function uncode(string $code): string
     {
         return str_replace(['code:', 'code%3A'], '', $code);
     }
@@ -139,7 +139,7 @@ static function ($a, $column) {
      *
      * @return string
      */
-    public static function flexiUrl(array $data, $joiner = 'and', $defop = 'eq')
+    public static function flexiUrl(array $data, $joiner = 'and', $defop = 'eq'): string
     {
         $parts = [];
 
diff --git a/src/AbraFlexi/Kontakt.php b/src/AbraFlexi/Kontakt.php
@@ -38,7 +38,7 @@ class Kontakt extends RW
      *
      * @return bool
      */
-    public function authenticate($login, $password)
+    public function authenticate($login, $password): bool
     {
         $defaultHttpHeaders = $this->defaultHttpHeaders;
         $this->defaultHttpHeaders['Content-Type'] = 'application/x-www-form-urlencoded';
diff --git a/src/AbraFlexi/RO.php b/src/AbraFlexi/RO.php
@@ -802,7 +802,7 @@ public function setPrefix(string $prefix): void
      * Set communication format.
      * One of html|xml|json|csv|dbf|xls|isdoc|isdocx|edi|pdf|pdf|vcf|ical.
      *
-     * @return bool format is availble
+     * @return bool format is available
      */
     public function setFormat(string $format)
     {
diff --git a/src/AbraFlexi/RW.php b/src/AbraFlexi/RW.php
@@ -599,7 +599,7 @@ public function copy($source, $overrides = [])
     }
 
     /**
-     * Perform given action (if availble) on current evidence/record.
+     * Perform given action (if available) on current evidence/record.
      *
      * @url https://demo.flexibee.eu/devdoc/actions
      *
@@ -611,16 +611,16 @@ public function copy($source, $overrides = [])
      */
     public function performAction(string $action, $method = 'int')
     {
-        $actionsAvailble = $this->getActionsInfo();
+        $actionsAvailable = $this->getActionsInfo();
         $result = false;
 
         if (
-            \is_array($actionsAvailble) && \array_key_exists(
+            \is_array($actionsAvailable) && \array_key_exists(
                 $action,
-                $actionsAvailble,
+                $actionsAvailable,
             )
         ) {
-            switch ($actionsAvailble[$action]['actionMakesSense']) {
+            switch ($actionsAvailable[$action]['actionMakesSense']) {
                 case 'ONLY_WITH_INSTANCE_AND_NOT_IN_EDIT':
                 case 'ONLY_WITH_INSTANCE': // Add instance
                     $urlSuffix = '/'.$this->__toString().'/'.$action;
diff --git a/src/AbraFlexi/Relation.php b/src/AbraFlexi/Relation.php
@@ -55,7 +55,7 @@ public function __construct($item, string $evidence, $ref = null, $showAs = null
      *
      * @return string
      */
-    public function __toString()
+    public function __toString(): string
     {
         return \is_array($this->value) ? (\is_array(current($this->value)) ? current($this->value)['kod'] : current($this->value)) : $this->value;
     }
diff --git a/src/AbraFlexi/Report.php b/src/AbraFlexi/Report.php
@@ -34,7 +34,7 @@ class Report extends RW
      *
      * @return int počet načtených položek
      */
-    public function loadFromAbraFlexi($id = null)
+    public function loadFromAbraFlexi($id = null): int
     {
         if (\is_string($id) && strstr($id, 'code:')) { // Dirty Hack ⚠ Error 400: Entita 'Report' neobsahuje kód nebo ho nelze použít jako ID (není unikátní)
             $kod = \AbraFlexi\Functions::uncode((string) $id);
diff --git a/src/AbraFlexi/Root.php b/src/AbraFlexi/Root.php
@@ -27,7 +27,7 @@ class Root extends RW
      *
      * @return bool
      */
-    public function uploadCertificate($pem)
+    public function uploadCertificate($pem): bool
     {
         $this->postFields = $pem;
         $this->performRequest('/certificate', 'PUT');
@@ -36,7 +36,7 @@ public function uploadCertificate($pem)
     }
 
     /**
-     * Get availble companies listing.
+     * Get available companies listing.
      *
      * @param array $conditions applay to listing
      *
diff --git a/src/AbraFlexi/Status.php b/src/AbraFlexi/Status.php
@@ -57,7 +57,7 @@ public function __construct($init = null, $options = [])
      *
      * @return array
      */
-    public function unifyResponseFormat($responseRaw)
+    public function unifyResponseFormat($responseRaw): array
     {
         if (\array_key_exists('status', $responseRaw)) {
             $response = $responseRaw['status'];
diff --git a/src/AbraFlexi/Stitek.php b/src/AbraFlexi/Stitek.php
@@ -78,7 +78,7 @@ public static function getLabels($object)
      *
      * @return array
      */
-    public static function listToArray($listRaw)
+    public static function listToArray($listRaw): array
     {
         if (\is_array($listRaw)) {
             $list = array_combine(array_values($listRaw), array_values($listRaw));
@@ -96,13 +96,13 @@ public static function listToArray($listRaw)
     }
 
     /**
-     * Obtain list of availble labels for given object.
+     * Obtain list of available labels for given object.
      *
      * @param RO $object
      *
      * @return array
      */
-    public static function getAvailbleLabels($object)
+    public static function getAvailableLabels($object)
     {
         $labels = [];
         $evidenceBackup = $object->getEvidence();
@@ -177,7 +177,7 @@ public static function unsetLabel($label, $object)
      *
      * @return bool success
      */
-    public function createNew($name, $evidences, $options = [])
+    public function createNew($name, $evidences, $options = []): bool
     {
         $this->setData($options, true);
         $evidence2code = array_flip(self::$vsbToEvidencePath);
diff --git a/src/AbraFlexi/stitky.php b/src/AbraFlexi/stitky.php
@@ -31,7 +31,7 @@ public function getLabels()
     }
 
     /**
-     * Set one of availble Labels for current record.
+     * Set one of available Labels for current record.
      *
      * @param string $label
      *
diff --git a/tests/src/AbraFlexi/StitekTest.php b/tests/src/AbraFlexi/StitekTest.php
@@ -64,13 +64,13 @@ protected function tearDown(): void
     //    }
     //
     //    /**
-    //     * @covers \AbraFlexi\Stitek::getAvailbleLabels
+    //     * @covers \AbraFlexi\Stitek::getAvailableLabels
     //     *
-    //     * @todo   Implement testgetAvailbleLabels().
+    //     * @todo   Implement testgetAvailableLabels().
     //     */
-    //    public function testgetAvailbleLabels(): void
+    //    public function testgetAvailableLabels(): void
     //    {
-    //        $this->assertEquals('', $this->object->getAvailbleLabels());
+    //        $this->assertEquals('', $this->object->getAvailableLabels());
     //        // Remove the following lines when you implement this test.
     //        $this->markTestIncomplete('This test has not been implemented yet.');
     //    }

Original file line number	Diff line number	Diff line change
`@@ -64,7 +64,7 @@ public function stahnoutVypisyOnline()`
`64`	`64`	`*`
`65`	`65`	`* @return bool`
`66`	`66`	`*/`
`67`		`- public function automatickeParovani($advanced = false, $filter = null)`
	`67`	`+ public function automatickeParovani($advanced = false, $filter = null): bool`
`68`	`68`	`{`
`69`	`69`	`$filterUrl = $filter === null ? '' : rtrim($filter, '/').'/';`
`70`	`70`	`$this->performRequest($filterUrl.'automaticke-parovani'.($advanced ? '-pokrocile' : ''), 'PUT');`
Original file line number	Diff line number	Diff line change
`@@ -31,7 +31,7 @@ class Changes extends RO`
`31`	`31`	`*`
`32`	`32`	`* @return bool`
`33`	`33`	`*/`
`34`		`- public function enable()`
	`34`	`+ public function enable(): true`
`35`	`35`	`{`
`36`	`36`	`$this->performRequest('enable.xml', 'POST', 'xml');`
`37`	`37`
Original file line number	Diff line number	Diff line change
`@@ -79,7 +79,7 @@ public function processInit($init): void`
`79`	`79`	`*`
`80`	`80`	`* @param string $urlSuffix`
`81`	`81`	`*/`
`82`		`- public function getEvidenceURL($urlSuffix = null)`
	`82`	`+ public function getEvidenceURL($urlSuffix = null): string`
`83`	`83`	`{`
`84`	`84`	`if (null === $urlSuffix) {`
`85`	`85`	`$urlSuffix = $this->evidence;`
`@@ -101,7 +101,7 @@ public function getEvidenceURL($urlSuffix = null)`
`101`	`101`	`*`
`102`	`102`	`* @return string API URL for current record or object/evidence`
`103`	`103`	`*/`
`104`		`- public function getApiURL($format = null)`
	`104`	`+ public function getApiURL($format = null): string`
`105`	`105`	`{`
`106`	`106`	`return \dirname(parent::getApiURL($format));`
`107`	`107`	`}`
`@@ -111,7 +111,7 @@ public function getApiURL($format = null)`
`111`	`111`	`*`
`112`	`112`	`* @return string`
`113`	`113`	`*/`
`114`		`- public function getResponseEvidence()`
	`114`	`+ public function getResponseEvidence(): string`
`115`	`115`	`{`
`116`	`116`	`return 'company';`
`117`	`117`	`}`
`@@ -147,7 +147,7 @@ public function rawResponseToArray(string $responseRaw, string $format)`
`147`	`147`	`*`
`148`	`148`	`* @return bool was backup saved to file ?`
`149`	`149`	`*/`
`150`		`- public function saveBackupTo($filename)`
	`150`	`+ public function saveBackupTo($filename): bool`
`151`	`151`	`{`
`152`	`152`	`$backupFile = fopen($filename, 'w+b');`
`153`	`153`	`$headersBackup = $this->defaultHttpHeaders;`
`@@ -223,7 +223,7 @@ public function restoreBackupFrom(`
`223`	`223`	`*`
`224`	`224`	`* @return bool`
`225`	`225`	`*/`
`226`		`- public function createNew($name)`
	`226`	`+ public function createNew($name): bool`
`227`	`227`	`{`
`228`	`228`	`$this->performRequest('/admin/zalozeni-firmy?name='.urlencode($name), 'PUT');`
`229`	`229`
Original file line number	Diff line number	Diff line change
`@@ -62,7 +62,7 @@ public function __construct(string $flexidate = 'NOW')`
`62`	`62`	`*`
`63`	`63`	`* @return string`
`64`	`64`	`*/`
`65`		`- public function __toString()`
	`65`	`+ public function __toString(): string`
`66`	`66`	`{`
`67`	`67`	`return $this->isNull ? '' : $this->format(Functions::$DateFormat);`
`68`	`68`	`}`
`@@ -74,7 +74,7 @@ public function __toString()`
`74`	`74`	`*`
`75`	`75`	`* @return \AbraFlexi\Date or NULL`
`76`	`76`	`*/`
`77`		`- public static function timestampToFlexiDate($timpestamp = null)`
	`77`	`+ public static function timestampToFlexiDate($timpestamp = null): Date`
`78`	`78`	`{`
`79`	`79`	`$flexiDate = new self();`
`80`	`80`
Original file line number	Diff line number	Diff line change
`@@ -61,7 +61,7 @@ public function __construct(string $flexidatetime = 'NOW')`
`61`	`61`	`*`
`62`	`62`	`* @return string`
`63`	`63`	`*/`
`64`		`- public function __toString()`
	`64`	`+ public function __toString(): string`
`65`	`65`	`{`
`66`	`66`	`return $this->isNull ? '' : $this->format(self::$format);`
`67`	`67`	`}`
Original file line number	Diff line number	Diff line change
`@@ -26,7 +26,7 @@ interface Document`
`26`	`26`	`public function getLabels();`
`27`	`27`
`28`	`28`	`/**`
`29`		`- * Set one of availble Labels for current record.`
	`29`	`+ * Set one of available Labels for current record.`
`30`	`30`	`*`
`31`	`31`	`* @param string $label`
`32`	`32`	`*`
Original file line number	Diff line number	Diff line change
`@@ -43,7 +43,7 @@ public function __construct(RO $engine, array $conditions = [])`
`43`	`43`	`}`
`44`	`44`
`45`	`45`	`/**`
`46`		`- * Array of objects in eveidence.`
	`46`	`+ * Array of objects in evidence.`
`47`	`47`	`*`
`48`	`48`	`* @return array<string, string>`
`49`	`49`	`*/`
Original file line number	Diff line number	Diff line change
`@@ -26,7 +26,7 @@ class Formats`
`26`	`26`	`public static string $version = '2025.1.1';`
`27`	`27`
`28`	`28`	`/**`
`29`		`- * Availble Formats.`
	`29`	`+ * Available Formats.`
`30`	`30`	`*`
`31`	`31`	`* @see https://www.flexibee.eu/api/dokumentace/ref/format-types/`
`32`	`32`	`*`
Original file line number	Diff line number	Diff line change
`@@ -58,7 +58,7 @@ public static function urlEncode(string $urlRaw)`
`58`	`58`	`*`
`59`	`59`	`* @return string Class name`
`60`	`60`	`*/`
`61`		`- public static function evidenceToClassName($evidence)`
	`61`	`+ public static function evidenceToClassName($evidence): string`
`62`	`62`	`{`
`63`	`63`	`return str_replace(' ', '', ucwords(str_replace('-', ' ', $evidence)));`
`64`	`64`	`}`
`@@ -68,7 +68,7 @@ public static function evidenceToClassName($evidence)`
`68`	`68`	`*`
`69`	`69`	`* @return string`
`70`	`70`	`*/`
`71`		`- public static function code(string $code)`
	`71`	`+ public static function code(string $code): string`
`72`	`72`	`{`
`73`	`73`	`return (substr($code, 0, 4) === 'ext:') ? $code : 'code:'.strtoupper(self::uncode($code));`
`74`	`74`	`}`
`@@ -78,7 +78,7 @@ public static function code(string $code)`
`78`	`78`	`*`
`79`	`79`	`* @return array Options`
`80`	`80`	`*/`
`81`		`- public static function companyUrlToOptions(string $companyUrl)`
	`81`	`+ public static function companyUrlToOptions(string $companyUrl): array`
`82`	`82`	`{`
`83`	`83`	`$urlParts = parse_url($companyUrl);`
`84`	`84`	`$scheme = isset($urlParts['scheme']) ? $urlParts['scheme'].'://' : '';`
`@@ -105,7 +105,7 @@ public static function companyUrlToOptions(string $companyUrl)`
`105`	`105`	`*`
`106`	`106`	`* @return string`
`107`	`107`	`*/`
`108`		`- public static function uncode(string $code)`
	`108`	`+ public static function uncode(string $code): string`
`109`	`109`	`{`
`110`	`110`	`return str_replace(['code:', 'code%3A'], '', $code);`
`111`	`111`	`}`
`@@ -139,7 +139,7 @@ static function ($a, $column) {`
`139`	`139`	`*`
`140`	`140`	`* @return string`
`141`	`141`	`*/`
`142`		`- public static function flexiUrl(array $data, $joiner = 'and', $defop = 'eq')`
	`142`	`+ public static function flexiUrl(array $data, $joiner = 'and', $defop = 'eq'): string`
`143`	`143`	`{`
`144`	`144`	`$parts = [];`
`145`	`145`