Silent exceptions in TcpConnection

[xPaw]

Specifically here:

SteamKit/SteamKit2/SteamKit2/Networking/Steam3/TcpConnection.cs

Lines 255 to 262 in 12d90d6

	try
	{
	NetMsgReceived?.Invoke( this, new NetMsgEventArgs( packData, CurrentEndPoint! ) );
	}
	catch (Exception ex)
	{
	log.LogDebug( "TcpConnection", "Unexpected exception propogated back to NetLoop: {0}", ex);
	}

I'm trying NET6 preview 6, and for whatever reason it's throwing here:

NetFilterEncryptionWithHMAC Unable to decrypt incoming packet: NetFilterEncryption was unable to decrypt packet: HMAC from server did not match computed HMAC.
TcpConnection Unexpected exception propogated back to NetLoop: System.IO.IOException: Unable to decrypt incoming packet
 ---> System.Security.Cryptography.CryptographicException: NetFilterEncryption was unable to decrypt packet: HMAC from server did not match computed HMAC.

The problem is that this exception is being hidden by TcpConnection and only visible in DebugLog. Should it be rethrown/not caught?

[azuisleet]

Since EnvelopeEncryptedConnection is already responsible for shutting down connections based on the connection setup state, and is directly responsible for calling ProcessIncoming, it should probably also catch this IOException (or a subclass of it) and abort the connection.

SteamKit/SteamKit2/SteamKit2/Networking/Steam3/EnvelopeEncryptedConnection.cs

Lines 70 to 77 in 12d90d6

	void OnNetMsgReceived( object sender, NetMsgEventArgs e )
	{
	if (state == EncryptionState.Encrypted)
	{
	var plaintextData = encryption!.ProcessIncoming( e.Data );
	NetMsgReceived?.Invoke( this, e.WithData( plaintextData ) );
	return;
	}