Skip to content

Commit f2e4961

Browse files
author
Robert McLay
committed
Now passing all tests!!!
1 parent 62121c2 commit f2e4961

File tree

1 file changed

+10
-15
lines changed

1 file changed

+10
-15
lines changed

src/modfuncs.lua

Lines changed: 10 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -145,11 +145,18 @@ end
145145

146146
local s_cleanupDirT = { PATH = true, LD_LIBRARY_PATH = true, LIBRARY_PATH = true, MODULEPATH = true }
147147

148+
local function l_trim_string(value)
149+
if (type(value) == "string") then
150+
value = value:trim()
151+
end
152+
return value
153+
end
154+
148155
local function l_cleanupPathArgs(argT)
149-
local name = argT[1]:trim()
150-
local path = argT[2]:trim()
156+
local name = l_trim_string(argT[1])
157+
local path = l_trim_string(argT[2])
151158

152-
if (s_cleanupDirT[name]) then
159+
if (path and s_cleanupDirT[name]) then
153160
path = path:gsub(":+$",""):gsub("^:+",""):gsub(":+",":")
154161
if (path == "") then path = false end
155162
argT[2] = path
@@ -181,7 +188,6 @@ end
181188
local function l_build_argTable(cmdName, first_elem, ... )
182189
local argT
183190
if (type(first_elem) == "table") then
184-
dbg.print{"type(first_elem) == \"table\"\n"}
185191
if (first_elem.__waterMark == "MName") then
186192
argT = pack(first_elem, ...)
187193
else
@@ -199,7 +205,6 @@ local function l_build_argTable(cmdName, first_elem, ... )
199205
end
200206
end
201207
else
202-
dbg.print{"type(first_elem) ~= \"table\"\n"}
203208
argT = pack(first_elem, ...)
204209
argT.__cmdName = cmdName
205210
argT.modeA = {"normal"}
@@ -420,7 +425,6 @@ end
420425
-- @param cmdName The command which is getting its arguments validated.
421426
local function l_validateModules(cmdName, ...)
422427
local argA = pack(...)
423-
--dbg.print{"l_validateModules: cmd: ",cmdName, " argA.n: ",argA.n,"\n"}
424428
local allGood = true
425429
local fn = false
426430
for i = 1, argA.n do
@@ -518,12 +522,8 @@ function prepend_path(...)
518522

519523
local mcp_old = mcp
520524
mcp = l_chose_mcp(argT)
521-
dbg.print{"after l_chose_mcp\n"}
522-
523-
dbg.printT("argT",argT)
524525

525526
if (argT[2]) then
526-
dbg.print{"Calling mcp:prepend_path\n"}
527527
mcp:prepend_path(argT)
528528
end
529529
mcp = mcp_old
@@ -657,9 +657,6 @@ function family(name)
657657
dbg.start{"family(",name,")"}
658658
if (not l_validateStringArgs("family",name)) then return end
659659

660-
dbg.print{"Setting mcp to ", mcp:name(),"\n"}
661-
662-
663660
mcp:family(name)
664661
dbg.fini("family")
665662
end
@@ -1147,9 +1144,7 @@ end
11471144
-- in the modulefile. It is not an error to unload a module which is
11481145
-- not loaded. The reverse of an unload is a no-op.
11491146
function unload(...)
1150-
dbg.print{"Here in unload(...)\n"}
11511147
local argT = l_build_check_argT("unload", s_load_rulesT, ...)
1152-
dbg.print{"after l_build_check_argT\n"}
11531148
if (not argT) then
11541149
dbg.fini("unload")
11551150
return {}

0 commit comments

Comments
 (0)