#166 avoid small memory leak creating dfrobot abstraction

davetcc · davetcc · commit 5a5e8d431df2 · 2022-10-01T17:09:17.000+01:00
diff --git a/src/DfRobotInputAbstraction.h b/src/DfRobotInputAbstraction.h
@@ -129,12 +129,12 @@ const PROGMEM DfRobotAnalogRanges dfRobotV1AvrRanges { 0.0488F, 0.1904F, 0.3710F
 
 
 inline IoAbstractionRef inputFromDfRobotShield(uint8_t pin = A0, AnalogDevice* device = nullptr) {
-    device = new ArduinoAnalogDevice();
+    device = internalAnalogIo();
     return new DfRobotInputAbstraction(&dfRobotAvrRanges, pin, device);
 }
 
 inline IoAbstractionRef inputFromDfRobotShieldV1(uint8_t pin = A0, AnalogDevice* device = nullptr) {
-    device = new ArduinoAnalogDevice();
+    device = internalAnalogIo();
     return new DfRobotInputAbstraction(&dfRobotV1AvrRanges, pin, device);
 }
 

Original file line number	Diff line number	Diff line change
`@@ -129,12 +129,12 @@ const PROGMEM DfRobotAnalogRanges dfRobotV1AvrRanges { 0.0488F, 0.1904F, 0.3710F`
`129`	`129`
`130`	`130`
`131`	`131`	`inline IoAbstractionRef inputFromDfRobotShield(uint8_t pin = A0, AnalogDevice* device = nullptr) {`
`132`		`- device = new ArduinoAnalogDevice();`
	`132`	`+ device = internalAnalogIo();`
`133`	`133`	`return new DfRobotInputAbstraction(&dfRobotAvrRanges, pin, device);`
`134`	`134`	`}`
`135`	`135`
`136`	`136`	`inline IoAbstractionRef inputFromDfRobotShieldV1(uint8_t pin = A0, AnalogDevice* device = nullptr) {`
`137`		`- device = new ArduinoAnalogDevice();`
	`137`	`+ device = internalAnalogIo();`
`138`	`138`	`return new DfRobotInputAbstraction(&dfRobotV1AvrRanges, pin, device);`
`139`	`139`	`}`
`140`	`140`