Fix ImGui stack corruption when pushing a child window.

Guantol-Lemat · Guantol-Lemat · commit 3e8b9bc582b6 · 2026-03-05T21:56:25.000+01:00
diff --git a/repentogon/ImGuiFeatures/CustomImGui.h b/repentogon/ImGuiFeatures/CustomImGui.h
@@ -1142,8 +1142,8 @@ struct CustomImGui {
                 if (ImGui::BeginChild(element->name.c_str(), element->data.size, element->data.childFlags, element->data.windowFlags)) {
                     RunCallbacks(&(*element));
                     DrawElements(element->children, overflowElements);
-                    ImGui::EndChild();
                 }
+                ImGui::EndChild();
                 break;
             }
             case IMGUI_ELEMENT::Menu:
diff --git a/repentogon/ImGuiFeatures/LogViewer.h b/repentogon/ImGuiFeatures/LogViewer.h
@@ -281,8 +281,8 @@ struct LogViewer : ImGuiWindowObject {
                 if (autoscroll && ImGui::GetScrollY() >= ImGui::GetScrollMaxY())
                     ImGui::SetScrollHereY(1.0f);
                 ImGui::PopStyleVar();
-                ImGui::EndChild();
             }
+            ImGui::EndChild();
         }
         ImGui::End(); // close window element
     }

Original file line number	Diff line number	Diff line change
`@@ -1142,8 +1142,8 @@ struct CustomImGui {`
`1142`	`1142`	`if (ImGui::BeginChild(element->name.c_str(), element->data.size, element->data.childFlags, element->data.windowFlags)) {`
`1143`	`1143`	`RunCallbacks(&(*element));`
`1144`	`1144`	`DrawElements(element->children, overflowElements);`
`1145`		`- ImGui::EndChild();`
`1146`	`1145`	`}`
	`1146`	`+ ImGui::EndChild();`
`1147`	`1147`	`break;`
`1148`	`1148`	`}`
`1149`	`1149`	`case IMGUI_ELEMENT::Menu:`
Original file line number	Diff line number	Diff line change
`@@ -281,8 +281,8 @@ struct LogViewer : ImGuiWindowObject {`
`281`	`281`	`if (autoscroll && ImGui::GetScrollY() >= ImGui::GetScrollMaxY())`
`282`	`282`	`ImGui::SetScrollHereY(1.0f);`
`283`	`283`	`ImGui::PopStyleVar();`
`284`		`- ImGui::EndChild();`
`285`	`284`	`}`
	`285`	`+ ImGui::EndChild();`
`286`	`286`	`}`
`287`	`287`	`ImGui::End(); // close window element`
`288`	`288`	`}`