IGMP interval default values not conforming the schema

[r4nx]

Hi!

According to uCentral schema, query-interval and last-member-query-interval fields have the defaults value of 1000 milliseconds. In ols-ucentral-client, though, the default is 60. Is this intended, or should we modify these values to match the schema?

Thanks!

[Cahb]

Hello Viacheslav,

The default value in schema and default values in proto / platform definitions are not the same. You can view schema default as something that can be potentially added to a config request in case if it's explicitly omitted, e.g. it doesn't necessarily represent the platform default value;

You can ignore defaults, there's no need to change anything from your side, but thanks for raising this issue, as it covers some interesting topics we can discuss

Also, i think there's some confusion introduced into schema.... i think query-interval is seconds-based, and the last-member one is in milliseconds- units;
So i think it's actually makes sense to maybe level the schema to correspond to ucentral code values and not the other way around;

@mikehansen1970 i saw your comments regarding the explicit units postfix naming convention in the latest PR; I think them comennts address the exact problem we see here :)
Although as of now i would still abstain from touching the mcast code and leave it as is simply because it works (to not introduce schema / code change hussle), do you think it makes sense to walk through schema and either remove all these default occurances, or at least level them with real world values? Like 60 seconds for query-interval, for example

[mikehansen1970]

Hi Oleksandr, I think the idea is excellent, the values are somewhat confusing, as I have already stated. Parts of the schema still suffer from the point I made long ago, as well, where it has never divorced itself from the AP schema. These should be cleaned up as well. We can perhaps come up with a work item to clean up the schema overall. I do recall discussing this after I had proposed it sometime ago. Mike 2024-11-14, 7:58 AM, "Olexandr, Mazur" ***@***.***> wrote: Hello Viacheslav, The default value in schema and default values in proto / platform definitions are not the same. You can view schema default as something that can be potentially added to a config request in case if it's explicitly omitted, e.g. it doesn't necessarily represent the platform default value; You can ignore defaults, there's no need to change anything from your side, but thanks for raising this issue, as it covers some interesting topics we can discuss Also, i think there's some confusion introduced into schema.... i think query-interval is seconds-based, and the last-member one is in milliseconds- units; So i think it's actually makes sense to maybe level the schema to correspond to ucentral code values and not the other way around; @mikehansen1970<https://github.com/mikehansen1970> i saw your comments regarding the explicit units postfix naming convention in the latest PR; I think them comennts address the exact problem we see here :) Although as of now i would still abstain from touching the mcast code and leave it as is simply because it works (to not introduce schema / code change hussle), do you think it makes sense to walk through schema and either remove all these default occurances, or at least level them with real world values? Like 60 seconds for query-interval, for example — Reply to this email directly, view it on GitHub<#16 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/APDDQCD6RWFIZTLQUADG2732ASM73AVCNFSM6AAAAABRYVQES2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDINZWGI4TINJXGM>. You are receiving this because you were mentioned.Message ID: ***@***.***>