Skip to content

Commit 950a787

Browse files
committed
Addressed review comments
1 parent 1fe6ef3 commit 950a787

File tree

2 files changed

+11
-7
lines changed

2 files changed

+11
-7
lines changed

libraries/dagster-teradata/dagster_teradata/ttu/utils/encryption_utils.py

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -195,6 +195,16 @@ def decrypt_remote_file(
195195

196196
stdin, stdout, stderr = ssh_client.exec_command(decrypt_cmd)
197197
exit_status = stdout.channel.recv_exit_status()
198+
199+
if exit_status != 0:
200+
raise DagsterError(
201+
f"Decryption failed with exit status {exit_status}. Error: {stderr if stdout else 'N/A'}"
202+
)
203+
204+
logger.info(
205+
"Successfully decrypted remote file %s to %s", remote_enc_file, remote_dec_file
206+
)
207+
198208
return exit_status
199209

200210

libraries/dagster-teradata/dagster_teradata/ttu/utils/tpt_util.py

Lines changed: 1 addition & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -580,7 +580,7 @@ def prepare_tpt_ddl_script(
580580

581581
# Generate job name if not provided
582582
if job_name is None:
583-
job_name = f"airflow_tptddl_{uuid.uuid4().hex}"
583+
job_name = f"dagster_tptddl_{uuid.uuid4().hex}"
584584

585585
# Format error list for inclusion in the TPT script
586586
if not error_list:
@@ -798,10 +798,7 @@ def prepare_tpt_script(
798798
799799
Returns:
800800
str: Prepared TPT script
801-
802-
Note: Implementation based on Airflow's prepare_tpt_script
803801
"""
804-
# Implementation based on Airflow's prepare_tpt_script
805802
pass
806803

807804

@@ -828,10 +825,7 @@ def prepare_tpt_variables(
828825
829826
Returns:
830827
Dict[str, str]: Prepared TPT variables
831-
832-
Note: Implementation based on Airflow's prepare_tpt_variables
833828
"""
834-
# Implementation based on Airflow's prepare_tpt_variables
835829
pass
836830

837831

0 commit comments

Comments
 (0)