What
Fetching gear information from (other) players does not work. No data is ever received properly and made available for usage.
Tested with CONST_LIB_VERSION = 161
Why
The library seems broken when trying to send any addon chat messages larger than 255 characters long. The split data logic in sendData is redundant as bIsSafe is never set to true. It instead sends all messages through AceComm (if found) or fallbacks to just sending a single message, cutting the data of if it's larger than the limit.
Sending the message through AceComm does split properly, but the logic for receiving messages through AceComm is not setup at all making it still fail.
Repro
- Set
CONST_DIAGNOSTIC_ERRORS = true
- Join a random group and observe that the library will print
Invalid data from player:... messages
This can be repeated once with AceComm-3.0 loaded, and once without it loaded. The end result is the same
What
Fetching gear information from (other) players does not work. No data is ever received properly and made available for usage.
Tested with
CONST_LIB_VERSION = 161Why
The library seems broken when trying to send any addon chat messages larger than 255 characters long. The split data logic in
sendDatais redundant asbIsSafeis never set totrue. It instead sends all messages throughAceComm(if found) or fallbacks to just sending a single message, cutting the data of if it's larger than the limit.Sending the message through
AceCommdoes split properly, but the logic for receiving messages throughAceCommis not setup at all making it still fail.Repro
CONST_DIAGNOSTIC_ERRORS = trueInvalid data from player:...messagesThis can be repeated once with
AceComm-3.0loaded, and once without it loaded. The end result is the same