Skip to content

Commit edcc260

Browse files
committed
fix(ci): repair github node 24 workflows
Install pnpm before enabling setup-node's pnpm cache in the Cloudflare deploy job, and make the Node 24 check workflow self-contained by providing the public build URLs directly. These fixes address the first GitHub-hosted failures that surfaced after the Node 24 migration push without changing the application runtime.
1 parent fcda9f0 commit edcc260

2 files changed

Lines changed: 9 additions & 9 deletions

File tree

.github/workflows/deploy-cloudflare-workers.yml

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -16,17 +16,17 @@ jobs:
1616
- name: Checkout
1717
uses: actions/checkout@v6
1818

19-
- name: Use Node.js 24
20-
uses: actions/setup-node@v6
21-
with:
22-
node-version-file: .nvmrc
23-
cache: pnpm
24-
2519
- name: Setup PNPM
2620
uses: pnpm/action-setup@v4
2721
with:
2822
version: 10.12.1
2923
run_install: false
24+
25+
- name: Use Node.js 24
26+
uses: actions/setup-node@v6
27+
with:
28+
node-version-file: .nvmrc
29+
cache: pnpm
3030

3131
- name: Write Wrangler configs
3232
run: |

.github/workflows/run-ava-tests.js.yml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,9 @@ jobs:
1212
build:
1313

1414
runs-on: ubuntu-latest
15+
env:
16+
PUBLIC_URL: https://doesitarm.com
17+
PUBLIC_API_DOMAIN: https://api.doesitarm.com
1518

1619
strategy:
1720
matrix:
@@ -30,9 +33,6 @@ jobs:
3033
with:
3134
node-version: ${{ matrix.node-version }}
3235
cache: pnpm
33-
- run: |
34-
touch .env
35-
echo ${{ secrets.GH_ENV }} >> .env
3636
- run: pnpm install --frozen-lockfile
3737
- run: pnpm build
3838
- run: pnpm test

0 commit comments

Comments
 (0)