Skip to content

docs(maths): Add comprehensive doctests for perfect_number #12810

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

docs(maths): Add comprehensive doctests for perfect_number #12810

wants to merge 2 commits into from

Conversation

preethamvgowdaa
Copy link

This pull request improves the perfect_number algorithm by adding more comprehensive doctests, as required by the contribution guidelines.

The new tests cover:

  • Additional known perfect numbers (28, 496).
  • More non-perfect numbers.
  • Edge cases such as 0, 1, and negative numbers.

All local doctests (15/15) pass successfully.

@algorithms-keeper algorithms-keeper bot added tests are failing Do not merge until tests pass labels Jun 27, 2025
@MaximSmolskiy
Copy link
Member

@preethamvgowdaa I don't understand what you did here. You removed perfect implementation, added same doctests for is_perfect implementation, but is_perfect implementation doesn't exist in repository and in this PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@khemraj-git khemraj-git khemraj-git approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
tests are failing Do not merge until tests pass
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@preethamvgowdaa @MaximSmolskiy @khemraj-git