Skip to content

Commit 8ed7ee6

Browse files
fix: resolve clippy warnings in decision tree
1 parent 0c34fc1 commit 8ed7ee6

1 file changed

Lines changed: 4 additions & 3 deletions

File tree

src/machine_learning/decision_tree.rs

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@ fn calculate_entropy(labels: &[f64]) -> f64 {
3030
for &label in labels {
3131
let mut found = false;
3232
for (i, &existing_label) in unique_labels.iter().enumerate() {
33-
if (existing_label as f64 - label as f64).abs() < 1e-10 {
33+
if (existing_label - label).abs() < 1e-10 {
3434
counts[i] += 1;
3535
found = true;
3636
break;
@@ -76,7 +76,7 @@ fn find_best_split(data: &[(Vec<f64>, f64)], feature_index: usize) -> Option<(f6
7676

7777
for i in 1..num_samples {
7878
if feature_values[i].0 != feature_values[i - 1].0 {
79-
let threshold = (feature_values[i].0 + feature_values[i - 1].0) / 2.0;
79+
let threshold = f64::midpoint(feature_values[i].0, feature_values[i - 1].0);
8080

8181
let left_labels: Vec<f64> = feature_values[..i]
8282
.iter()
@@ -152,7 +152,7 @@ fn get_majority_class(labels: &[f64]) -> f64 {
152152
for &label in labels {
153153
let mut found = false;
154154
for (i, &existing_label) in unique_labels.iter().enumerate() {
155-
if (existing_label as f64 - label as f64).abs() < 1e-10 {
155+
if (existing_label - label).abs() < 1e-10 {
156156
counts[i] += 1;
157157
found = true;
158158
break;
@@ -324,6 +324,7 @@ impl DecisionTree {
324324
Some(predict_tree(&self.tree, test_point))
325325
}
326326

327+
#[allow(dead_code)]
327328
pub fn predict_batch(&self, test_points: &[Vec<f64>]) -> Vec<Option<f64>> {
328329
test_points
329330
.iter()

0 commit comments

Comments
 (0)