Remove unnecessary salt row (#17)

* Remove salt parameter from person registration and update procedures

* Remove salt parameter from mock person registration calls

Author: Vianpyro

database.sql

@@ -16,7 +16,6 @@ CREATE OR REPLACE TABLE person (
     person_name VARCHAR(100) UNIQUE,
     email VARCHAR(100) UNIQUE,
     hashed_password VARCHAR(100),
-    salt BINARY(16),
     registration_date TIMESTAMP DEFAULT CURRENT_TIMESTAMP,
     last_login TIMESTAMP NULL,
     language_id INT NULL,

procedures/auth.sql

@@ -7,7 +7,6 @@ CREATE OR REPLACE PROCEDURE register_person(
     IN p_name VARCHAR(100),
     IN p_email VARCHAR(100),
     IN p_hashed_password VARBINARY(255),
-    IN p_salt BINARY(16),
     IN p_language_iso_code CHAR(2)
 )
 BEGIN
@@ -39,8 +38,8 @@ BEGIN
     WHERE iso_code = p_language_iso_code;
 
     -- Insert the new person into the database
-    INSERT INTO person (person_name, email, hashed_password, salt, language_id)
-    VALUES (p_name, p_email, p_hashed_password, p_salt, v_language_id);
+    INSERT INTO person (person_name, email, hashed_password, language_id)
+    VALUES (p_name, p_email, p_hashed_password, v_language_id);
 END //
 
 CREATE OR REPLACE PROCEDURE login_person(
@@ -50,21 +49,20 @@ CREATE OR REPLACE PROCEDURE login_person(
 BEGIN
     DECLARE v_person_id INT;
     DECLARE v_hashed_password VARCHAR(100);
-    DECLARE v_salt BINARY(16);
 
     -- Check if the person exists
     IF NOT person_exists(p_person_id, p_email) THEN
         SIGNAL SQLSTATE '45000' SET MESSAGE_TEXT = 'User not found';
     END IF;
 
-    -- Retrieve the person_id, hashed password, and salt
-    SELECT person_id, hashed_password, salt
-    INTO v_person_id, v_hashed_password, v_salt
+    -- Retrieve the person_id, hashed salted password
+    SELECT person_id, hashed_password
+    INTO v_person_id, v_hashed_password
     FROM person
     WHERE (person_id = p_person_id OR email = p_email);
 
     -- Return the result set
-    SELECT v_person_id AS person_id, v_hashed_password AS hashed_password, v_salt AS salt;
+    SELECT v_person_id AS person_id, v_hashed_password AS hashed_password;
 END //
 
 CREATE OR REPLACE PROCEDURE login_person_by_id(

procedures/update/person.sql

@@ -17,7 +17,6 @@ CREATE OR REPLACE PROCEDURE update_person(
     IN p_name VARCHAR(100),
     IN p_email VARCHAR(100),
     IN p_hashed_password VARBINARY(255),
-    IN p_salt BINARY(16),
     IN p_language_iso_code CHAR(2)
 )
 BEGIN
@@ -59,7 +58,6 @@ BEGIN
         person_name = COALESCE(p_name, person_name),
         email = COALESCE(p_email, email),
         hashed_password = COALESCE(p_hashed_password, hashed_password),
-        salt = COALESCE(p_salt, salt),
         language_id = COALESCE(v_language_id, language_id)
     WHERE person_id = p_person_id;
 END //

setup/z_mock/person.sql

@@ -2,7 +2,7 @@
 USE smartcooking;
 
 -- Fill the database with mock data
-CALL register_person('John Doe', '[email protected]', 'password', unhex('a1b2c3d4e5f6a7b8c9d0e1f2a3b4c5d6'), 'en');
-CALL register_person('Jane Smith', '[email protected]', 'password', unhex('f1e2d3c4b5a6978899aabbccddeeff00'), 'fr');
-CALL register_person('Alice Brown', '[email protected]', 'password', unhex('0123456789abcdef0123456789abcdef'), 'es');
-CALL register_person('Bob White', '[email protected]', 'password', unhex('fedcba9876543210fedcba9876543210'), 'en');
+CALL register_person('John Doe', '[email protected]', 'password', 'en');
+CALL register_person('Jane Smith', '[email protected]', 'password', 'fr');
+CALL register_person('Alice Brown', '[email protected]', 'password', 'es');
+CALL register_person('Bob White', '[email protected]', 'password', 'en');