Issue #13

[32teeth]

Description

Are you sure the issue title # and issue # are right?

Let's make sure that when we create issues and give them numbers, there should be a convention that does not use the title 'Issue'

AC

# Write a test
#include <stdio.h>
#include <stdlib.h>
#include <stdbool.h>

bool isValidNumber(const char *input) {
    char *endptr;
    strtol(input, &endptr, 10);
    return (*input != '\0' && *endptr == '\0');
}

Notes

• @EugeneAndruszczenko please work with @jinlucky and make sure it meets the criteria @RetroESP32 needs.
• @32teeth will create scope fopr @TheUnknownOrganization/theunknownteam

[jinlucky]

Hey @EugeneAndruszczenko

The example @32teeth gave is okay, but wondering if we can make more eficient?

#include <stdio.h>
#include <stdbool.h>
#include <stdlib.h>
#include <string.h>

bool isValidNumber(const char *input) {
    char *endptr;
    strtod(input, &endptr);
    return (*input != '\0' && *endptr == '\0');
}

In the example above, i have replaced string to long with string to double the original with strol only checks for intergers, not floating points

LIVE WITH IT

[EugeneAndruszczenko]

Hey @32teeth

I really like Jin's solution, but i am not part of the project board, so i can only add to the comments through the direct issue board.

[RetroESP32]

@32teeth marked @EugeneAndruszczenko as 'Off Topic'

I like the solution

#include <stdio.h>
#include <stdbool.h>
#include <stdlib.h>
#include <string.h>

bool isValidNumber(const char *input) {
    char *endptr;
    strtod(input, &endptr);
    return (*input != '\0' && *endptr == '\0');
}

Here are my tests proposals

void runTest(const char *input) {
    if (isValidNumber(input)) {
        printf("\"%s\" is a valid number.\n", input);
    } else {
        printf("\"%s\" is not a valid number.\n", input);
    }
}

int main() {
    // Test cases
    runTest("1");          // Valid integer
    runTest("1.1");        // Valid floating-point number
    runTest("1.0.1");      // Invalid: multiple decimal points
    runTest("#1");         // Invalid: contains non-numeric character
    runTest("blah");       // Invalid: contains non-numeric characters
    runTest("1 thing");    // Invalid: contains non-numeric characters
    runTest("");           // Invalid: empty string
    runTest("0");          // Valid integer (edge case)

    return 0;
}

[No-Cart-In-Slot]

Hi All

New here. Maybe creating a macro would help.

#define IS_NUMBER(input) ({              \
    char *endptr;                        \
    strtod(input, &endptr);             \
    (*input != '\0' && *endptr == '\0'); \
})

Polite Note: Please when adding code blocks to markdown, be sure to add the language as well for nice syntax highlighting