AllFacilitiesGroup has problems: ParkFacility missing

[ue71603]

siri_facilities.xsd has some problems

AllFacilitiesGroup is for stop: It is not mentioned in the name and ParkingFacilitiy is missing.

If really all Facilities are needed then AllFacilitiesFeatureStructure must be used, but this is not a group. In OJP we had to wrap it (or would have had to rebuild it.

[haeckerbaer]

@ue71603 Can you provide some details? I would like to create a PR for v2.3

[ue71603]

@trurlurl are you able to furnish the details to Adrian? If problematic, pls inform me, then I will do it.

[trurlurl]

@trurlurl are you able to furnish the details to Adrian? If problematic, pls inform me, then I will do it.

Having had a look at the code, I see even more problems. SIRI has StopFacilityGroup and AllFacilitiesGroup, both with the same annotation: "Facilities that apply to stops.".

AllFacilitiesGroup = StopFacilityGroup + AccommodationFacility + AssistanceFacility + HireFacility.

Is the distinction between the two groups needed? If yes, this should be reflected and described in the annotations.

As @ue71603 has mentioned, ParkingFacility is not in any of those groups. AllFacilitiesFeatureStructure contains the following additional elements as compared to AllFacilitiesGroup: ParkingFacility + ReservedSpaceFacility + RetailFacility.

I guess that those three elements could and should be added to AllFacilitiesGroup - but this would have to be confirmed by people more involved in the project.

The only place AllFacilitiesFeatureStructure is used in the OJP files is inside <xs:complexType name="GeneralAttributeStructure"> ("Facilities associated with this attribute.")

[ue71603]

@skinkie More integration . Perhaps I will try to see, how Transmodel thinks about it.

[DohmenClaus]

This is part of the overall NeTEx-SIRI-harmonization planned for 3.0