Skip to content

Commit 0075c45

Browse files
Merge pull request #29 from Trivadis/bugfix/issue-24-9501-param-wo-expr
Bugfix/issue 24 9501 param wo expr
2 parents a6d19da + 91970f5 commit 0075c45

File tree

2 files changed

+17
-0
lines changed

2 files changed

+17
-0
lines changed

src/main/java/com/trivadis/tvdcc/validators/SQLInjection.xtend

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -281,6 +281,9 @@ class SQLInjection extends PLSQLJavaValidator implements PLSQLCopValidator {
281281
}
282282
}
283283
}
284+
if (expressions.size == 0) {
285+
expressions.put(n.value.toLowerCase, n);
286+
}
284287
return expressions;
285288
}
286289

src/test/java/com/trivadis/tvdcc/validators/tests/SQLInjectionTest.xtend

Lines changed: 14 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -416,4 +416,18 @@ class SQLInjectionTest extends AbstractValidatorTest {
416416
Assert.assertEquals(7, issues.get(1).lineNumber)
417417
}
418418

419+
@Test
420+
def void issue24_using_parameter_without_expression_in_execute_immediate() {
421+
val stmt = '''
422+
CREATE PROCEDURE p (
423+
in_sql VARCHAR2
424+
) IS
425+
BEGIN
426+
EXECUTE IMMEDIATE in_sql;
427+
END;
428+
'''
429+
val issues = stmt.issues
430+
Assert.assertEquals(1, issues.size)
431+
}
432+
419433
}

0 commit comments

Comments
 (0)