Merge pull request #45 from Trivadis/bugfix/issue-44-hint-in-merge

Bugfix/issue 44 hint in merge

Author: PhilippSalvisberg

src/main/java/com/trivadis/tvdcc/validators/Hint.xtend

@@ -256,6 +256,7 @@ class Hint extends PLSQLValidator implements PLSQLCopValidator {
 	def private dispatch getTableReference(MergeStatement stmt) {
 		val result = new ArrayList<Pair<String, String>>
 		result.add(new Pair(stmt.intoClause?.table?.value, stmt.intoClause?.alias?.value))
+		result.add(new Pair(stmt.usingClause?.table?.value, stmt.usingClause?.alias?.value))
 		return result
 	}
 

src/test/java/com/trivadis/tvdcc/validators/tests/HintTest.xtend

@@ -430,5 +430,29 @@ class HintTest extends AbstractValidatorTest {
 		val issues = stmt.issues
 		Assert.assertEquals(0, issues.size)
 	}
+	
+	// -- issue 44 https://github.com/Trivadis/plsql-cop-validators/issues/44
+	
+	@Test
+	def void falsePositiveForHintsReferringTableAliasInUsingClauseOfMerge() {
+		val stmt = '''
+			merge /*+ use_hash (d s) */ into bonuses d
+			using (select employee_id, salary, department_id
+			         from employees
+			        where department_id = 80) s
+			   on (d.employee_id = s.employee_id)
+			 when matched then
+			      update
+			         set d.bonus = d.bonus + s.salary *.01
+			      delete
+			       where (s.salary > 8000)
+			 when not matched then
+			      insert (d.employee_id, d.bonus)
+			      values (s.employee_id, s.salary *.01)
+			       where (s.salary <= 8000);
+		'''
+		val issues = stmt.issues
+		Assert.assertEquals(0, issues.size)
+	}
 
 }