Remove dependency on marchingsquares, leave stub functions instead

Author: mfedderly

eslint.config.mjs

@@ -71,17 +71,5 @@ export default tsEslint.config(
       },
     },
   },
-  {
-    files: [
-      "packages/turf-isobands/lib/marchingsquares-isobands.js",
-      "packages/turf-isolines/lib/marchingsquares-isocontours.js",
-    ],
-
-    languageOptions: {
-      globals: {
-        ...globals.browser,
-      },
-    },
-  },
   prettierRecommended
 );

packages/turf-isobands/index.ts

@@ -19,9 +19,7 @@ import {
   Polygon,
   Feature,
 } from "geojson";
-
 import { gridToMatrix } from "./lib/grid-to-matrix.js";
-import { isoBands } from "marchingsquares";
 
 type GroupRingProps = { [prop: string]: string };
 type GroupedRings =
@@ -134,6 +132,14 @@ function createContourLines(
   return contours;
 }
 
+function isoBands(
+  _matrix: number[][],
+  _lower: number,
+  _bandwidth: number
+): Position[][] {
+  return [];
+}
+
 /**
  * Transform isobands of 2D grid to polygons for the map
  *

packages/turf-isobands/marchingsquares.d.ts

@@ -82,7 +82,6 @@
     "@turf/invariant": "workspace:*",
     "@turf/meta": "workspace:*",
     "@types/geojson": "^7946.0.10",
-    "marchingsquares": "^1.3.3",
     "tslib": "^2.8.1"
   }
 }

packages/turf-isobands/package.json

@@ -2,15 +2,14 @@ import { bbox } from "@turf/bbox";
 import { coordEach } from "@turf/meta";
 import { collectionOf } from "@turf/invariant";
 import { multiLineString, featureCollection, isObject } from "@turf/helpers";
-// @ts-expect-error Legacy JS library with no types defined
-import { isoContours } from "marchingsquares";
 import { gridToMatrix } from "./lib/grid-to-matrix.js";
 import {
   FeatureCollection,
   Point,
   MultiLineString,
   Feature,
   GeoJsonProperties,
+  Position,
 } from "geojson";
 
 /**
@@ -111,16 +110,17 @@ function createIsoLines(
     properties[zProperty] = threshold;
     // Pass options to marchingsquares lib to reproduce historical turf
     // behaviour.
-    const isoline = multiLineString(
-      isoContours(matrix, threshold, { linearRing: false, noFrame: true }),
-      properties
-    );
+    const isoline = multiLineString(isoContours(matrix, threshold), properties);
 
     results.push(isoline);
   }
   return results;
 }
 
+function isoContours(_matrix: number[][], _threshold: number): Position[][] {
+  return [];
+}
+
 /**
  * Translates and scales isolines
  *

packages/turf-isolines/index.ts

@@ -79,7 +79,6 @@
     "@turf/invariant": "workspace:*",
     "@turf/meta": "workspace:*",
     "@types/geojson": "^7946.0.10",
-    "marchingsquares": "^1.3.3",
     "tslib": "^2.8.1"
   }
 }