Skip to content

feat: Update service handler to use certificateAuthorityCertSecretRef #808

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 9 commits into
base: feat/support-ca-cert-secret-ref
Choose a base branch
from
Open

feat: Update service handler to use certificateAuthorityCertSecretRef #808

wants to merge 9 commits into from

Conversation

@clement0010
Copy link
Contributor

@clement0010 clement0010 commented Oct 9, 2025

⚠️ Branched off from #807

Changes

  • Update twingate_service_create handler to use certificateAuthorityCertSecretRef when creating Kubernetes Resource CRD

Copilot AI reviewed Oct 9, 2025
View reviewed changes
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

minhtule
minhtule approved these changes Oct 9, 2025
View reviewed changes
Copy link
Contributor

@minhtule minhtule left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@clement0010 clement0010 force-pushed the feat/update-service-handler-to-use-ca-cert-secret-ref branch from 1f5b629 to d008c3a Compare October 10, 2025 06:28
@clement0010 clement0010 force-pushed the feat/update-service-handler-to-use-ca-cert-secret-ref branch from d008c3a to 34fba05 Compare October 10, 2025 07:32
@clement0010 clement0010 requested a review from ekampf October 10, 2025 07:46
@clement0010 clement0010 force-pushed the feat/update-service-handler-to-use-ca-cert-secret-ref branch from 5083b50 to 9b42dcc Compare October 21, 2025 02:48
@clement0010 clement0010 force-pushed the feat/support-ca-cert-secret-ref branch from 75ba988 to e31b36e Compare October 21, 2025 02:55
clement0010 and others added 4 commits October 21, 2025 11:03
@clement0010
Merge branch 'feat/support-ca-cert-secret-ref' into feat/update-servi…
44e564d 
…ce-handler-to-use-ca-cert-secret-ref
@clement0010
chore: Update the connector version in integration test (#818)
2f0e742 
## Changes
- Refactor connector integration tests to use a connector version
constant
@clement0010
Resolve conflict
4bc5b77
@clement0010
Better code
e9c7bd6
@github-actions
Copy link

github-actions bot commented Nov 14, 2025

This pull request is stale because it has been open 15 days with no activity. Remove stale label or comment or this will be closed in 5 days.

@github-actions github-actions bot added the wontfix This will not be worked on label Nov 14, 2025
@clement0010 clement0010 added pinned and removed wontfix This will not be worked on labels Nov 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

@ekampf ekampf ekampf approved these changes

@minhtule minhtule minhtule approved these changes

Assignees

No one assigned

Labels

pinned

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@clement0010 @ekampf @minhtule