Merge pull request #292 from UKHomeOffice/PAF-397

PAF-397 Remove unused mock upload dependencies and refresh vulnerable package fixes

Author: vivekkumar-ho

Dockerfile

@@ -8,7 +8,7 @@ RUN echo "http://uk.alpinelinux.org/alpine/v3.24/main" > /etc/apk/repositories ;
     apk upgrade --no-cache
 
 # Upgrade bundled npm deps so Trivy does not report vulnerable undici from base image toolchain
-RUN npm install -g npm@12.0.0 && npm --version
+RUN npm install -g npm@12.0.1 && npm --version
 
 # Setup nodejs group & nodejs user
 RUN addgroup --system nodejs --gid 998 && \

config.js

@@ -2,15 +2,13 @@
 /* eslint no-process-env: 0 */
 
 const env = process.env.NODE_ENV || 'production';
-const useMocks = process.env.USE_MOCKS === 'true' || !env;
 
 module.exports = {
   env: env,
   PRETTY_DATE_FORMAT: 'Do MMMM YYYY',
   csp: {
     imgSrc: ['data:']
   },
-  useMocks: useMocks,
   upload: {
     maxFileSizeInBytes: 100 * 1024 * 1024, // 100MiB in bytes
     maxFileSize: '100mb',
@@ -27,10 +25,7 @@ module.exports = {
       'application/vnd.oasis.opendocument.text',
       'application/vnd.oasis.opendocument.spreadsheet'
     ],
-    // if mocks set use file service served up by app otherwise use filevault's port 3000
-    hostname: !useMocks && process.env.FILE_VAULT_URL ?
-      process.env.FILE_VAULT_URL :
-      `http://localhost:${useMocks ? (process.env.PORT || 8080) : 3000}/file`
+    hostname: process.env.FILE_VAULT_URL
   },
   keycloak: {
     token: process.env.KEYCLOAK_TOKEN_URL,

mock-apis.js

@@ -19,16 +19,14 @@
     "test:ui-integration": "NODE_ENV=test _mocha \"test/_ui-integration/**/*.spec.js\" --exit",
     "test:unit": "NODE_ENV=test nyc _mocha \"test/_unit/**/*.spec.js\"",
     "build": "hof-build",
-    "test:snyk": "snyk config set api=SNYK_TOKEN && snyk test",
     "postinstall": "yarn run build"
   },
   "dependencies": {
     "accessible-autocomplete": "^3.0.1",
     "bl": "^6.1.6",
     "busboy": "^1.6.0",
-    "busboy-body-parser": "^0.3.2",
     "form-data": "^4.0.6",
-    "hof": "~24.4.0",
+    "hof": "~24.5.0",
     "lodash": "^4.18.1",
     "moment": "^2.30.1",
     "sqs-producer": "^9.0.5",
@@ -38,24 +36,21 @@
     "chai": "^6.2.2",
     "chai-as-promised": "^8.0.2",
     "chai-subset": "^1.6.0",
-    "chromedriver": "^119.0.1",
     "eslint": "^8.57.0",
     "eslint-config-hof": "^1.3.4",
-    "jsdom": "^29.1.1",
+    "jsdom": "^30.0.0",
     "mocha": "^11.7.6",
-    "mock-fs": "^5.5.0",
     "nyc": "^18.0.0",
     "proxyquire": "^2.1.3",
-    "sinon": "^22.0.0",
+    "sinon": "^22.1.0",
     "sinon-chai": "^4.0.1",
-    "snyk": "^1.1306.0",
     "supertest": "^7.2.2",
     "supertest-session": "^5.0.1"
   },
   "resolutions": {  
     "serialize-javascript": "^7.0.7",
-    "dicer": "^0.3.1"
-
+    "dicer": "^0.3.1",
+    "brace-expansion": "5.0.8"
   },
   "mocha": {
     "reporter": "spec",

mocks/image-upload.js

@@ -6,7 +6,6 @@ let settings = require('./hof.settings');
 const config = require('./config.js');
 const busboy = require('busboy');
 const bl = require('bl');
-const mockAPIs = require('./mock-apis');
 const _ = require('lodash');
 
 settings = Object.assign({}, settings, {
@@ -16,9 +15,6 @@ settings = Object.assign({}, settings, {
 
 const app = hof(settings);
 
-if (config.useMocks) {
-  app.use(mockAPIs);
-}
 
 app.use((req, res, next) => {
   // Set HTML Language