warning fixes, namespace and polyfill cleanup

Author: eduard-dumitru

src/CoreIpc.sln

@@ -7,6 +7,7 @@ Project("{9A19103F-16F7-4668-BE54-9A1E7A4F7556}") = "UiPath.CoreIpc", "UiPath.Co
 EndProject
 Project("{2150E333-8FDC-42A3-9474-1A3956D46DE8}") = "Solution Items", "Solution Items", "{676A208A-2F08-4749-A833-F8D2BCB1B147}"
 	ProjectSection(SolutionItems) = preProject
+		Directory.Build.props = Directory.Build.props
 		Directory.Build.targets = Directory.Build.targets
 		IpcSample.ConsoleServer\IpcSample.ConsoleServer.csproj = IpcSample.ConsoleServer\IpcSample.ConsoleServer.csproj
 		..\NuGet.Config = ..\NuGet.Config

src/Directory.Build.props

@@ -0,0 +1,5 @@
+<Project>
+    <PropertyGroup>
+        <SuppressTfmSupportBuildWarnings>true</SuppressTfmSupportBuildWarnings>
+    </PropertyGroup>
+</Project>

src/IpcSample.ConsoleClient/Client.cs

@@ -1,14 +1,13 @@
 using Microsoft.Extensions.DependencyInjection;
 using System.Diagnostics;
 using System.Text;
-using UiPath.Ipc;
 using UiPath.Ipc.Transport.NamedPipe;
 
-namespace UiPath.CoreIpc.Tests;
+namespace UiPath.Ipc.Tests;
 
-class Client
+internal static class Client
 {
-    static async Task Main(string[] args)
+    public static async Task Main(string[] args)
     {
         Console.WriteLine(typeof(int).Assembly);
         Trace.Listeners.Add(new TextWriterTraceListener(Console.Out));

src/IpcSample.ConsoleClient/IpcSample.ConsoleClient.csproj

@@ -19,9 +19,5 @@
     <PackageReference Include="Microsoft.Extensions.Configuration.Json" Version="8.0.0" />
     <PackageReference Include="Microsoft.Extensions.DependencyInjection" Version="8.0.0" />
     <PackageReference Include="Microsoft.Extensions.Logging.Console" Version="8.0.0" />
-    <PackageReference Include="Polyfill" Version="5.5.3">
-      <PrivateAssets>all</PrivateAssets>
-      <IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
-    </PackageReference>
   </ItemGroup>
 </Project>

src/IpcSample.ConsoleClient/TcpClient.cs

@@ -2,15 +2,15 @@
 using System.Diagnostics;
 using Microsoft.Extensions.DependencyInjection;
 using System.Net;
-using UiPath.Ipc;
 using UiPath.Ipc.Transport.Tcp;
 
-namespace UiPath.CoreIpc.Tests;
+namespace UiPath.Ipc.Tests;
 
-class TcpClient
+internal static class TcpClient
 {
-    static readonly IPEndPoint SystemEndPoint = new(IPAddress.Loopback, 3131);
-    static async Task _Main(string[] args)
+    private static readonly IPEndPoint SystemEndPoint = new(IPAddress.Loopback, 3131);
+
+    public static async Task _Main(string[] args)
     {
         Console.WriteLine(typeof(int).Assembly);
         Trace.Listeners.Add(new TextWriterTraceListener(Console.Out));
@@ -118,8 +118,8 @@ private static async Task RunTestsAsync(CancellationToken cancellationToken)
             callbackProxy.Dispose();
             callbackProxy.Dispose();
             //((IpcProxy)callbackProxy).CloseConnection();
-            ((IpcProxy)computingClient).CloseConnection();
-            ((IpcProxy)systemClient).CloseConnection();
+            await ((IpcProxy)computingClient).CloseConnection();
+            await ((IpcProxy)systemClient).CloseConnection();
         }
         finally
         {

src/IpcSample.ConsoleClient/WebSocketClient.cs

@@ -1,14 +1,13 @@
 using Microsoft.Extensions.DependencyInjection;
 using System.Diagnostics;
 using System.Text;
-using UiPath.Ipc;
 using UiPath.Ipc.Transport.WebSocket;
 
-namespace UiPath.CoreIpc.Tests;
+namespace UiPath.Ipc.Tests;
 
-class WebSocketClient
+internal static class WebSocketClient
 {
-    static async Task _Main(string[] args)
+    public static async Task _Main(string[] args)
     {
         Console.WriteLine(typeof(int).Assembly);
         Trace.Listeners.Add(new TextWriterTraceListener(Console.Out));

src/IpcSample.ConsoleServer/IpcSample.ConsoleServer.csproj

@@ -6,6 +6,7 @@
     <ApplicationManifest>app1.manifest</ApplicationManifest>
     <LangVersion>latest</LangVersion>
     <ImplicitUsings>true</ImplicitUsings>
+    <Nullable>enable</Nullable>
   </PropertyGroup>
 
   <ItemGroup>

src/IpcSample.ConsoleServer/Server.cs

@@ -1,20 +1,12 @@
 using Microsoft.Extensions.DependencyInjection;
 using System.Diagnostics;
-using UiPath.Ipc;
 using UiPath.Ipc.Transport.NamedPipe;
 
-namespace UiPath.CoreIpc.Tests;
+namespace UiPath.Ipc.Tests;
 
-class Server
+internal static class Server
 {
-    //private static readonly Timer _timer = new Timer(_ =>
-    //{
-    //    Console.WriteLine("GC.Collect");
-    //    GC.Collect();
-    //    GC.WaitForPendingFinalizers();
-    //    GC.Collect();
-    //}, null, 0, 3000);
-    static async Task Main()
+    public static async Task Main()
     {
         Trace.Listeners.Add(new TextWriterTraceListener(Console.Out));
         //GuiLikeSyncContext.Install();

src/IpcSample.ConsoleServer/TcpServer.cs

@@ -1,25 +1,17 @@
 using Microsoft.Extensions.DependencyInjection;
 using System.Diagnostics;
-using UiPath.Ipc;
 using UiPath.Ipc.Transport.Tcp;
 
-namespace UiPath.CoreIpc.Tests;
+namespace UiPath.Ipc.Tests;
 
 using IPEndPoint = System.Net.IPEndPoint;
 using IPAddress = System.Net.IPAddress;
 
-class TcpServer
+internal static class TcpServer
 {
-    static readonly IPEndPoint SystemEndPoint = new(IPAddress.Any, 3131);
-    //private static readonly Timer _timer = new Timer(_ =>
-    //{
-    //    Console.WriteLine("GC.Collect");
-    //    GC.Collect();
-    //    GC.WaitForPendingFinalizers();
-    //    GC.Collect();
-    //}, null, 0, 3000);
+    private static readonly IPEndPoint SystemEndPoint = new(IPAddress.Any, 3131);
 
-    static async Task _Main()
+    public static async Task _Main()
     {
         Trace.Listeners.Add(new TextWriterTraceListener(Console.Out));
         //GuiLikeSyncContext.Install();

src/IpcSample.ConsoleServer/WebSocketServer.cs

@@ -1,19 +1,10 @@
 using Microsoft.Extensions.DependencyInjection;
 using System.Diagnostics;
-using UiPath.Ipc;
 using UiPath.Ipc.Transport.WebSocket;
-namespace UiPath.CoreIpc.Tests;
+namespace UiPath.Ipc.Tests;
 class WebSocketServer
 {
-    //private static readonly Timer _timer = new Timer(_ =>
-    //{
-    //    Console.WriteLine("GC.Collect");
-    //    GC.Collect();
-    //    GC.WaitForPendingFinalizers();
-    //    GC.Collect();
-    //}, null, 0, 3000);
-
-    static async Task _Main()
+    public static async Task _Main()
     {
         Trace.Listeners.Add(new TextWriterTraceListener(Console.Out));
         //GuiLikeSyncContext.Install();