Skip to content

Commit b683302

Browse files
author
Valentina Bojan
committed
fix: pass None to rule evaluation when guardrail references missing field
1 parent 120384a commit b683302

File tree

4 files changed

+112
-2
lines changed

4 files changed

+112
-2
lines changed

packages/uipath-core/pyproject.toml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
[project]
22
name = "uipath-core"
3-
version = "0.5.5"
3+
version = "0.5.6"
44
description = "UiPath Core abstractions"
55
readme = { file = "README.md", content-type = "text/markdown" }
66
requires-python = ">=3.11"

packages/uipath-core/src/uipath/core/guardrails/_evaluators.py

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -195,6 +195,9 @@ def evaluate_word_rule(
195195
) -> tuple[bool, str]:
196196
"""Evaluate a word rule against input and output data."""
197197
fields = get_fields_from_selector(rule.field_selector, input_data, output_data)
198+
if not fields:
199+
return True, "No fields to validate"
200+
198201
operator = _humanize_guardrail_func(rule.detects_violation) or "violation check"
199202
field_paths = ", ".join({field_ref.path for _, field_ref in fields})
200203

@@ -237,6 +240,9 @@ def evaluate_number_rule(
237240
) -> tuple[bool, str]:
238241
"""Evaluate a number rule against input and output data."""
239242
fields = get_fields_from_selector(rule.field_selector, input_data, output_data)
243+
if not fields:
244+
return True, "No fields to validate"
245+
240246
operator = _humanize_guardrail_func(rule.detects_violation) or "violation check"
241247
field_paths = ", ".join({field_ref.path for _, field_ref in fields})
242248
for field_value, field_ref in fields:
@@ -281,6 +287,9 @@ def evaluate_boolean_rule(
281287
) -> tuple[bool, str]:
282288
"""Evaluate a boolean rule against input and output data."""
283289
fields = get_fields_from_selector(rule.field_selector, input_data, output_data)
290+
if not fields:
291+
return True, "No fields to validate"
292+
284293
operator = _humanize_guardrail_func(rule.detects_violation) or "violation check"
285294
field_paths = ", ".join({field_ref.path for _, field_ref in fields})
286295
for field_value, field_ref in fields:

packages/uipath-core/tests/guardrails/test_deterministic_guardrails_service.py

Lines changed: 101 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1466,3 +1466,104 @@ def _create_guardrail_with_always_rule(
14661466
),
14671467
],
14681468
)
1469+
1470+
1471+
class TestMissingFieldPassesValidation:
1472+
"""Test that rules referencing missing fields pass validation."""
1473+
1474+
def test_word_rule_missing_field_passes(
1475+
self, service: DeterministicGuardrailsService
1476+
) -> None:
1477+
guardrail = DeterministicGuardrail(
1478+
id="test-missing-field",
1479+
name="Missing Field Guardrail",
1480+
description="Test missing field",
1481+
enabled_for_evals=True,
1482+
guardrail_type="custom",
1483+
selector=GuardrailSelector(
1484+
scopes=[GuardrailScope.TOOL], match_names=["test"]
1485+
),
1486+
rules=[
1487+
WordRule(
1488+
rule_type="word",
1489+
field_selector=SpecificFieldsSelector(
1490+
selector_type="specific",
1491+
fields=[
1492+
FieldReference(path="sentence2", source=FieldSource.INPUT)
1493+
],
1494+
),
1495+
detects_violation=lambda s: len(s or "") > 0,
1496+
rule_description="sentence2 is not empty",
1497+
),
1498+
],
1499+
)
1500+
result = service._evaluate_deterministic_guardrail(
1501+
input_data={"sentence1": "hello"},
1502+
output_data={},
1503+
guardrail=guardrail,
1504+
)
1505+
assert result.result == GuardrailValidationResultType.PASSED
1506+
1507+
def test_number_rule_missing_field_passes(
1508+
self, service: DeterministicGuardrailsService
1509+
) -> None:
1510+
guardrail = DeterministicGuardrail(
1511+
id="test-missing-field",
1512+
name="Missing Field Guardrail",
1513+
description="Test missing field",
1514+
enabled_for_evals=True,
1515+
guardrail_type="custom",
1516+
selector=GuardrailSelector(
1517+
scopes=[GuardrailScope.TOOL], match_names=["test"]
1518+
),
1519+
rules=[
1520+
NumberRule(
1521+
rule_type="number",
1522+
field_selector=SpecificFieldsSelector(
1523+
selector_type="specific",
1524+
fields=[FieldReference(path="age", source=FieldSource.INPUT)],
1525+
),
1526+
detects_violation=lambda n: n is not None and n < 0,
1527+
rule_description="age is negative",
1528+
),
1529+
],
1530+
)
1531+
result = service._evaluate_deterministic_guardrail(
1532+
input_data={"name": "test"},
1533+
output_data={},
1534+
guardrail=guardrail,
1535+
)
1536+
assert result.result == GuardrailValidationResultType.PASSED
1537+
1538+
def test_boolean_rule_missing_field_passes(
1539+
self, service: DeterministicGuardrailsService
1540+
) -> None:
1541+
guardrail = DeterministicGuardrail(
1542+
id="test-missing-field",
1543+
name="Missing Field Guardrail",
1544+
description="Test missing field",
1545+
enabled_for_evals=True,
1546+
guardrail_type="custom",
1547+
selector=GuardrailSelector(
1548+
scopes=[GuardrailScope.TOOL], match_names=["test"]
1549+
),
1550+
rules=[
1551+
BooleanRule(
1552+
rule_type="boolean",
1553+
field_selector=SpecificFieldsSelector(
1554+
selector_type="specific",
1555+
fields=[
1556+
FieldReference(path="is_active", source=FieldSource.INPUT)
1557+
],
1558+
),
1559+
detects_violation=lambda b: b is False,
1560+
rule_description="is_active is false",
1561+
),
1562+
],
1563+
)
1564+
result = service._evaluate_deterministic_guardrail(
1565+
input_data={"name": "test"},
1566+
output_data={},
1567+
guardrail=guardrail,
1568+
)
1569+
assert result.result == GuardrailValidationResultType.PASSED

packages/uipath-core/uv.lock

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)