Add unit tests for Asset Service

Author: swati354

tests/unit/services/orchestrator/assets.test.ts

@@ -0,0 +1,232 @@
+// ===== IMPORTS =====
+import { describe, it, expect, beforeEach, afterEach, vi } from 'vitest';
+import { AssetService } from '../../../../src/services/orchestrator/assets';
+import { ApiClient } from '../../../../src/core/http/api-client';
+import { PaginationHelpers } from '../../../../src/utils/pagination/helpers';
+import { 
+  createMockRawAsset,
+  createMockTransformedAssetCollection
+} from '../../../utils/mocks/assets';
+import { createServiceTestDependencies, createMockApiClient } from '../../../utils/setup';
+import { createMockError } from '../../../utils/mocks/core';
+import {
+  AssetGetAllOptions,
+  AssetGetByIdOptions,
+  AssetValueType,
+  AssetValueScope,
+  AssetGetResponse
+} from '../../../../src/models/orchestrator/assets.types';
+import { PaginatedResponse } from '../../../../src/utils/pagination';
+import { ASSET_TEST_CONSTANTS } from '../../../utils/constants/assets';
+import { TEST_CONSTANTS } from '../../../utils/constants/common';
+import { ASSET_ENDPOINTS } from '../../../../src/utils/constants/endpoints';
+import { FOLDER_ID } from '../../../../src/utils/constants/headers';
+
+// ===== MOCKING =====
+// Mock the dependencies
+vi.mock('../../../../src/core/http/api-client');
+
+// Import mock objects using vi.hoisted() - this ensures they're available before vi.mock() calls
+const mocks = vi.hoisted(() => {
+  // Import/re-export the mock utilities from core
+  return import('../../../utils/mocks/core');
+});
+
+// Setup mocks at module level
+// NOTE: We do NOT mock transformData
+vi.mock('../../../../src/utils/pagination/helpers', async () => (await mocks).mockPaginationHelpers);
+
+// ===== TEST SUITE =====
+describe('AssetService Unit Tests', () => {
+  let assetService: AssetService;
+  let mockApiClient: any;
+
+  beforeEach(() => {
+    // Create mock instances using centralized setup
+    const { config, executionContext, tokenManager } = createServiceTestDependencies();
+    mockApiClient = createMockApiClient();
+
+    // Mock the ApiClient constructor
+    vi.mocked(ApiClient).mockImplementation(() => mockApiClient);
+
+    // Reset pagination helpers mock before each test
+    vi.mocked(PaginationHelpers.getAll).mockReset();
+
+    assetService = new AssetService(config, executionContext, tokenManager);
+  });
+
+  afterEach(() => {
+    vi.clearAllMocks();
+  });
+
+  describe('getById', () => {
+    it('should get asset by ID successfully with all fields mapped correctly', async () => {
+      const mockAsset = createMockRawAsset();
+      
+      mockApiClient.get.mockResolvedValue(mockAsset);
+
+      const result = await assetService.getById(
+        ASSET_TEST_CONSTANTS.ASSET_ID, 
+        TEST_CONSTANTS.FOLDER_ID
+      );
+
+      // Verify the result
+      expect(result).toBeDefined();
+      expect(result.id).toBe(ASSET_TEST_CONSTANTS.ASSET_ID);
+      expect(result.name).toBe(ASSET_TEST_CONSTANTS.ASSET_NAME);
+      expect(result.key).toBe(ASSET_TEST_CONSTANTS.ASSET_KEY);
+      expect(result.valueType).toBe(AssetValueType.DBConnectionString,);
+      expect(result.valueScope).toBe(AssetValueScope.Global,);
+
+      // Verify the API call has correct endpoint and headers
+      expect(mockApiClient.get).toHaveBeenCalledWith(
+        ASSET_ENDPOINTS.GET_BY_ID(ASSET_TEST_CONSTANTS.ASSET_ID),
+        expect.objectContaining({
+          headers: expect.objectContaining({
+            [FOLDER_ID]: TEST_CONSTANTS.FOLDER_ID.toString()
+          })
+        })
+      );
+
+      // Verify field transformations
+      // CreationTime -> createdTime
+      expect(result.createdTime).toBe(ASSET_TEST_CONSTANTS.CREATED_TIME);
+      expect((result as any).CreationTime).toBeUndefined(); // Original field should be removed
+      
+      // LastModificationTime -> lastModifiedTime
+      expect(result.lastModifiedTime).toBe(ASSET_TEST_CONSTANTS.LAST_MODIFIED_TIME);
+      expect((result as any).LastModificationTime).toBeUndefined(); // Original field should be removed
+    });
+
+    it('should get asset with options successfully', async () => {
+      const mockAsset = createMockRawAsset();
+      mockApiClient.get.mockResolvedValue(mockAsset);
+
+      const options: AssetGetByIdOptions = {
+        expand: ASSET_TEST_CONSTANTS.ODATA_EXPAND_KEY_VALUE_LIST,
+        select: ASSET_TEST_CONSTANTS.ODATA_SELECT_FIELDS
+      };
+
+      const result = await assetService.getById(
+        ASSET_TEST_CONSTANTS.ASSET_ID,
+        TEST_CONSTANTS.FOLDER_ID,
+        options
+      );
+
+      // Verify the result
+      expect(result).toBeDefined();
+      expect(result.id).toBe(ASSET_TEST_CONSTANTS.ASSET_ID);
+      expect(result.name).toBe(ASSET_TEST_CONSTANTS.ASSET_NAME);
+      expect(result.key).toBe(ASSET_TEST_CONSTANTS.ASSET_KEY);
+
+      // Verify API call has options with OData prefix
+      expect(mockApiClient.get).toHaveBeenCalledWith(
+        ASSET_ENDPOINTS.GET_BY_ID(ASSET_TEST_CONSTANTS.ASSET_ID),
+        expect.objectContaining({
+          params: expect.objectContaining({
+            '$expand': ASSET_TEST_CONSTANTS.ODATA_EXPAND_KEY_VALUE_LIST,
+            '$select': ASSET_TEST_CONSTANTS.ODATA_SELECT_FIELDS
+          })
+        })
+      );
+    });
+
+    it('should handle API errors', async () => {
+      const error = createMockError(ASSET_TEST_CONSTANTS.ERROR_ASSET_NOT_FOUND);
+      mockApiClient.get.mockRejectedValue(error);
+
+      await expect(assetService.getById(
+        ASSET_TEST_CONSTANTS.ASSET_ID, 
+        TEST_CONSTANTS.FOLDER_ID
+      )).rejects.toThrow(ASSET_TEST_CONSTANTS.ERROR_ASSET_NOT_FOUND);
+    });
+  });
+
+  describe('getAll', () => {
+    it('should return all assets without pagination options', async () => {
+      const mockResponse = createMockTransformedAssetCollection();
+      
+      vi.mocked(PaginationHelpers.getAll).mockResolvedValue(mockResponse);
+
+      const result = await assetService.getAll();
+
+      // Verify PaginationHelpers.getAll was called
+      expect(PaginationHelpers.getAll).toHaveBeenCalledWith(
+        expect.objectContaining({
+          serviceAccess: expect.any(Object),
+          getEndpoint: expect.toSatisfy((fn: Function) => fn() === ASSET_ENDPOINTS.GET_ALL),
+          transformFn: expect.any(Function),
+          pagination: expect.any(Object)
+        }),
+        undefined
+      );
+
+      expect(result).toEqual(mockResponse);
+    });
+
+    it('should return assets filtered by folder ID', async () => {
+      const mockResponse = createMockTransformedAssetCollection();
+      
+      vi.mocked(PaginationHelpers.getAll).mockResolvedValue(mockResponse);
+
+      const options: AssetGetAllOptions = {
+        folderId: TEST_CONSTANTS.FOLDER_ID
+      };
+
+      const result = await assetService.getAll(options);
+
+      // Verify PaginationHelpers.getAll was called with folder options
+      expect(PaginationHelpers.getAll).toHaveBeenCalledWith(
+        expect.objectContaining({
+          serviceAccess: expect.any(Object),
+          getEndpoint: expect.toSatisfy((fn: Function) => fn(TEST_CONSTANTS.FOLDER_ID) === ASSET_ENDPOINTS.GET_BY_FOLDER),
+          transformFn: expect.any(Function),
+          pagination: expect.any(Object)
+        }),
+        expect.objectContaining({
+          folderId: TEST_CONSTANTS.FOLDER_ID
+        })
+      );
+
+      expect(result).toEqual(mockResponse);
+    });
+
+    it('should return paginated assets when pagination options provided', async () => {
+      const mockResponse = createMockTransformedAssetCollection(100, {
+        totalCount: 100,
+        hasNextPage: true,
+        nextCursor: TEST_CONSTANTS.NEXT_CURSOR,
+        previousCursor: null,
+        currentPage: 1,
+        totalPages: 10
+      });
+      
+      vi.mocked(PaginationHelpers.getAll).mockResolvedValue(mockResponse);
+
+      const options: AssetGetAllOptions = {
+        pageSize: TEST_CONSTANTS.PAGE_SIZE
+      };
+
+      const result = await assetService.getAll(options) as PaginatedResponse<AssetGetResponse>;
+
+      // Verify PaginationHelpers.getAll was called with pagination options
+      expect(PaginationHelpers.getAll).toHaveBeenCalledWith(
+        expect.any(Object),
+        expect.objectContaining({
+          pageSize: TEST_CONSTANTS.PAGE_SIZE
+        })
+      );
+
+      expect(result).toEqual(mockResponse);
+      expect(result.hasNextPage).toBe(true);
+      expect(result.nextCursor).toBe(TEST_CONSTANTS.NEXT_CURSOR);
+    });
+
+    it('should handle API errors', async () => {
+      const error = createMockError(TEST_CONSTANTS.ERROR_MESSAGE);
+      vi.mocked(PaginationHelpers.getAll).mockRejectedValue(error);
+
+      await expect(assetService.getAll()).rejects.toThrow(TEST_CONSTANTS.ERROR_MESSAGE);
+    });
+  });
+});

tests/unit/services/orchestrator/index.js

@@ -0,0 +1 @@
+export * from './assets.test';

tests/utils/constants/assets.ts

@@ -0,0 +1,37 @@
+/**
+ * Asset service test constants
+ * Asset-specific constants only
+ */
+
+export const ASSET_TEST_CONSTANTS = {
+  // Asset IDs
+  ASSET_ID: 123,
+  
+  // Asset Metadata
+  ASSET_NAME: 'DatabaseConnection',
+  ASSET_KEY: '12345678-1234-1234-1234-123456789abc',
+  ASSET_DESCRIPTION: 'Database connection string for production',
+  
+  // Asset Values
+  ASSET_VALUE: 'Server=myServerAddress;Database=myDataBase;User Id=myUsername;Password=myPassword;',
+  
+  // Timestamps
+  CREATED_TIME: '2023-10-15T10:00:00Z',
+  LAST_MODIFIED_TIME: '2023-10-20T15:30:00Z',
+  
+  // User IDs
+  LAST_MODIFIER_USER_ID: 102,
+  
+  // Key-Value List Items
+  KEY_VALUE_ITEM_1_KEY: 'environment',
+  KEY_VALUE_ITEM_1_VALUE: 'production',
+  KEY_VALUE_ITEM_2_KEY: 'region',
+  KEY_VALUE_ITEM_2_VALUE: 'us-east-1',
+  
+  // Error Messages
+  ERROR_ASSET_NOT_FOUND: 'Asset not found',
+  
+  // OData Parameters
+  ODATA_EXPAND_KEY_VALUE_LIST: 'keyValueList',
+  ODATA_SELECT_FIELDS: 'id,name,value',
+} as const;

tests/utils/constants/index.ts

@@ -6,4 +6,5 @@ export * from './common';
 export * from './maestro';
 export * from './tasks';
 export * from './entities';
+export * from './assets';