Skip to content

fix: remove commits-only guard in GoalTracker auto-sync (closes #2410)#2425

Merged
Priyanshu-byte-coder merged 1 commit into
Priyanshu-byte-coder:mainfrom
Rudrasamadhiya:fix/issue-2410-goaltracker-auto-sync
Jun 16, 2026
Merged

fix: remove commits-only guard in GoalTracker auto-sync (closes #2410)#2425
Priyanshu-byte-coder merged 1 commit into
Priyanshu-byte-coder:mainfrom
Rudrasamadhiya:fix/issue-2410-goaltracker-auto-sync

Conversation

@Rudrasamadhiya

Copy link
Copy Markdown
Contributor

Summary

The GoalTracker component's auto-sync logic silently skipped all goal types except unit === "commits". This meant streak, PR, review, and other goal types never triggered background sync, leaving them perpetually stale.

This fix removes the guard clause if (g.unit !== "commits") return false; and replaces it with a comment clarifying that auto-sync applies to all goal types.

Closes #2410

Type of Change

  • Bug fix

@github-actions github-actions Bot added gssoc26 GSSoC 2026 contribution type:bug GSSoC type bonus: bug fix labels Jun 14, 2026
@github-actions

Copy link
Copy Markdown

GSSoC Label Checklist 🏷️

@Umbrella-io — please apply the appropriate labels before merging:

Difficulty (pick one):

  • level:beginner — 20 pts
  • level:intermediate — 35 pts
  • level:advanced — 55 pts
  • level:critical — 80 pts

Quality (optional):

  • quality:clean — ×1.2 multiplier
  • quality:exceptional — ×1.5 multiplier

Validation (required to score):

  • gssoc:approved — counts for points
  • gssoc:invalid / gssoc:spam / gssoc:ai-slop — does not score

Type labels (type:*) are auto-detected from files and title. Review and adjust if needed.
Points formula: (difficulty × quality_multiplier) + type_bonus

@github-actions github-actions Bot added type:feature GSSoC type bonus: new feature type:design GSSoC type bonus: UI/design (+10 pts) type:performance GSSoC type bonus: performance (+15 pts) labels Jun 14, 2026
@Priyanshu-byte-coder Priyanshu-byte-coder added the gssoc:approved GSSoC: PR approved for scoring label Jun 16, 2026
@Priyanshu-byte-coder Priyanshu-byte-coder merged commit 2ce7ae9 into Priyanshu-byte-coder:main Jun 16, 2026
4 checks passed
@github-actions

Copy link
Copy Markdown

🎉 Merged! Thanks for contributing to DevTrack.

If the project has been useful to you, a ⭐ star on the repo is the easiest way to support it — it helps DevTrack get discovered by more developers.

Keep an eye on open issues for your next contribution!

@Priyanshu-byte-coder Priyanshu-byte-coder added level:intermediate GSSoC: Intermediate difficulty (35 pts) quality:clean GSSoC: Clean quality multiplier (×1.2) labels Jun 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

gssoc:approved GSSoC: PR approved for scoring gssoc26 GSSoC 2026 contribution level:intermediate GSSoC: Intermediate difficulty (35 pts) quality:clean GSSoC: Clean quality multiplier (×1.2) type:bug GSSoC type bonus: bug fix type:design GSSoC type bonus: UI/design (+10 pts) type:feature GSSoC type bonus: new feature type:performance GSSoC type bonus: performance (+15 pts)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] GoalTracker auto-sync only fires for goals with unit=="commits", silently skipping all other goal types

2 participants