Skip to content

Commit 8c15ae7

Browse files
authored
fix: add metric V4UndesiredHooksOnChain and CachedRoutePriceImpactTooHigh (#1278)
* fix: add metric V4UndesiredHooksOnChain * fix: log cached routes hookaddress and cached routes high price impactw
1 parent 0b06c25 commit 8c15ae7

File tree

1 file changed

+13
-2
lines changed

1 file changed

+13
-2
lines changed

lib/handlers/quote/quote.ts

Lines changed: 13 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
import Joi from '@hapi/joi'
2-
import { Protocol } from '@uniswap/router-sdk'
3-
import { ChainId, Currency, CurrencyAmount, Token, TradeType } from '@uniswap/sdk-core'
2+
import { ADDRESS_ZERO, Protocol } from '@uniswap/router-sdk'
3+
import { ChainId, Currency, CurrencyAmount, Percent, Token, TradeType } from '@uniswap/sdk-core'
44
import {
55
AlphaRouterConfig,
66
getAddress,
@@ -47,6 +47,7 @@ import {
4747
URVersionsToProtocolVersions,
4848
} from '../../util/supportedProtocolVersions'
4949
import { enableMixedRouteEthWeth } from '../../util/enableMixedRouteEthWeth'
50+
import { HOOKS_ADDRESSES_ALLOWLIST } from '../../util/hooksAddressesAllowlist'
5051

5152
export class QuoteHandler extends APIGLambdaHandler<
5253
ContainerInjected,
@@ -509,6 +510,11 @@ export class QuoteHandler extends APIGLambdaHandler<
509510
trade,
510511
} = swapRoute
511512

513+
if (hitsCachedRoute && trade.priceImpact.greaterThan(new Percent(20, 10000))) {
514+
metric.putMetric('CachedRoutePriceImpactTooHigh', 1, MetricLoggerUnit.Count)
515+
metric.putMetric(`CachedRoutePriceImpactTooHighChainId${chainId}`, 1, MetricLoggerUnit.Count)
516+
}
517+
512518
const estimatedGasUsed = adhocCorrectGasUsed(preProcessedEstimatedGasUsed, chainId)
513519
const estimatedGasUsedUSD = adhocCorrectGasUsedUSD(
514520
preProcessedEstimatedGasUsed,
@@ -567,6 +573,11 @@ export class QuoteHandler extends APIGLambdaHandler<
567573
continue
568574
}
569575

576+
if (nextPool.hooks !== ADDRESS_ZERO && !HOOKS_ADDRESSES_ALLOWLIST[chainId].includes(nextPool.hooks)) {
577+
metric.putMetric(`V4UndesiredHooksOnChain${chainId}`, 1, MetricLoggerUnit.Count)
578+
metric.putMetric(`V4UndesiredHooksOnChain${chainId}Hooks${nextPool.hooks}`, 1, MetricLoggerUnit.Count)
579+
}
580+
570581
curRoute.push({
571582
type: 'v4-pool',
572583
address: v4PoolProvider.getPoolId(

0 commit comments

Comments
 (0)