Skip to content

Commit 2dafb77

Browse files
authored
Merge pull request #53 from UoMResearchIT/prepare-for-public
Preparing to take the repository public
2 parents e7d917a + e010bca commit 2dafb77

File tree

2 files changed

+19
-15
lines changed

2 files changed

+19
-15
lines changed

.github/CONTRIBUTING.md

Lines changed: 18 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -1,33 +1,37 @@
11
# Contributing to these Actions
22

3-
These actions are owned by the [Automation Working Group](https://github.com/UoMResearchIT/RSE-Continuous-Improvement/wiki/Automation-Working-Group) at the University of Manchester's [Research Software Engineering](https://research-it.manchester.ac.uk/services/research-software-engineering/) department.
3+
These Actions are owned by the [Automation Working Group](https://github.com/UoMResearchIT/RSE-Continuous-Improvement/wiki/Automation-Working-Group) at the University of Manchester's [Research Software Engineering](https://research-it.manchester.ac.uk/services/research-software-engineering/) department. We're very happy to accept contributions from other parts of the University, provided those are contributions of reusable Actions that stand a chance of being useful across many projects or reports of issues (whether requests for new Actions or bug reports).
44

5-
Contributions are welcomed from outside, but are prioritised from members of the University.
5+
Contributions of code are not normally accepted from outside the University.
66

7-
To contribute, simply raise a Pull Request.
7+
Contributions of bug reports are welcome from outside the University.
88

99
## Guidelines for a Good Action
1010

11-
A good Action should be:
12-
* Slightly tricky to get right. Just calling `mkdir foo` doesn't need a special action!
13-
* Usable in more than one place.
11+
A good Action ***should*** be:
12+
* Slightly tricky to get right. Just calling `mkdir foo` doesn't need a special Action!
13+
* Anything extremely tricky to get right is probably too complex for an Action in the first place.
14+
* Usable in more than one place; we do not want to encode particular ways of working too strongly in this repository's Actions, as the University has far too much variation there.
1415
* Documented in its `README`, especially:
15-
* At least one example. It doesn't need to cover anything, but it does need to cover the least one could do to make use of the Action.
16-
* Whether the Action needs a specific runner. If any runner will do (sometimes a good reason for making an Action is to encourage portability) then the Action should be tested on all three main runner types.
17-
* What its inputs and outputs are, if any (NB: if a security token _other than the Github token_ is required by the Action, it _must_ be presented via an input).
18-
* Whether any special permissions need to be granted to the Github token.
19-
* Self-contained so that dependencies are not assumed (unless you documented that they're required).
16+
* A __summary__ sentence or more, to explain at a glance why one might use the Action.
17+
* At least one __example__. It doesn't need to cover anything fancy, but it does need to cover the least one could do to make use of the Action, to let a user of the Action get started easily.
18+
* Whether the Action needs a __specific runner__. If any runner will do (sometimes a good reason for making an Action is to encourage portability) then the Action should be tested on all three main runner types.
19+
* What its __inputs and outputs__ are, if any (NB: if a security token _other than the Github token_ is required by the Action, it _must_ be presented via an input).
20+
* Whether any __special permissions__ need to be granted to the Github token.
21+
* Self-contained so that dependencies are not assumed, unless you document that they're required.
2022

2123
Actions _may_ use other Actions, but there is a maximum depth, so it's not recommended to make this particularly deep.
2224

23-
Lack of documentation or documentation that is at variance with what the Action does is considered to be a **BUG** and should be reported.
25+
Lack of documentation or documentation that is at variance with what the Action does is considered to be a **BUG** and should be reported as such.
2426

2527
## Guidelines for Reviewing
2628

27-
A contribution to this repository _should not_ be accepted unless it is understood fully. This is particularly important for any contribution from someone outside the University, alas, especially for any Action that requires any form of non-standard security token or elevated privileges.
29+
The guidelines for a good Action outlined above should be borne in mind when reviewing.
30+
31+
A contribution to this repository _should not_ be accepted unless it is understood fully. This is particularly important for any contribution to any Action that requires any form of non-standard security token or elevated privileges.
2832

2933
# See Also
3034
* [Teams Chat](https://teams.microsoft.com/l/message/19:8b39cf4dd3c544c88fa1e6be1c978839@thread.v2/1739808070861?context=%7B%22contextType%22%3A%22chat%22%7D).
3135

3236
> [!NOTE]
33-
> Many links _on this page_ will not resolve for people outside the University. We know.
37+
> Some links _on this page_ will not resolve for people outside the University. We know.

README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
# UoM Research IT Github Actions
2-
This is a collection of Github Actions, mainly for University of Manchester use. It is the intention to make this into a _public_ repository once we are happy with the name, have a suitable agreed license, etc.
2+
This is a collection of Github Actions, mainly for University of Manchester use. We do not intend to publish these to the Github Actions Marketplace.
33

44
# General Tools
55

0 commit comments

Comments
 (0)