Check array aggregate discrete range type

Author: kraigher

vhdl_lang/src/analysis/expression.rs

@@ -996,8 +996,17 @@ impl<'a> AnalyzeContext<'a> {
                                 &mut index_expr.item,
                                 diagnostics,
                             ) {
-                                Ok(Some(_)) => {
-                                    // @TODO check type matches index type
+                                Ok(Some(typ)) => {
+                                    if let Some(index_type) = index_type {
+                                        if !self.can_be_target_type(typ, index_type) {
+                                            diagnostics.push(Diagnostic::type_mismatch(
+                                                &index_expr.pos,
+                                                &typ.describe(),
+                                                index_type.into(),
+                                            ));
+                                        }
+                                    }
+
                                     can_be_array = true;
                                 }
                                 Ok(None) => {

vhdl_lang/src/analysis/tests/typecheck_expression.rs

@@ -949,15 +949,25 @@ constant good2 : string(1 to 6) := (\"text\", others => ' ');
 #[test]
 fn array_element_association_may_be_type_denoting_discrete_range() {
     let mut builder = LibraryBuilder::new();
-    builder.in_declarative_region(
+    let code = builder.in_declarative_region(
         "
 subtype sub_t is natural range 1 to 3;
-constant good1 : integer_vector := (sub_t => 0);
+constant good : integer_vector := (sub_t => 0);
+
+subtype csub_t is character range 'a' to 'b';
+constant bad : integer_vector := (csub_t => 0);
+
         ",
     );
 
     let diagnostics = builder.analyze();
-    check_no_diagnostics(&diagnostics);
+    check_diagnostics(
+        diagnostics,
+        vec![Diagnostic::error(
+            code.s1("csub_t =>").s1("csub_t"),
+            "subtype 'csub_t' does not match integer type 'INTEGER'",
+        )],
+    );
 }
 
 #[test]