Update SimbaEvents.Register to take events to register for. Reduces many useless function calls

Author: ollydev

Source/Simba.lpi

@@ -16,15 +16,16 @@
   Classes, SysUtils, Interfaces, Forms,
   simba.base,
   simba.form_main, simba.form_about, simba.form_imagestring,
-  simba.form_functionlist, simba.form_output, simba.form_filebrowser,
+  simba.form_output, simba.form_filebrowser,
   simba.form_notes, simba.form_settings, simba.form_openexample, simba.form_shapebox,
   simba.form_backups, simba.form_findinfiles, simba.form_downloadsimba, simba.form_package,
   simba.form_colorpickhistory,
   simba.plugin_dump, simba.script_runner,
   simba.initializations, simba.ide_analytics, simba.script,
   simba.openssl,
   simba.ide_colorpicker, simba.ide_windowselector, simba.ide_areaselector,
-  simba.ide_mainmenubar, simba.ide_maintoolbar, simba.ide_mainstatusbar;
+  simba.ide_mainmenubar, simba.ide_maintoolbar, simba.ide_mainstatusbar,
+  simba.form_functionlist;
 
 begin
   {$IF DECLARED(HEAPTRC)}
@@ -130,7 +131,6 @@
 
     Application.ShowMainForm := False;
     Application.CreateForm(TSimbaMainForm, SimbaMainForm);
-    Application.CreateForm(TSimbaFunctionListForm, SimbaFunctionListForm);
     Application.CreateForm(TSimbaNotesForm, SimbaNotesForm);
     Application.CreateForm(TSimbaOutputForm, SimbaOutputForm);
     Application.CreateForm(TSimbaFileBrowserForm, SimbaFileBrowserForm);

Source/Simba.lpr

@@ -86,7 +86,7 @@ procedure TSimbaAboutForm.FormCreate(Sender: TObject);
   Width := Scale96ToScreen(550);
   Height := Scale96ToScreen(450);
 
-  SimbaEvents.Register(Self, @DoSimbaEvent);
+  SimbaEvents.Register(Self, @DoSimbaEvent, [ESimbaEvent.ACTION_ABOUT]);
 end;
 
 procedure TSimbaAboutForm.VersionLabelClick(Sender: TObject);

Source/ide/simba.form_about.pas

@@ -210,7 +210,6 @@ procedure TSimbaBackupsForm.DoSimbaEvent(Event: ESimbaEvent; Data: Pointer);
   case Event of
     ESimbaEvent.FORM_DOCK,
     ESimbaEvent.FORM_UNDOCK:        DoDockOrUnDock();
-
     ESimbaEvent.ACTION_OPEN_BACKUP,
     ESimbaEvent.ACTION_VIEW_BACKUP: DoViewBackups();
   end;
@@ -267,7 +266,12 @@ procedure TSimbaBackupsForm.FormCreate(Sender: TObject);
   Splitter.OnEnter := @DoSplitterEnterExit;
   Splitter.OnExit := @DoSplitterEnterExit;
 
-  SimbaEvents.Register(Self, @DoSimbaEvent);
+  SimbaEvents.Register(Self, @DoSimbaEvent, [
+    ESimbaEvent.FORM_DOCK,
+    ESimbaEvent.FORM_UNDOCK,
+    ESimbaEvent.ACTION_OPEN_BACKUP,
+    ESimbaEvent.ACTION_VIEW_BACKUP
+  ]);
 end;
 
 procedure TSimbaBackupsForm.FormShow(Sender: TObject);

Source/ide/simba.form_backups.pas

@@ -104,7 +104,7 @@ procedure TSimbaColorPickHistoryForm.FormCreate(Sender: TObject);
 
   LoadColors();
 
-  SimbaEvents.Register(Self, @DoSimbaEvent);
+  SimbaEvents.Register(Self, @DoSimbaEvent, [ESimbaEvent.COLOR_PICKED,ESimbaEvent.ACTION_VIEW_COLORHISTORY]);
 end;
 
 procedure TSimbaColorPickHistoryForm.FormDestroy(Sender: TObject);

Source/ide/simba.form_colorpickhistory.pas

@@ -249,7 +249,7 @@ procedure TSimbaDownloadSimbaForm.FormCreate(Sender: TObject);
 
   Notebook1.PageIndex := 0;
 
-  SimbaEvents.Register(Self, @DoSimbaEvent);
+  SimbaEvents.Register(Self, @DoSimbaEvent, [ESimbaEvent.ACTION_DOWNLOAD_SIMBA]);
 end;
 
 procedure TSimbaDownloadSimbaForm.DoGetNodeColor(Node: TTreeNode; var TheColor: TColor);

Source/ide/simba.form_downloadsimba.pas

@@ -6,6 +6,7 @@ object SimbaFileBrowserForm: TSimbaFileBrowserForm
   Caption = 'File Browser'
   DesignTimePPI = 192
   ShowInTaskBar = stAlways
+  LCLVersion = '4.0.0.4'
   object Popup: TPopupMenu
     OnPopup = PopupPopup
     Left = 176

Source/ide/simba.form_filebrowser.lfm

@@ -325,7 +325,7 @@ constructor TSimbaFileBrowserForm.Create(AOwner: TComponent);
   FTreeView.PopupMenu := Popup;
   FTreeView.OnCustomFilter := @DoCustomFilter;
 
-  SimbaEvents.Register(Self, @DoSimbaEvent);
+  SimbaEvents.Register(Self, @DoSimbaEvent, [ESimbaEvent.ACTION_VIEW_FILEBROWSER, ESimbaEvent.SPLITTER_DOUBLE_CLICK]);
   SimbaSettings.RegisterChangeHandler(Self, SimbaSettings.General.FileBrowserMasks, @DoSimbaSettingChanged, True);
 
   Fill();

Source/ide/simba.form_filebrowser.pas

@@ -447,7 +447,7 @@ procedure TSimbaFindInFilesForm.FormCreate(Sender: TObject);
   Tab.FCheckboxOptions.Checked[1] := SimbaSettings.General.FindInFilesCaseSens.Value;
   Tab.FCheckboxOptions.Checked[2] := SimbaSettings.General.FindInFilesWholeWords.Value;
 
-  SimbaEvents.Register(Self, @DoSimbaEvent);
+  SimbaEvents.Register(Self, @DoSimbaEvent, [ESimbaEvent.ACTION_FIND_IN_FILES]);
 end;
 
 procedure TSimbaFindInFilesForm.FormClose(Sender: TObject; var CloseAction: TCloseAction);