Skip to content

VCST-3900: Store comparable settings provider #158

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 16 commits into from
Closed

VCST-3900: Store comparable settings provider #158

wants to merge 16 commits into from
+123 −0

Conversation

@yuskithedeveloper
Copy link

@yuskithedeveloper yuskithedeveloper commented Nov 13, 2025 •
edited by vc-ci
Loading

vc-ci
vc-ci reviewed Nov 13, 2025
View reviewed changes
Copy link
Contributor

@vc-ci vc-ci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test Suite: Test Suites/Modules/module_Assets
Tests: 13
Failures: 0
Errors: 0
Time: 7.977
Timestamp: 13-11-2025T14:48:40

vc-ci
vc-ci reviewed Nov 13, 2025
View reviewed changes
Copy link
Contributor

@vc-ci vc-ci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test Suite: Test Suites/Modules/module_Assets
Tests: 13
Failures: 0
Errors: 0
Time: 7.709
Timestamp: 13-11-2025T22:09:26

vc-ci
vc-ci reviewed Nov 18, 2025
View reviewed changes
Copy link
Contributor

@vc-ci vc-ci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test Suite: Test Suites/Modules/module_Assets
Tests: 13
Failures: 0
Errors: 0
Time: 8.142
Timestamp: 18-11-2025T13:21:02

vc-ci
vc-ci reviewed Nov 18, 2025
View reviewed changes
Copy link
Contributor

@vc-ci vc-ci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test Suite: Test Suites/Modules/module_Assets
Tests: 13
Failures: 0
Errors: 0
Time: 7.057
Timestamp: 18-11-2025T14:26:39

vc-ci
vc-ci reviewed Nov 18, 2025
View reviewed changes
Copy link
Contributor

@vc-ci vc-ci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test Suite: Test Suites/Modules/module_Assets
Tests: 13
Failures: 0
Errors: 0
Time: 7.855
Timestamp: 18-11-2025T19:20:50

vc-ci
vc-ci reviewed Nov 18, 2025
View reviewed changes
Copy link
Contributor

@vc-ci vc-ci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test Suite: Test Suites/Modules/module_Assets
Tests: 13
Failures: 0
Errors: 0
Time: 7.346
Timestamp: 18-11-2025T22:29:15

vc-ci
vc-ci reviewed Nov 19, 2025
View reviewed changes
Copy link
Contributor

@vc-ci vc-ci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test Suite: Test Suites/Modules/module_Assets
Tests: 13
Failures: 0
Errors: 0
Time: 7.604
Timestamp: 19-11-2025T12:21:25

vc-ci
vc-ci reviewed Nov 19, 2025
View reviewed changes
Copy link
Contributor

@vc-ci vc-ci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test Suite: Test Suites/Modules/module_Assets
Tests: 13
Failures: 0
Errors: 0
Time: 7.475
Timestamp: 19-11-2025T12:30:44

@yuskithedeveloper yuskithedeveloper marked this pull request as ready for review November 19, 2025 12:38
vc-ci
vc-ci reviewed Nov 19, 2025
View reviewed changes
Copy link
Contributor

@vc-ci vc-ci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test Suite: Test Suites/Modules/module_Assets
Tests: 13
Failures: 0
Errors: 0
Time: 7.313
Timestamp: 19-11-2025T12:39:56

vc-ci
vc-ci reviewed Nov 20, 2025
View reviewed changes
Copy link
Contributor

@vc-ci vc-ci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test Suite: Test Suites/Modules/module_Assets
Tests: 13
Failures: 0
Errors: 0
Time: 7.567
Timestamp: 20-11-2025T12:48:57

vc-ci
vc-ci reviewed Nov 20, 2025
View reviewed changes
Copy link
Contributor

@vc-ci vc-ci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test Suite: Test Suites/Modules/module_Assets
Tests: 13
Failures: 0
Errors: 0
Time: 7.321
Timestamp: 20-11-2025T12:58:37

basilkot
basilkot previously approved these changes Nov 20, 2025
View reviewed changes
vc-ci
vc-ci reviewed Nov 20, 2025
View reviewed changes
Copy link
Contributor

@vc-ci vc-ci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test Suite: Test Suites/Modules/module_Assets
Tests: 13
Failures: 0
Errors: 0
Time: 7.563
Timestamp: 20-11-2025T14:38:28

@sonarqubecloud
Copy link

sonarqubecloud bot commented Nov 27, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@OlegoO
Copy link
Contributor

OlegoO commented Nov 28, 2025

ComparableStoreSettingsProvider migarted to VirtoCommerce.EnvironmentsCompare module

@OlegoO OlegoO closed this Nov 28, 2025
@OlegoO OlegoO deleted the feat/VCST-3900-comparable-store-settings branch November 28, 2025 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vc-ci vc-ci vc-ci left review comments

@basilkot basilkot basilkot approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@yuskithedeveloper @OlegoO @basilkot @vc-ci @kutasinaelena