-
Notifications
You must be signed in to change notification settings - Fork 5
Open
Labels
bugSomething isn't workingSomething isn't workingcodecsRelates to useful/missing Circe codec (regardless of Akka serialization)Relates to useful/missing Circe codec (regardless of Akka serialization)nice to haveNot very strictly needed for ASH to be usableNot very strictly needed for ASH to be usable
Description
In specific scenarios, codec registration checker plugin does not find missing codec registrations - i.e. when using sbt incremental compilation. Example scenario with explanation - steps to be performed on a project that uses ASH:
- sbt compile on existing code (fresh compilation on all files) - compilation succeeds - OK
- add new top level serializable class (in a separate file) and do not register it in serializer
- sbt compile - compilation succeeds - NOT OK
If we would perform only steps 2. and 3. - sbt compile would end in an error (which is what we want) saying that there are missing codec registrations. So, this is an issue with incremental compilation. The reason of this issue is to fix such "false negatives". Compilation should never succeed for situations as described above - whether this is full compilation on all sources - or just an incremental compilation on one or more added files.
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
bugSomething isn't workingSomething isn't workingcodecsRelates to useful/missing Circe codec (regardless of Akka serialization)Relates to useful/missing Circe codec (regardless of Akka serialization)nice to haveNot very strictly needed for ASH to be usableNot very strictly needed for ASH to be usable