Merge pull request #3551 from VisActor/fix/extensiom-mark-update-when-has-name

fix: fix update of extensionMark when mark has `name`, fix #3547

Author: xile611

common/changes/@visactor/vchart/fix-extensiom-mark-update-when-has-name_2024-12-11-08-09.json

@@ -0,0 +1,11 @@
+{
+  "changes": [
+    {
+      "comment": "fix: fix update of extensionMark when mark has `name`, fix #3547\n\n",
+      "type": "none",
+      "packageName": "@visactor/vchart"
+    }
+  ],
+  "packageName": "@visactor/vchart",
+  "email": "[email protected]"
+}

packages/vchart/src/component/custom-mark/custom-mark.ts

@@ -8,12 +8,10 @@ import { PREFIX } from '../../constant/base';
 import type { EnableMarkType, ICustomMarkGroupSpec, ICustomMarkSpec, ILayoutRect } from '../../typings';
 import type { IGroupMark } from '../../mark/group';
 import type { IMark } from '../../mark/interface';
-import type { LooseFunction } from '@visactor/vutils';
 // eslint-disable-next-line no-duplicate-imports
 import { Bounds, isEqual, isNil, isValid, isValidNumber } from '@visactor/vutils';
 import { Factory } from '../../core/factory';
 import type { IGraphic } from '@visactor/vrender-core';
-import { HOOK_EVENT } from '@visactor/vgrammar-core';
 import { animationConfig, userAnimationConfig } from '../../animation/utils';
 import type { IModelMarkAttributeContext } from '../../compile/mark/interface';
 

packages/vchart/src/series/base/base-series.ts

@@ -758,7 +758,9 @@ export abstract class BaseSeries<T extends ISeriesSpec> extends BaseModel<T> imp
 
   protected _updateExtensionMarkSpec() {
     this._spec.extensionMark?.forEach((spec, i) => {
-      const mark = this._marks.getMarkWithInfo({ name: `${this._getExtensionMarkNamePrefix()}_${i}` });
+      const mark = this._marks.getMarkWithInfo({
+        name: isValid(spec.name) ? `${spec.name}` : `${this._getExtensionMarkNamePrefix()}_${i}`
+      });
       if (!mark) {
         return;
       }
@@ -1030,7 +1032,9 @@ export abstract class BaseSeries<T extends ISeriesSpec> extends BaseModel<T> imp
     if (
       newMarks.length !== prevMarks.length ||
       prevMarks.some((prev, index) => {
-        return prev.type !== newMarks[index].type || prev.id !== newMarks[index].id;
+        return (
+          prev.type !== newMarks[index].type || prev.id !== newMarks[index].id || prev.name !== newMarks[index].name
+        );
       })
     ) {
       compareResult.reMake = true;