destroy app_ instance on guiDestroy

JWBverheesen · mtytel · commit 718bc5b85120 · 2026-02-05T20:42:12.000-05:00
Tested with Reaper on linux, guiDestroy is invoked when closing the UI, or the parent window the plugin is displayed in. This generates a x11 bad window error: X11 Error: 3

To resolve, reset the unique_ptr app_ by assigning nullptr to it. clap/gui.h states that all resources associated with the gui should be freed.
diff --git a/examples/ClapPlugin/clap_plugin.cpp b/examples/ClapPlugin/clap_plugin.cpp
@@ -97,6 +97,10 @@ void ClapPlugin::guiDestroy() noexcept {
 #endif
 
   app_->close();
+
+#if __linux__
+  app_ = nullptr;
+#endif
 }
 
 bool ClapPlugin::guiSetParent(const clap_window* window) noexcept {

Original file line number	Diff line number	Diff line change
`@@ -97,6 +97,10 @@ void ClapPlugin::guiDestroy() noexcept {`
`97`	`97`	`#endif`
`98`	`98`
`99`	`99`	`app_->close();`
	`100`	`+`
	`101`	`+#if __linux__`
	`102`	`+ app_ = nullptr;`
	`103`	`+#endif`
`100`	`104`	`}`
`101`	`105`
`102`	`106`	`bool ClapPlugin::guiSetParent(const clap_window* window) noexcept {`