Conversation
These need to be moved away from Triangulate.jl in order to address JuliaGeometry/Triangulate.jl#19
pjaap
left a comment
There was a problem hiding this comment.
If I got this right, then this is just moved from https://github.com/JuliaGeometry/Triangulate.jl/blob/master/src/plot.jl? I think this should be mentioned somewhere in the code for future code blaming.
An the Copilot comments seem reasonable :)
|
The permalink https://github.com/JuliaGeometry/Triangulate.jl/blob/2aa1196625832b622eb808b165cab8c7a098c6c5/src/plot.jl should be used, since the other file will be gone soon |
|
Right. Where would you put the code provenance info ? In the moment I put it into comments in the Makie and Pyplot extension. |
There was a problem hiding this comment.
Pull Request Overview
This PR adds new methods to plot TriangulateIO structures separate from Triangulate.jl to reduce technical debt.
- Introduces plot_triangulateio and plot_triangulateio! functions for both PyPlot and Makie backends.
- Updates exports, imports, documentation, examples, and README to integrate the new plotting functionality.
Reviewed Changes
Copilot reviewed 10 out of 10 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/dispatch.jl | Adds new generic dispatch functions for plotting TriangulateIO structures. |
| src/GridVisualize.jl | Exports the new plotting functions. |
| ext/GridVisualizePyPlotExt.jl | Imports and integrates the new plot_triangulateio! function for the PyPlot backend. |
| ext/GridVisualizeMakieExt.jl | Implements the Makie version of plot_triangulateio! with detailed plotting routines. |
| examples/plotting.jl | Provides an example showcasing the new TriangulateIO plotting functions. |
| docs/src/api.md | Updates API documentation to include the new functions. |
| docs/make.jl | Formats the docs generation script for the new examples. |
| docs/Project.toml | Adds Triangulate dependency to the docs. |
| README.md | Updates the feature table to list the triangulateio plotting support. |
Comments suppressed due to low confidence (1)
src/dispatch.jl:986
- Consider adding a comment or a more explicit signature to clarify the purpose of the empty 'plot_triangulateio' function, ensuring maintainers understand it's an intentional placeholder for method dispatch.
function plot_triangulateio end
|
I would put it directly above the snippet that was inserted so if someone does |
These need to be moved away from Triangulate.jl in order to address JuliaGeometry/Triangulate.jl#19
This is another part of technical debt...