add a note

dkondor · dkondor · commit a1c9ec17b68d · 2025-06-16T20:44:27.000+08:00
diff --git a/plugins/protocols/xdg-activation.cpp b/plugins/protocols/xdg-activation.cpp
@@ -156,6 +156,9 @@ class wayfire_xdg_activation_protocol_impl : public wf::plugin_interface_t
             if (view)
             {
                 last_view = wf::toplevel_cast(view); // might return nullptr
+                //!! does not work for:
+                // (1) layer-shell views
+                // (2) (some) menus
                 if (last_view)
                 {
                     last_view->connect(&on_view_unmapped);

Original file line number	Diff line number	Diff line change
`@@ -156,6 +156,9 @@ class wayfire_xdg_activation_protocol_impl : public wf::plugin_interface_t`
`156`	`156`	`if (view)`
`157`	`157`	`{`
`158`	`158`	`last_view = wf::toplevel_cast(view); // might return nullptr`
	`159`	`+ //!! does not work for:`
	`160`	`+ // (1) layer-shell views`
	`161`	`+ // (2) (some) menus`
`159`	`162`	`if (last_view)`
`160`	`163`	`{`
`161`	`164`	`last_view->connect(&on_view_unmapped);`