Gradle Update #5
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Use Gradle 8.13 - Migrate to Kotlin build files
- Stop wrapping non-zero exit in another runtime exception - Capture any stderr output and include it in the exception - Stop setting `GIT_DIR` as git supports relocating the local repo to a different directory then `.git`
There was a problem hiding this comment.
PR Overview
This PR updates the project to Gradle 8.13 and migrates the build to Kotlin files while enhancing Git command error handling. Key changes include:
- Adding a new GitException class for improved error reporting.
- Refactoring VersionGenerator.java to use modern Java APIs and streamline git command execution.
- Updating VersioningPlugin.java to use TaskProvider and revising the build pipeline configuration.
Reviewed Changes
| File | Description |
|---|---|
| src/main/java/com/widen/versioning/GitException.java | Introduces a custom exception for Git errors. |
| mise.toml | Sets the Java tool to "corretto-11". |
| src/main/java/com/widen/versioning/VersionGenerator.java | Refactors git command execution and error message formatting. |
| src/main/java/com/widen/versioning/VersioningPlugin.java | Migrates task creation to TaskProvider for improved configuration. |
| .buildkite/pipeline.yml | Updates pipeline configuration to use new build images and queues. |
Copilot reviewed 15 out of 15 changed files in this pull request and generated no comments.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Git exec changes
GIT_DIRas git supports relocating the local repo to a different directory then.git