Finished callbacks support and tests

Author: Miguel Garcia Lafuente

lib/vendor/mockMashupPlatform.js

@@ -110,7 +110,7 @@ var MockMP = {};
         // });
         // Don't need, because setStrategy restore all
 
-        // And get back to the default values
+        // Get back to the default values
         if (typeof this.defaultValues === 'undefined' || typeof this.defaultValues !== 'object') {
             this.defaultValues = {};
         }
@@ -123,13 +123,27 @@ var MockMP = {};
         createMocks.call(this);
     };
 
+    namespace.MockMP.prototype.simulateReceiveEvent = function simulateReceiveEvent(name, value) {
+        _call_callbacks.call(this, 'wiring', name, value, true);
+    };
+
+    namespace.MockMP.prototype.simulateReceiveContext = function simulateReceiveContext(name, values) {
+        var single_o = false;
+        if (typeof values === 'undefined') {
+            values = name;
+            name = '';
+            single_o = true;
+        }
+        _call_callbacks.call(this, 'widget', name, values, single_o);
+    };
+
 
     /*****************************************************************************/
     /********************************** Private **********************************/
     /*****************************************************************************/
 
     var default_preferences_set = function default_preferences_set(name, value) {
-        /* istanbul ignore else */  // ignore else because it should never lead to that
+        /* istanbul ignore next: This function is private, shouldn't be called outside */
         if (this.methodValues && this.methodValues['prefs.get']) {
             var old_f = this.methodValues['prefs.get'];
             this.methodValues['prefs.get'] = function (name2) {
@@ -152,7 +166,7 @@ var MockMP = {};
 
     var default_register_callback = function default_register_callback(name) {
         var valid_names = ['prefs', 'widget', 'wiring'];
-        /* istanbul ignore next */ // This function is private, shouldn't be called outside
+        /* istanbul ignore next: This function is private, shouldn't be called outside */
         if (valid_names.indexOf(name) == -1) {
             throw new TypeError('You are trying to register in a non existant name: ' + name);
         }
@@ -172,7 +186,6 @@ var MockMP = {};
             if (typeof this.callbacks[name][setted] === 'undefined') {
                 this.callbacks[name][setted] = [];
             }
-
             this.callbacks[name][setted].push(cb);
             return null;
         };
@@ -192,14 +205,18 @@ var MockMP = {};
         if (typeof onlyValue === 'undefined') {
             onlyValue = false;
         }
+        var toget = vname;
         if (!onlyValue) {
             var nv = {};
             nv[vname] = value;  // Send as object
             value = nv;
+            toget = '';
         }
 
-        var calls = _get_callbacks.call(this, 'prefs', 'vname');
+        var calls = _get_callbacks.call(this, cname, toget);
+
         for (var c in calls) {
+            /* istanbul ignore else: The callback initializer ensures that this will be a function */
             if (typeof calls[c] == 'function') {
                 calls[c](value);
             }
@@ -208,16 +225,16 @@ var MockMP = {};
 
     var _get_callbacks = function _get_callbacks(name, sname) {
         _initialize_callbacks.call(this);
+        /* istanbul ignore next: This function is private, shouldn't be called outside */
         if (!this.callbacks[name]) {
             return [];
         }
         var callsn = this.callbacks[name];
 
-        var allcalls = callsn[''] || [];
-
+        var allcalls = callsn[''] || /* istanbul ignore next: We've already initialized before */ [];
         if (typeof sname !== 'undefined' && sname !== '') {
             var speccalls = callsn[sname] || [];
-            allcalls.concat(speccalls);
+            allcalls = allcalls.concat(speccalls);
         }
 
         return allcalls;
@@ -231,7 +248,6 @@ var MockMP = {};
     };
 
     var mergeDefault = function mergeDefault(methodValues) {
-
         var defaultValues = {
             "context.get": namespace.strategy.constant("not set yet"),
             "http.buildProxyURL": namespace.strategy.constant(null),
@@ -241,17 +257,17 @@ var MockMP = {};
             "log.INFO": 3,
             "mashup.context.get": namespace.strategy.constant(null),
             "prefs.get": namespace.strategy.constant("value"),
-            "prefs.set": default_functionality['prefs.set'].bind(this),  // namespace.strategy.constant(null),
-            "prefs.registerCallback": default_functionality['prefs.registerCallback'].bind(this), //namespace.strategy.constant(null),
+            "prefs.set": default_functionality['prefs.set'].bind(this),
+            "prefs.registerCallback": default_functionality['prefs.registerCallback'].bind(this),
             "widget.getVariable": namespace.strategy.constant("value"),
             "widget.drawAttention": namespace.strategy.constant(null),
             "widget.id": "id33",
             "widget.log": namespace.strategy.constant("something"),
             "widget.context.get": namespace.strategy.constant(null),
-            "widget.context.registerCallback": default_functionality['widget.context.registerCallback'].bind(this), //namespace.strategy.constant(null),
+            "widget.context.registerCallback": default_functionality['widget.context.registerCallback'].bind(this),
             "wiring.getReachableEndpoints": namespace.strategy.constant([]),
             "wiring.pushEvent": namespace.strategy.constant(null),
-            "wiring.registerCallback": default_functionality['wiring.registerCallback'].bind(this)  //namespace.strategy.constant(null)
+            "wiring.registerCallback": default_functionality['wiring.registerCallback'].bind(this)
         };
 
         if (methodValues) {

test/js/mockMashupPlatformSpec.js

@@ -294,7 +294,57 @@
             expect(cb).toHaveBeenCalledWith({'test': 'value2'});
         });
 
-    });
+        it("Wiring callback", function() {
+            var cb = jasmine.createSpy('cb');
+            MashupPlatform.wiring.registerCallback('testv', cb);
+            expect(cb).not.toHaveBeenCalled();
+
+            MashupPlatform.simulateReceiveEvent('testv', 'myvalue!');
+            expect(cb).toHaveBeenCalledWith('myvalue!');
+        });
+
+        it("Don't call in other wiring event", function() {
+            var cb = jasmine.createSpy('cb');
+            MashupPlatform.wiring.registerCallback('testv', cb);
+            expect(cb).not.toHaveBeenCalled();
+
+            MashupPlatform.simulateReceiveEvent('othertestv', 'myvalue!');
+            expect(cb).not.toHaveBeenCalled();
+        });
+
+        it("Don't call the callback if you remove all callbacks, but don't break :)", function() {
+            var cb = jasmine.createSpy('cb');
+            MashupPlatform.wiring.registerCallback('testv', cb);
+            expect(cb).not.toHaveBeenCalled();
+
+            delete MashupPlatform.callbacks;
 
+            MashupPlatform.simulateReceiveEvent('testv', 'myvalue!');
+            expect(cb).not.toHaveBeenCalled();
+
+            MashupPlatform.wiring.registerCallback('testv', cb);
+            expect(cb).not.toHaveBeenCalled();
+
+            MashupPlatform.simulateReceiveEvent('testv', 'myvalue!');
+            expect(cb).toHaveBeenCalledWith('myvalue!');
+        });
+
+        it("Widget callback with object", function() {
+            var cb = jasmine.createSpy('cb');
+            MashupPlatform.widget.context.registerCallback(cb);
+            expect(cb).not.toHaveBeenCalled();
 
+            MashupPlatform.simulateReceiveContext({'test': 'value', 'test2': 'value2'});
+            expect(cb).toHaveBeenCalledWith({'test': 'value', 'test2': 'value2'});
+        });
+
+        it("Widget callback simulate only one value", function() {
+            var cb = jasmine.createSpy('cb');
+            MashupPlatform.widget.context.registerCallback(cb);
+            expect(cb).not.toHaveBeenCalled();
+
+            MashupPlatform.simulateReceiveContext('test', 'value');
+            expect(cb).toHaveBeenCalledWith({'test': 'value'});
+        });
+    });
 })();