From ee228f38262bd56e4f2f5b799a9b419f716a4274 Mon Sep 17 00:00:00 2001 From: Nikolay Date: Sat, 18 Jan 2014 18:07:59 +0400 Subject: [PATCH 01/12] Changed examples index.twig and layout.twig support Twitter bootstrap 3 --- examples/application/index/index.twig | 54 ++++++++++++++++++--------- examples/layout/layout.twig | 43 ++++++++++----------- 2 files changed, 58 insertions(+), 39 deletions(-) diff --git a/examples/application/index/index.twig b/examples/application/index/index.twig index 073b41f..22d4dc4 100644 --- a/examples/application/index/index.twig +++ b/examples/application/index/index.twig @@ -1,30 +1,48 @@ {% extends 'layout/layout.twig' %} {% block content %} -
-

{{ translate('Welcome to %sZend Framework 2%s'|format('', '')) }}

-

{{ translate('Congratulations! You have successfully installed the %sZF2 Skeleton Application%s. You are currently running Zend Framework version %s. This skeleton can serve as a simple starting point for you to begin building your application on ZF2.'|format('', '', 2)) }}

-

{{ translate('Fork Zend Framework 2 on GitHub') }} »

-
+
+

{{ translate('Welcome to %sZend Framework 2%s'|format('', '')) }}

+

{{ translate('Congratulations! You have successfully installed the %sZF2 Skeleton Application%s. You are currently running Zend Framework version %s. This skeleton can serve as a simple starting point for you to begin building your application on ZF2.'|format('', '', 2)) }}

+

{{ translate('Fork Zend Framework 2 on GitHub') }} »

+
-
+
-
-

{{ translate('Follow Development') }}

-

{{ translate('Zend Framework 2 is under active development. If you are interested in following the development of ZF2, there is a special ZF2 portal on the official Zend Framework website which provides links to the ZF2 %swiki%s, %sdev blog%s, %sissue tracker%s, and much more. This is a great resource for staying up to date with the latest developments!'|format('', '', '', '', '', '')) }}

-

{{ translate('ZF2 Development Portal') }} »

+
+
+
+

{{ translate('Follow Development') }}

+
+
+

{{ translate('Zend Framework 2 is under active development. If you are interested in following the development of ZF2, there is a special ZF2 portal on the official Zend Framework website which provides links to the ZF2 %swiki%s, %sdev blog%s, %sissue tracker%s, and much more. This is a great resource for staying up to date with the latest developments!'|format('', '', '', '', '', '')) }}

+

{{ translate('ZF2 Development Portal') }} »

+
+
-
-

{{ translate('Discover Modules') }}

-

{{ translate('The community is working on developing a community site to serve as a repository and gallery for ZF2 modules. The project is available %son GitHub%s. The site is currently live and currently contains a list of some of the modules already available for ZF2.'|format('', '')) }}

-

{{ translate('Explore ZF2 Modules') }} »

+
+
+
+

{{ translate('Discover Modules') }}

+
+
+

{{ translate('The community is working on developing a community site to serve as a repository and gallery for ZF2 modules. The project is available %son GitHub%s. The site is currently live and currently contains a list of some of the modules already available for ZF2.'|format('', '')) }}

+

{{ translate('Explore ZF2 Modules') }} »

+
+
-
-

{{ translate('Help & Support') }}

-

{{ translate('If you need any help or support while developing with ZF2, you may reach us via IRC: %s#zftalk on Freenode%s. We\'d love to hear any questions or feedback you may have regarding the beta releases. Alternatively, you may subscribe and post questions to the %smailing lists%s.'|format('', '', '', '')) }}

-

{{ translate('Ping us on IRC') }} »

+
+
+
+

{{ translate('Help & Support') }}

+
+
+

{{ translate('If you need any help or support while developing with ZF2, you may reach us via IRC: %s#zftalk on Freenode%s. We\'d love to hear any questions or feedback you may have regarding the beta releases. Alternatively, you may subscribe and post questions to the %smailing lists%s.'|format('', '', '', '')) }}

+

{{ translate('Ping us on IRC') }} »

+
+
{% endblock content %} \ No newline at end of file diff --git a/examples/layout/layout.twig b/examples/layout/layout.twig index 965303d..4d38030 100644 --- a/examples/layout/layout.twig +++ b/examples/layout/layout.twig @@ -10,44 +10,45 @@ {% block meta %}{% endblock meta %} - - - + + + + {% block style %}{% endblock style %} - + - - + + + {% block script %}{% endblock script %} -
-
-
- +
+
- {% block content %}{{ content|raw }}{% endblock content %}
-

© 2005 - 2012 by Zend Technologies Ltd. {{ translate('All rights reserved.') }}

+

© 2005 - 2014 by Zend Technologies Ltd. {{ translate('All rights reserved.') }}

{% block inline %}{% endblock inline %} - + \ No newline at end of file From f95c7e92d4edc671b36ce534cbdd01483697f378 Mon Sep 17 00:00:00 2001 From: Ladislav Kubes Date: Mon, 3 Feb 2014 09:09:43 +0100 Subject: [PATCH 02/12] update unit test to new 1.2 version --- .../View/Strategy/TwigStrategyTest.php | 18 +++++++++++------- 1 file changed, 11 insertions(+), 7 deletions(-) diff --git a/tests/ZfcTwigTest/View/Strategy/TwigStrategyTest.php b/tests/ZfcTwigTest/View/Strategy/TwigStrategyTest.php index c6d6470..fb19257 100644 --- a/tests/ZfcTwigTest/View/Strategy/TwigStrategyTest.php +++ b/tests/ZfcTwigTest/View/Strategy/TwigStrategyTest.php @@ -4,20 +4,24 @@ use PHPUnit_Framework_TestCase as TestCase; use Twig_Environment; use Twig_Loader_Array; +use Twig_Loader_Chain; use Zend\View\View; use Zend\View\ViewEvent; -use ZfcTwig\View\Renderer\TwigRenderer; -use ZfcTwig\View\Strategy\TwigStrategy; -use ZfcTwig\View\Resolver\TwigResolver; +use ZfcTwig\View\TwigRenderer; +use ZfcTwig\View\TwigStrategy; +use ZfcTwig\View\TwigResolver; class TwigStrategyTest extends TestCase { public function setUp() { - $this->environment = new Twig_Environment(new Twig_Loader_Array(array('key1' => 'var1'))); - $this->renderer = new TwigRenderer(new View, $this->environment, new TwigResolver($this->environment)); - $this->strategy = new TwigStrategy($this->renderer); - $this->event = new ViewEvent(); + $this->chain = $chain = new Twig_Loader_Chain(); + $this->loader = new Twig_Loader_Array(array('key1' => 'var1')); + $this->chain->addLoader($this->loader); + $this->environment = new Twig_Environment($this->chain); + $this->renderer = new TwigRenderer(new View, $this->chain, $this->environment, new TwigResolver($this->environment)); + $this->strategy = new TwigStrategy($this->renderer); + $this->event = new ViewEvent(); } public function testSelectRendererWhenTemplateFound() From 202ebb6ad3e6b9a6eac201806fd55a6882db4c5c Mon Sep 17 00:00:00 2001 From: Nikolay Date: Sun, 9 Mar 2014 19:21:00 +0400 Subject: [PATCH 03/12] Fixed examples/layout/layout.twig --- examples/layout/layout.twig | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/examples/layout/layout.twig b/examples/layout/layout.twig index 4d38030..56d31e4 100644 --- a/examples/layout/layout.twig +++ b/examples/layout/layout.twig @@ -11,15 +11,15 @@ - - + + {% block style %}{% endblock style %} - + {% block script %}{% endblock script %} @@ -51,4 +51,4 @@
{% block inline %}{% endblock inline %} - \ No newline at end of file + From 3725a37a89fd3fcc63b36702e1f7305b742585b2 Mon Sep 17 00:00:00 2001 From: Oleg Kolomiets Date: Thu, 3 Apr 2014 12:10:11 +0300 Subject: [PATCH 04/12] Update MapLoader.php Warning file_get_contents if file does not exist --- src/ZfcTwig/Twig/MapLoader.php | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/src/ZfcTwig/Twig/MapLoader.php b/src/ZfcTwig/Twig/MapLoader.php index cda7d5e..1eb66e2 100644 --- a/src/ZfcTwig/Twig/MapLoader.php +++ b/src/ZfcTwig/Twig/MapLoader.php @@ -53,6 +53,13 @@ public function getSource($name) $name )); } + + if( ! file_exists($this->map[$name])) { + throw new Twig_Error_Loader(sprintf( + 'Unable to open file "%s" from template map', + $this->map[$name] + )); + } return file_get_contents($this->map[$name]); } @@ -71,4 +78,4 @@ public function isFresh($name, $time) { return filemtime($this->map[$name]) <= $time; } -} \ No newline at end of file +} From 865093b76b39243310c0189a9efbf65391724316 Mon Sep 17 00:00:00 2001 From: Oleg Kolomiets Date: Thu, 3 Apr 2014 17:15:49 +0300 Subject: [PATCH 05/12] Update MapLoader.php updated to prc2 --- src/ZfcTwig/Twig/MapLoader.php | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/src/ZfcTwig/Twig/MapLoader.php b/src/ZfcTwig/Twig/MapLoader.php index 1eb66e2..5eecddb 100644 --- a/src/ZfcTwig/Twig/MapLoader.php +++ b/src/ZfcTwig/Twig/MapLoader.php @@ -53,8 +53,7 @@ public function getSource($name) $name )); } - - if( ! file_exists($this->map[$name])) { + if(!file_exists($this->map[$name])) { throw new Twig_Error_Loader(sprintf( 'Unable to open file "%s" from template map', $this->map[$name] From 0235932354b9c25b1a492e8921d3b2bfedcdba42 Mon Sep 17 00:00:00 2001 From: Kyle Spraggs Date: Tue, 29 Apr 2014 12:40:31 -0500 Subject: [PATCH 06/12] Added globals --- examples/layout/layout.twig | 8 ++++---- src/ZfcTwig/ModuleOptions.php | 21 +++++++++++++++++++++ src/ZfcTwig/Twig/EnvironmentFactory.php | 7 ++++++- 3 files changed, 31 insertions(+), 5 deletions(-) diff --git a/examples/layout/layout.twig b/examples/layout/layout.twig index 56d31e4..4d38030 100644 --- a/examples/layout/layout.twig +++ b/examples/layout/layout.twig @@ -11,15 +11,15 @@ - - + + {% block style %}{% endblock style %} - + {% block script %}{% endblock script %} @@ -51,4 +51,4 @@
{% block inline %}{% endblock inline %} - + \ No newline at end of file diff --git a/src/ZfcTwig/ModuleOptions.php b/src/ZfcTwig/ModuleOptions.php index 7e0f362..52d3dee 100644 --- a/src/ZfcTwig/ModuleOptions.php +++ b/src/ZfcTwig/ModuleOptions.php @@ -21,6 +21,11 @@ class ModuleOptions extends AbstractOptions */ protected $environmentOptions = array(); + /** + * @var array + */ + protected $globals = array(); + /** * @var array */ @@ -210,5 +215,21 @@ public function getEnvironmentClass() { return $this->environmentClass; } + + /** + * @param array $globals + */ + public function setGlobals($globals) + { + $this->globals = $globals; + } + + /** + * @return array + */ + public function getGlobals() + { + return $this->globals; + } } diff --git a/src/ZfcTwig/Twig/EnvironmentFactory.php b/src/ZfcTwig/Twig/EnvironmentFactory.php index dccfb4b..9be3789 100644 --- a/src/ZfcTwig/Twig/EnvironmentFactory.php +++ b/src/ZfcTwig/Twig/EnvironmentFactory.php @@ -19,7 +19,8 @@ public function createService(ServiceLocatorInterface $serviceLocator) /** @var \ZfcTwig\moduleOptions $options */ $options = $serviceLocator->get('ZfcTwig\ModuleOptions'); $envClass = $options->getEnvironmentClass(); - + + /** @var \Twig_Environment $env */ $env = new $envClass(null, $options->getEnvironmentOptions()); if ($options->getEnableFallbackFunctions()) { @@ -45,6 +46,10 @@ function ($name) use ($helperPluginManager) { $env->setLoader($serviceLocator->get($options->getEnvironmentLoader())); + foreach ($options->getGlobals() as $name => $value) { + $env->addGlobal($name, $value); + } + // Extensions are loaded later to avoid circular dependencies (for example, if an extension needs Renderer). return $env; } From 8593a15a8cf675e72aaf575aad2b314ed00b4358 Mon Sep 17 00:00:00 2001 From: Filip Halaxa Date: Sat, 3 May 2014 09:29:12 +0200 Subject: [PATCH 07/12] Missing $loader property fixed --- src/ZfcTwig/View/TwigRenderer.php | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/src/ZfcTwig/View/TwigRenderer.php b/src/ZfcTwig/View/TwigRenderer.php index bfa1a3b..e536bc1 100644 --- a/src/ZfcTwig/View/TwigRenderer.php +++ b/src/ZfcTwig/View/TwigRenderer.php @@ -29,6 +29,11 @@ class TwigRenderer implements RendererInterface, TreeRendererInterface */ protected $helperPluginManager; + /** + * @var Twig_Loader_Chain + */ + protected $loader; + /** * @var TwigResolver */ From c106c2c6686037d0eae686cfa0d0e94c91694760 Mon Sep 17 00:00:00 2001 From: jonmorrison99 Date: Tue, 8 Jul 2014 16:36:56 -0400 Subject: [PATCH 08/12] Update layout.twig jquery.min.js needs to be loaded before bootstrap.min.js --- examples/layout/layout.twig | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/examples/layout/layout.twig b/examples/layout/layout.twig index 4d38030..92f2662 100644 --- a/examples/layout/layout.twig +++ b/examples/layout/layout.twig @@ -18,8 +18,8 @@ {% block style %}{% endblock style %} - + {% block script %}{% endblock script %} @@ -51,4 +51,4 @@
{% block inline %}{% endblock inline %} - \ No newline at end of file + From 014e113de28e295269e721f16ae48de9337f179f Mon Sep 17 00:00:00 2001 From: kokspflanze Date: Mon, 14 Jul 2014 02:16:26 +0200 Subject: [PATCH 09/12] basePath added in layout.twig --- examples/layout/layout.twig | 18 +++++++++--------- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/examples/layout/layout.twig b/examples/layout/layout.twig index 92f2662..f03d55c 100644 --- a/examples/layout/layout.twig +++ b/examples/layout/layout.twig @@ -10,18 +10,18 @@ {% block meta %}{% endblock meta %} - - - - + + + + {% block style %}{% endblock style %} - - - - + + + + {% block script %}{% endblock script %} @@ -33,7 +33,7 @@ - Zend Framework 2 {{ translate('Skeleton Application') }} + Zend Framework 2 {{ translate('Skeleton Application') }}
    From 2ace56b9136a645f6125064f7838ddca2bcd9b88 Mon Sep 17 00:00:00 2001 From: Alexandre Lemaire Date: Wed, 6 Apr 2016 23:33:11 -0400 Subject: [PATCH 10/12] Inject the service manager here to prevent the latest zend-mvc from throwing deprecation notices managers that don't have the SL injected cause panic with the latest zend-servicemanager release. See \Zend\Mvc\Service\ServiceManagerConfig ``` // For service locator aware plugin managers that do not have // the service locator already injected, inject it, but emit a // deprecation notice. if ($instance instanceof ServiceLocatorAwareInterface && $instance instanceof AbstractPluginManager && ! $instance->getServiceLocator() ) { trigger_error(sprintf( 'ServiceLocatorAwareInterface is deprecated and will be removed in version 3.0, along ' . 'with the ServiceLocatorAwareInitializer. Please update your %s plugin manager factory ' . 'to inject the parent service locator via the constructor.', get_class($instance) ), E_USER_DEPRECATED); $instance->setServiceLocator($container); } ``` --- src/ZfcTwig/View/HelperPluginManagerFactory.php | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/ZfcTwig/View/HelperPluginManagerFactory.php b/src/ZfcTwig/View/HelperPluginManagerFactory.php index 5672f80..7e98b3f 100644 --- a/src/ZfcTwig/View/HelperPluginManagerFactory.php +++ b/src/ZfcTwig/View/HelperPluginManagerFactory.php @@ -28,6 +28,7 @@ public function createService(ServiceLocatorInterface $serviceLocator) $baseManager = $serviceLocator->get('ViewHelperManager'); $twigManager = new HelperPluginManager(new Config($managerOptions)); + $twigManager->setServiceLocator($serviceLocator); $twigManager->addPeeringServiceManager($baseManager); foreach ($managerConfigs as $configClass) { @@ -51,4 +52,4 @@ public function createService(ServiceLocatorInterface $serviceLocator) return $twigManager; } -} \ No newline at end of file +} From 44c870dd30bffba96be404555a5f468e374a44aa Mon Sep 17 00:00:00 2001 From: wardforthmann Date: Thu, 19 Apr 2018 19:04:16 -0700 Subject: [PATCH 11/12] Update StackLoader.php --- src/ZfcTwig/Twig/StackLoader.php | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/src/ZfcTwig/Twig/StackLoader.php b/src/ZfcTwig/Twig/StackLoader.php index be9f569..c564a79 100644 --- a/src/ZfcTwig/Twig/StackLoader.php +++ b/src/ZfcTwig/Twig/StackLoader.php @@ -39,8 +39,12 @@ public function getDefaultSuffix() return $this->defaultSuffix; } - protected function findTemplate($name) + protected function findTemplate($name, $acceptDeprecation) { + if ($acceptDeprecation === false) { + return false; + } + $name = (string) $name; // normalize name @@ -81,4 +85,4 @@ protected function findTemplate($name) throw new Twig_Error_Loader(sprintf('Unable to find template "%s" (looked into: %s).', $name, implode(', ', $this->paths[$namespace]))); } -} \ No newline at end of file +} From feb89e4f299d01b4b26923e99e3f7e9e82811aeb Mon Sep 17 00:00:00 2001 From: wardforthmann Date: Fri, 20 Apr 2018 11:25:03 -0700 Subject: [PATCH 12/12] Fixed template loader deprecation --- src/ZfcTwig/Twig/StackLoader.php | 13 ++++++------- 1 file changed, 6 insertions(+), 7 deletions(-) diff --git a/src/ZfcTwig/Twig/StackLoader.php b/src/ZfcTwig/Twig/StackLoader.php index c564a79..097de4f 100644 --- a/src/ZfcTwig/Twig/StackLoader.php +++ b/src/ZfcTwig/Twig/StackLoader.php @@ -39,12 +39,8 @@ public function getDefaultSuffix() return $this->defaultSuffix; } - protected function findTemplate($name, $acceptDeprecation) + protected function findTemplate($name, $throw = true) { - if ($acceptDeprecation === false) { - return false; - } - $name = (string) $name; // normalize name @@ -82,7 +78,10 @@ protected function findTemplate($name, $acceptDeprecation) return $this->cache[$name] = $path.'/'.$name; } } - - throw new Twig_Error_Loader(sprintf('Unable to find template "%s" (looked into: %s).', $name, implode(', ', $this->paths[$namespace]))); + if ($throw) { + throw new Twig_Error_Loader(sprintf('Unable to find template "%s" (looked into: %s).', $name, implode(', ', $this->paths[$namespace]))); + } else { + return false; + } } }