fix: names and saved data after test on real app

Author: a-chacon

app/models/rails_url_shortener/visit.rb

@@ -9,8 +9,6 @@ class Visit < ApplicationRecord
     # Return boolean
 
     def self.parse_and_save(url, request)
-      # replace some invalid characters
-      heads = request.headers.map { |k| k.to_s.encode('UTF-8', invalid: :replace, undef: :replace, replace: '?') }.join
       # browser detection
       browser = Browser.new(request.headers['User-Agent'])
       if !RailsUrlShortener.save_bots_visits && browser.bot?
@@ -25,8 +23,7 @@ def self.parse_and_save(url, request)
           platform: browser.platform.name,
           platform_version: browser.platform.version,
           bot: browser.bot?,
-          user_agent: request.headers['User-Agent'],
-          meta: heads.to_json
+          user_agent: request.headers['User-Agent']
         )
       end
     end

lib/generators/rails_url_shortener/initializer_generator.rb renamed to lib/generators/rails_url_shortener/rails_url_shortener_generator.rb

@@ -1,9 +1,9 @@
 require 'rails/generators'
 
-class InitializerGenerator < Rails::Generators::NamedBase
+class RailsUrlShortenerGenerator < Rails::Generators::Base
 
   source_root File.expand_path("templates", __dir__)
-  
+
   def copy
     copy_file "initializer.rb", "config/initializers/rails_url_shortener.rb"
   end

lib/generators/rails_url_shortener/templates/initializer.rb

@@ -1,7 +1,11 @@
-RailsUrlShortener do |r|
-  r.default_redirect = "/"
-  r.charset = CHARSETS[:alphanumcase]
-  r.key_length = 6
-  r.minimum_key_length = 3
-  r.save_bots_visits = false
-end
+CHARSETS = {
+  alphanum: ('a'..'z').to_a + (0..9).to_a,
+  alphacase: ('a'..'z').to_a + ('A'..'Z').to_a,
+  alphanumcase: ('A'..'Z').to_a + ('a'..'z').to_a  + (0..9).to_a
+}
+
+RailsUrlShortener.default_redirect = "/"
+RailsUrlShortener.charset = CHARSETS[:alphanumcase]
+RailsUrlShortener.key_length = 6
+RailsUrlShortener.minimum_key_length = 3
+RailsUrlShortener.save_bots_visits = false

lib/rails_url_shortener/engine.rb

@@ -1,5 +1,6 @@
 module RailsUrlShortener
   class Engine < ::Rails::Engine
     isolate_namespace RailsUrlShortener
+    require 'browser'
   end
 end

test/lib/generators/rails_url_shortener/initializer_generator_test.rb renamed to test/lib/generators/rails_url_shortener/rails_url_shortener_generator_test.rb

@@ -1,9 +1,9 @@
 require "test_helper"
-require "generators/rails_url_shortener/initializer_generator"
+require "generators/rails_url_shortener/rails_url_shortener_generator"
 
 module RailsUrlShortener
-  class InitializerGeneratorTest < Rails::Generators::TestCase
-    tests InitializerGenerator
+  class RailsUrlShortenerGeneratorTest < Rails::Generators::TestCase
+    tests RailsUrlShortenerGenerator
     destination Rails.root.join("tmp/generators")
     setup :prepare_destination